From: Max Nikulin <email@example.com> To: firstname.lastname@example.org Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Sun, 17 Oct 2021 23:35:41 +0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <87bl3pcvgl.fsf@localhost> On 16/10/2021 13:52, Ihor Radchenko wrote: > Max Nikulin writes: > >> It seems, each case of `org-no-popups' may require specific code. I have >> tried to take some code related to completion. It overrides >> display-buffer-base-action, but something more is required for >> pop-up-frames. > > I think you went too far. display-buffer-base-action is mostly for user > to specify. We should not override it. If user needs adjustments for > *Org Help*, it is always possible using a custom function inside > display-buffer-base-action. I do not think that we need to do this job > for the user. > > From my perspective, there is no need to prevent users from shooting > their own leg (we are in Emacs after all). The cases we may need to > interfere are: (1) when some user customisations are mostly ok, except > they affect Org's usability, and the user has no easy way to fix it; (2) > when some customisation is very common and we significantly help many > users by supporting such customisation in Org itself. > > I think pop-up-windows customisation qualifies for "(1)". Not > display-buffer-base-action. I may be wrong but from https://www.gnu.org/software/emacs/manual/html_node/elisp/Displaying-Buffers.html "Displaying a Buffer in a Suitable Window" I have an impression that the purpose of `display-buffer-base-action' is e.g. to say "please, show every buffer in a new frame". However there are certainly small buffers (e.g. "*Completion*") that do not deserve own frames, so it is responsibility of `display-buffer' caller to pass an argument that overrides *default* action. User may still customize `display-buffer-alist' to override `display-buffer' argument. Notice that I left `display-buffer-overriding-action' (highest priority variable) untouched. There are another type of buffers, e.g. "*Backtrace*". New frame is created for them but on quit from debugger they disappear from the screen (actually they become iconified) till next error. I believe, Org should provide similar hints ("show this small window below this buffer" for org-goto help, "hide this window on quit" for edit src) with priority in between of `display-buffer-base-action' and `display-buffer-alist'. Since `org-no-popups' is used in both cases and due to API related to `display-buffer', it is impossible to just fix `org-no-popups'. Some new macros or functions should be introduced. So (setq display-buffer-base-action '((display-buffer-reuse-window display-buffer-pop-up-frame) (reusable-frames . 0))) should not be considered as shooting a foot.
next prev parent reply other threads:[~2021-10-17 16:36 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:31 Adam Porter 2021-10-05 11:35 ` Max Nikulin 2021-10-05 12:45 ` [PATCH] " Ihor Radchenko 2021-10-05 12:52 ` Adam Porter 2021-10-05 14:49 ` Max Nikulin 2021-10-05 16:32 ` Ihor Radchenko 2021-10-07 16:14 ` Max Nikulin 2021-10-08 10:22 ` Marco Wahl 2021-10-12 14:59 ` Max Nikulin 2021-10-12 20:58 ` Marco Wahl 2021-10-13 1:35 ` Ihor Radchenko 2021-10-13 9:44 ` Marco Wahl 2021-10-13 12:23 ` Max Nikulin 2021-10-13 12:35 ` Eric S Fraga 2021-10-14 9:54 ` Marco Wahl 2021-10-14 10:16 ` Ihor Radchenko 2021-10-14 15:44 ` Max Nikulin 2021-10-15 16:37 ` Max Nikulin 2021-10-16 6:52 ` Ihor Radchenko 2021-10-17 16:35 ` Max Nikulin [this message] 2021-10-18 9:25 ` Eric S Fraga 2021-10-18 16:53 ` Max Nikulin 2021-10-19 7:45 ` Eric S Fraga 2021-10-05 12:48 ` Adam Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).