From: Max Nikulin <firstname.lastname@example.org> To: email@example.com Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Wed, 13 Oct 2021 19:23:35 +0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 13/10/2021 16:44, Marco Wahl wrote: > > Clearly I'm for kicking out org-no-popups completely. Many details have > been mentioned already. The big argument for that change for me is that > the code gets simpler. I have no strong opinion. Second patch locally restoring `pop-up-windows' is more suitable for the bugfix branch since it is closer to older behavior. Dropping the macro completely may be a step to future, so first version of patch is more suitable for main (do not forget to drop other variant during merge however). I am not confident with complicated `display-buffer' machinery. It has action argument that looks promising to specify local hint to override default actions but to let users customize `display-buffer-alist'. I have no idea of particular hint for `org-goto' though. Unfortunately `with-output-to-temp-buffer' used there does not allow to specify action argument for `display-buffer'. Unsure if `temp-buffer-setup-hook' can be used to prepare a window for `display-buffer'. Does someone have settings that pins help buffer to particular window/frame of location in a frame (e.g. bottom of "sidebar")?
next prev parent reply other threads:[~2021-10-13 12:25 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:31 Adam Porter 2021-10-05 11:35 ` Max Nikulin 2021-10-05 12:45 ` [PATCH] " Ihor Radchenko 2021-10-05 12:52 ` Adam Porter 2021-10-05 14:49 ` Max Nikulin 2021-10-05 16:32 ` Ihor Radchenko 2021-10-07 16:14 ` Max Nikulin 2021-10-08 10:22 ` Marco Wahl 2021-10-12 14:59 ` Max Nikulin 2021-10-12 20:58 ` Marco Wahl 2021-10-13 1:35 ` Ihor Radchenko 2021-10-13 9:44 ` Marco Wahl 2021-10-13 12:23 ` Max Nikulin [this message] 2021-10-13 12:35 ` Eric S Fraga 2021-10-14 9:54 ` Marco Wahl 2021-10-14 10:16 ` Ihor Radchenko 2021-10-14 15:44 ` Max Nikulin 2021-10-15 16:37 ` Max Nikulin 2021-10-16 6:52 ` Ihor Radchenko 2021-10-17 16:35 ` Max Nikulin 2021-10-18 9:25 ` Eric S Fraga 2021-10-18 16:53 ` Max Nikulin 2021-10-19 7:45 ` Eric S Fraga 2021-10-05 12:48 ` Adam Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).