From: Marco Wahl <email@example.com> To: Max Nikulin <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Tue, 12 Oct 2021 22:58:09 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Max Nikulin's message of "Tue, 12 Oct 2021 21:59:23 +0700") Hi Max and all! > On 08/10/2021 17:22, Marco Wahl wrote: >> Max Nikulin writes: >>> On 05/10/2021 23:32, Ihor Radchenko wrote: >>>> Max Nikulin writes: >>>> I tried come up with the reason why org-no-popup was used in the >>>> initial >>>> implementation. I think, the reason is avoiding situation like what you >>>> may see after running >>>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto)) >>>> So, removing the macro completely is not a good idea. >>>> I have updated the patch that should work without dropping the >>>> macro. >>>> See the attached. >> >> Please note the documentation of variable `pop-up-windows'. >> >> This variable is provided mainly for backward compatibility and >> should not be used in new code. >> >> The same holds for `pop-up-frames'. >> >> The drop of the macro looks like a good idea to me. Can someone please >> describe the price for dropping macro `org-no-popups'? >> >> @Ihor I do not understand what "situation" you mean. > > Marco, have you tried > (setq pop-up-frames t) > with first version of patch? It shows help in a new separate frame. > Unsure if it is expected behavior even with such customization. > > However current version of macro does not protect against > > (setq display-buffer-base-action > '((display-buffer-reuse-window display-buffer-pop-up-frame) > (reusable-frames . 0))) > > The example is taken from (info "(elisp) Choosing Window Options"). I > have no idea if such customization can be considered as shooting a foot. TBH I don't fully understand that display-buffer stuff. I experimented a little with regards to org-goto. AFAICT org-goto does a good job without macro org-no-popups. IIUC the use of macro org-no-popups in org-goto shall "protect" the org-goto user interface in some sense. You already mentioned that. My feeling is that the "protection" is good intention but brings more harm than good. I think it's not a good idea to enforce a certain window setting. I guess the knowing user has an easier path to fine tune the org-goto user interface when there is less "protection". > http://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=399481bad10845a77f210c9320ff1efee9a312c8 > that caused the current problem changed namely `pop-up-windows' Thanks for the link! AFAICT the change in org-macs.el should not be in that commit since it has nothing to do with org links -- which are the actual concern of that commit. And indeed the change in org-macs.el of that commit broke the org-goto interface some. Summary: The org-goto interface today is somewhat broken. I vote for taking the occasion and kicking out the macro org-no-popups entirely. This way the org-goto interface is functional AFAICS. If problems occur on that path we'll take care and action. Do you agree? Regards, -- Marco
next prev parent reply other threads:[~2021-10-12 20:59 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:31 Adam Porter 2021-10-05 11:35 ` Max Nikulin 2021-10-05 12:45 ` [PATCH] " Ihor Radchenko 2021-10-05 12:52 ` Adam Porter 2021-10-05 14:49 ` Max Nikulin 2021-10-05 16:32 ` Ihor Radchenko 2021-10-07 16:14 ` Max Nikulin 2021-10-08 10:22 ` Marco Wahl 2021-10-12 14:59 ` Max Nikulin 2021-10-12 20:58 ` Marco Wahl [this message] 2021-10-13 1:35 ` Ihor Radchenko 2021-10-13 9:44 ` Marco Wahl 2021-10-13 12:23 ` Max Nikulin 2021-10-13 12:35 ` Eric S Fraga 2021-10-14 9:54 ` Marco Wahl 2021-10-14 10:16 ` Ihor Radchenko 2021-10-14 15:44 ` Max Nikulin 2021-10-15 16:37 ` Max Nikulin 2021-10-16 6:52 ` Ihor Radchenko 2021-10-17 16:35 ` Max Nikulin 2021-10-18 9:25 ` Eric S Fraga 2021-10-18 16:53 ` Max Nikulin 2021-10-19 7:45 ` Eric S Fraga 2021-10-05 12:48 ` Adam Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).