From: Max Nikulin <firstname.lastname@example.org> To: email@example.com Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Tue, 5 Oct 2021 21:49:17 +0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <87h7dvy70t.fsf@localhost> On 05/10/2021 19:45, Ihor Radchenko wrote: > Max Nikulin writes: > >> Regression is caused by >> >> commit 399481bad10845a77f210c9320ff1efee9a312c8 >> Author: Ihor Radchenko <email@example.com> >> Date: Mon May 31 20:47:45 2021 +0800 >> >> Do not ignore user-defined display-buffer-alist in org-insert-link > > See the attached fix. The fix looks reasonable, though I fail to > understand why org-no-popup was even used in org-goto-location. We kind > of want a popup there. git blame did not reveal anything useful either. Thank you, Ihor. I am a user of alternative `org-goto' interface. I have tried default one having a couple of windows in the frame (indirect buffer for subtree, indirect for src block). It seems, previous window configuration is restored correctly when `org-goto' is finished. Curiously `org-no-popup' was introduced namely for `org-goto` > commit b508943d329fed2af457c50afd5f63938b23c58c > Author: Achim Gratz <Stromeko@Stromeko.DE> > Date: Thu Dec 20 10:18:02 2012 +0100 > > org-compat: new macro org-no-popups > > * lisp/org-compat.el (org-no-popups): New wrapper macro which > let-binds the correct variables to suppress popup windows depending > on the Emacs version in use. This is a compile-time decision when > byte-compiling. > > * lisp/org.el (org-get-location, org-switch-to-buffer-other-window): > Use the wrapper `org-no-popups´ to let-bind the correct variables > for suppression of popup window To emphasize actual changes due to the patch just suggested by Ihor: git diff -b HEAD~ diff --git a/lisp/org-goto.el b/lisp/org-goto.el index 0a3470f54..352bf9f2e 100644 --- a/lisp/org-goto.el +++ b/lisp/org-goto.el @@ -203,7 +203,6 @@ When nil, you can use these keybindings to navigate the buffer: "Let the user select a location in current buffer. This function uses a recursive edit. It returns the selected position or nil." - (org-no-popups (let ((isearch-mode-map org-goto-local-auto-isearch-map) (isearch-hide-immediately nil) (isearch-search-fun-function @@ -236,7 +235,7 @@ position or nil." (use-local-map org-goto-map) (recursive-edit))) (kill-buffer "*org-goto*") - (cons org-goto-selected-point org-goto-exit-command)))) + (cons org-goto-selected-point org-goto-exit-command))) ;;;###autoload (defun org-goto (&optional alternative-interface)
next prev parent reply other threads:[~2021-10-05 15:03 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:31 Adam Porter 2021-10-05 11:35 ` Max Nikulin 2021-10-05 12:45 ` [PATCH] " Ihor Radchenko 2021-10-05 12:52 ` Adam Porter 2021-10-05 14:49 ` Max Nikulin [this message] 2021-10-05 16:32 ` Ihor Radchenko 2021-10-07 16:14 ` Max Nikulin 2021-10-08 10:22 ` Marco Wahl 2021-10-12 14:59 ` Max Nikulin 2021-10-12 20:58 ` Marco Wahl 2021-10-13 1:35 ` Ihor Radchenko 2021-10-13 9:44 ` Marco Wahl 2021-10-13 12:23 ` Max Nikulin 2021-10-13 12:35 ` Eric S Fraga 2021-10-14 9:54 ` Marco Wahl 2021-10-14 10:16 ` Ihor Radchenko 2021-10-14 15:44 ` Max Nikulin 2021-10-15 16:37 ` Max Nikulin 2021-10-16 6:52 ` Ihor Radchenko 2021-10-17 16:35 ` Max Nikulin 2021-10-18 9:25 ` Eric S Fraga 2021-10-18 16:53 ` Max Nikulin 2021-10-19 7:45 ` Eric S Fraga 2021-10-05 12:48 ` Adam Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org' \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).