From: Marco Wahl <marcowahlsoft@gmail.com>
To: Max Nikulin <manikulin@gmail.com>,
Ihor Radchenko <yantar92@gmail.com>,
Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken
Date: Fri, 08 Oct 2021 12:22:18 +0200 [thread overview]
Message-ID: <878rz3ddet.fsf@gmail.com> (raw)
In-Reply-To: <sjn6dm$10rv$1@ciao.gmane.io> (Max Nikulin's message of "Thu, 7 Oct 2021 23:14:45 +0700")
Max Nikulin <manikulin@gmail.com> writes:
> On 05/10/2021 23:32, Ihor Radchenko wrote:
>> Max Nikulin writes:
>> I tried come up with the reason why org-no-popup was used in the
>> initial
>> implementation. I think, the reason is avoiding situation like what you
>> may see after running
>> (let ((pop-up-frames t)) (funcall-interactively #'org-goto))
>> So, removing the macro completely is not a good idea.
>> I have updated the patch that should work without dropping the
>> macro.
>> See the attached.
>
> Thank you, Ihor.
>
> Your updated patch works in default configuration (-Q). I am not
> familiar with knobs of `display-buffer' function so I have no idea if
> someone may complain that such variant overrides his setup or works
> incorrectly with his preferences.
Please note the documentation of variable `pop-up-windows'.
This variable is provided mainly for backward compatibility and
should not be used in new code.
The same holds for `pop-up-frames'.
The drop of the macro looks like a good idea to me. Can someone please
describe the price for dropping macro `org-no-popups'?
@Ihor I do not understand what "situation" you mean.
next prev parent reply other threads:[~2021-10-08 10:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 6:31 [BUG] Org 9.5: org-goto UI seems broken Adam Porter
2021-10-05 11:35 ` Max Nikulin
2021-10-05 12:45 ` [PATCH] " Ihor Radchenko
2021-10-05 12:52 ` Adam Porter
2021-10-05 14:49 ` Max Nikulin
2021-10-05 16:32 ` Ihor Radchenko
2021-10-07 16:14 ` Max Nikulin
2021-10-08 10:22 ` Marco Wahl [this message]
2021-10-12 14:59 ` Max Nikulin
2021-10-12 20:58 ` Marco Wahl
2021-10-13 1:35 ` Ihor Radchenko
2021-10-13 9:44 ` Marco Wahl
2021-10-13 12:23 ` Max Nikulin
2021-10-13 12:35 ` Eric S Fraga
2021-10-14 9:54 ` Marco Wahl
2021-10-14 10:16 ` Ihor Radchenko
2021-10-14 15:44 ` Max Nikulin
2021-10-15 16:37 ` Max Nikulin
2021-10-16 6:52 ` Ihor Radchenko
2021-10-17 16:35 ` Max Nikulin
2021-10-18 9:25 ` Eric S Fraga
2021-10-18 16:53 ` Max Nikulin
2021-10-19 7:45 ` Eric S Fraga
2021-10-05 12:48 ` Adam Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rz3ddet.fsf@gmail.com \
--to=marcowahlsoft@gmail.com \
--cc=adam@alphapapa.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).