From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken
Date: Thu, 14 Oct 2021 22:44:55 +0700 [thread overview]
Message-ID: <sk9j9p$16dn$1@ciao.gmane.io> (raw)
In-Reply-To: <87h7djdi7k.fsf@localhost>
On 14/10/2021 17:16, Ihor Radchenko wrote:
> Marco Wahl writes:
>
>> Since org-goto in main is still broken I'll commit the fix for org-goto
>> which kicks out the use of the macro org-no-popups (but not the macro
>> itself since it's used elsewhere AFAICS.)
>>
>> Max, Ihor! If you see the necessity of refinement please keep going!
>
> I am inclined to think that org-no-popups may still be useful to
> suppress pop-up-frames. However, no so much for pop-up-windows. Note
> that I introduced pop-up-windows let-binding in org-no-popups in place
> of overriding display-buffer-alist. However, I did not fully understand
> pop-up-windows does and the current let-binding actually changes
> pop-up-windows value to nil (t is the Emacs default). I think we can
> simply remove pop-up-windows binding from org-no-popups. Feel free to
> commit this change. I am currently working on org-element-cache and do
> not spend much time on other patches.
Today I am against dropping of `org-no-popups'. Since Ihor confirmed
that he had no particular reason to add `pop-up-windows', the minimal
change (that should be applied to the bugfix branch)
diff --git a/lisp/org-macs.el b/lisp/org-macs.el
index 52fc09a06..5f2c29c42 100644
--- a/lisp/org-macs.el
+++ b/lisp/org-macs.el
@@ -209,7 +209,7 @@ because otherwise all these markers will point to
nowhere."
(defmacro org-no-popups (&rest body)
"Suppress popup windows and evaluate BODY."
- `(let (pop-up-frames pop-up-windows)
+ `(let (pop-up-frames)
,@body))
^L
I think, something should be done with `org-no-popups'. Assume a user
who has (I have no idea concerning the goal though)
(setq pop-up-frames t)
(setq display-buffer-base-action
'((display-buffer-reuse-window display-buffer-pop-up-frame)
(reusable-frames . 0)))
e.g. https://list.orgmode.org/20200503033854.GA28741@singpolyma-beefy
With "emacs -Q" and above settings completion e.g. for "C-h f" does not
cause creation of a new frame. Org help windows appear in new frames
though. That is why `org-no-popups' should have more code.
Minimal patch works in the cases like
https://list.orgmode.org/87h7ij12t8.fsf@localhost and the one raised in
this thread. I hope it will not break
https://list.orgmode.org/orgmode/871rdtupey.fsf@joshuao.com/T/#u as well.
In the meanwhile I found the following thread on window creation in Org
and `display-buffer' machinery (accessibility concerns were mentioned
besides other things):
https://list.orgmode.org/87eevw7jqk.fsf@gmail.com/T/#u
Jack Kamm. [RFC PATCH] Changes to pop-up source buffers. 2020-01-18 17:33
Unfortunately info "(elisp) Displaying Buffers"
https://www.gnu.org/software/emacs/manual/html_node/elisp/Displaying-Buffers.html
is a reference rather than a guide. I have not realized when
`pop-up-frames' or its modern equivalent can be convenient. I have not
tried Eric's setup yet.
>> BTW I think the name *Org Help* for the UI buffer could be better.
>
> Do you have better ideas? Maybe something like *Org-goto Help*? If we
> want to change it, we may want to do it now, before users actually use
> *Org Help* name i.e. in display-buffer-alist. display-buffer-alist did
> not affect *Org Help* before 399481bad, so we have low odds to break
> anybody's config yet.
Are there use cases when "*Org Help*" is not specific enough and more
than one help window should be shown simultaneously or they should be
shown in different sides?
P.S. Example of complex window setup unrelated to Org:
info "(elisp) Frame Layouts with Side Windows"
https://www.gnu.org/software/emacs/manual/html_node/elisp/Frame-Layouts-with-Side-Windows.html
next prev parent reply other threads:[~2021-10-14 15:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 6:31 [BUG] Org 9.5: org-goto UI seems broken Adam Porter
2021-10-05 11:35 ` Max Nikulin
2021-10-05 12:45 ` [PATCH] " Ihor Radchenko
2021-10-05 12:52 ` Adam Porter
2021-10-05 14:49 ` Max Nikulin
2021-10-05 16:32 ` Ihor Radchenko
2021-10-07 16:14 ` Max Nikulin
2021-10-08 10:22 ` Marco Wahl
2021-10-12 14:59 ` Max Nikulin
2021-10-12 20:58 ` Marco Wahl
2021-10-13 1:35 ` Ihor Radchenko
2021-10-13 9:44 ` Marco Wahl
2021-10-13 12:23 ` Max Nikulin
2021-10-13 12:35 ` Eric S Fraga
2021-10-14 9:54 ` Marco Wahl
2021-10-14 10:16 ` Ihor Radchenko
2021-10-14 15:44 ` Max Nikulin [this message]
2021-10-15 16:37 ` Max Nikulin
2021-10-16 6:52 ` Ihor Radchenko
2021-10-17 16:35 ` Max Nikulin
2021-10-18 9:25 ` Eric S Fraga
2021-10-18 16:53 ` Max Nikulin
2021-10-19 7:45 ` Eric S Fraga
2021-10-05 12:48 ` Adam Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='sk9j9p$16dn$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).