From: Ihor Radchenko <firstname.lastname@example.org> To: Marco Wahl <email@example.com> Cc: Org Mode List <firstname.lastname@example.org> Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Thu, 14 Oct 2021 18:16:47 +0800 [thread overview] Message-ID: <87h7djdi7k.fsf@localhost> (raw) In-Reply-To: <email@example.com> Marco Wahl <firstname.lastname@example.org> writes: > Since org-goto in main is still broken I'll commit the fix for org-goto > which kicks out the use of the macro org-no-popups (but not the macro > itself since it's used elsewhere AFAICS.) > > Max, Ihor! If you see the necessity of refinement please keep going! I am inclined to think that org-no-popups may still be useful to suppress pop-up-frames. However, no so much for pop-up-windows. Note that I introduced pop-up-windows let-binding in org-no-popups in place of overriding display-buffer-alist. However, I did not fully understand pop-up-windows does and the current let-binding actually changes pop-up-windows value to nil (t is the Emacs default). I think we can simply remove pop-up-windows binding from org-no-popups. Feel free to commit this change. I am currently working on org-element-cache and do not spend much time on other patches. > BTW I think the name *Org Help* for the UI buffer could be better. Do you have better ideas? Maybe something like *Org-goto Help*? If we want to change it, we may want to do it now, before users actually use *Org Help* name i.e. in display-buffer-alist. display-buffer-alist did not affect *Org Help* before 399481bad, so we have low odds to break anybody's config yet. Best, Ihor
next prev parent reply other threads:[~2021-10-14 10:17 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 6:31 Adam Porter 2021-10-05 11:35 ` Max Nikulin 2021-10-05 12:45 ` [PATCH] " Ihor Radchenko 2021-10-05 12:52 ` Adam Porter 2021-10-05 14:49 ` Max Nikulin 2021-10-05 16:32 ` Ihor Radchenko 2021-10-07 16:14 ` Max Nikulin 2021-10-08 10:22 ` Marco Wahl 2021-10-12 14:59 ` Max Nikulin 2021-10-12 20:58 ` Marco Wahl 2021-10-13 1:35 ` Ihor Radchenko 2021-10-13 9:44 ` Marco Wahl 2021-10-13 12:23 ` Max Nikulin 2021-10-13 12:35 ` Eric S Fraga 2021-10-14 9:54 ` Marco Wahl 2021-10-14 10:16 ` Ihor Radchenko [this message] 2021-10-14 15:44 ` Max Nikulin 2021-10-15 16:37 ` Max Nikulin 2021-10-16 6:52 ` Ihor Radchenko 2021-10-17 16:35 ` Max Nikulin 2021-10-18 9:25 ` Eric S Fraga 2021-10-18 16:53 ` Max Nikulin 2021-10-19 7:45 ` Eric S Fraga 2021-10-05 12:48 ` Adam Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h7djdi7k.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).