From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EJnDBhdRbGEGhgEAgWs5BA (envelope-from ) for ; Sun, 17 Oct 2021 18:36:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KKZwAhdRbGEmDgAAB5/wlQ (envelope-from ) for ; Sun, 17 Oct 2021 16:36:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A1390162AF for ; Sun, 17 Oct 2021 18:36:38 +0200 (CEST) Received: from localhost ([::1]:47586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mc99J-0007Xz-Q2 for larch@yhetil.org; Sun, 17 Oct 2021 12:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mc98h-0007WE-FQ for emacs-orgmode@gnu.org; Sun, 17 Oct 2021 12:35:59 -0400 Received: from ciao.gmane.io ([116.202.254.214]:42726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mc98d-0008RK-1W for emacs-orgmode@gnu.org; Sun, 17 Oct 2021 12:35:56 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mc98Z-0006Rh-VJ for emacs-orgmode@gnu.org; Sun, 17 Oct 2021 18:35:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken Date: Sun, 17 Oct 2021 23:35:41 +0700 Message-ID: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> <87o87tso54.fsf@localhost> <87pms9mf7v.fsf@gmail.com> <878ryx14sd.fsf@ucl.ac.uk> <87fst46ifa.fsf@gmail.com> <87h7djdi7k.fsf@localhost> <87bl3pcvgl.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <87bl3pcvgl.fsf@localhost> Content-Language: en-US Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634488598; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=IKdRjb84S6rlDIR5SQ0aaI0ijB3tv3XODqdjMVsSB90=; b=XVwzNRK2X85oKAbjfSVpz4r6XoaQP/gMTMCCQeoiXO5MeBXzc6VxJl7yf/Zd6c6IJecDmk ZAkjIIjzbESc6E5Km2qhoHPW95If7AMrIIcQMKyF27pAB1k05QRRxoVKHhbaAMT0hweGNU kCZlFpyBlYKaorOwbKlAY1l2CbjktOmN5WoeKw5qeTAzNNiV+PTXtk+7fKLKxDDE0ROoKY QdBbYvE2zxox3P1HsS2DrN1H7VYVo1KqiLFZMW7uKE1wvxMc98/cXaaWAaotfa0oc6V9os XbKy0MPz+oooO1BwMOZ08AsPwXYTQrhWUpszrr9/wIelw7RpOdFBzw5UerOyVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634488598; a=rsa-sha256; cv=none; b=TYtcDGNh8ENJooLYCkXt5H1O+zbeomDxDK1IzTqxt+xRBO4WQzPhWV077CjjNuth6hKdKd Qw0NX+nTHK4aVy0O++iI2humcUhBX+gV84aLDPhxJV+Ie6hDJfmrGMdwcKjgH4PSDaRzUR jdAfyXwsrwy9h168YNQVY3CYOr+48MxDCuehrY5dweIYdrnzzd0OjEyxfsA3UaSGHicCrN dlH5iR46McRBjxb6AHau9zXYGUXN3CefmB8eDNjc+Phsd0kmvQq+iMwGzEl1mcBXR9pYjp Jr+oqPYGtJy9JjK0y3VssrOV8asT25chz84Otv8X5DzkCJvgZAJEKUBTWC2nUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A1390162AF X-Spam-Score: -2.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: TYR5nj3axFRr On 16/10/2021 13:52, Ihor Radchenko wrote: > Max Nikulin writes: > >> It seems, each case of `org-no-popups' may require specific code. I have >> tried to take some code related to completion. It overrides >> display-buffer-base-action, but something more is required for >> pop-up-frames. > > I think you went too far. display-buffer-base-action is mostly for user > to specify. We should not override it. If user needs adjustments for > *Org Help*, it is always possible using a custom function inside > display-buffer-base-action. I do not think that we need to do this job > for the user. > > From my perspective, there is no need to prevent users from shooting > their own leg (we are in Emacs after all). The cases we may need to > interfere are: (1) when some user customisations are mostly ok, except > they affect Org's usability, and the user has no easy way to fix it; (2) > when some customisation is very common and we significantly help many > users by supporting such customisation in Org itself. > > I think pop-up-windows customisation qualifies for "(1)". Not > display-buffer-base-action. I may be wrong but from https://www.gnu.org/software/emacs/manual/html_node/elisp/Displaying-Buffers.html "Displaying a Buffer in a Suitable Window" I have an impression that the purpose of `display-buffer-base-action' is e.g. to say "please, show every buffer in a new frame". However there are certainly small buffers (e.g. "*Completion*") that do not deserve own frames, so it is responsibility of `display-buffer' caller to pass an argument that overrides *default* action. User may still customize `display-buffer-alist' to override `display-buffer' argument. Notice that I left `display-buffer-overriding-action' (highest priority variable) untouched. There are another type of buffers, e.g. "*Backtrace*". New frame is created for them but on quit from debugger they disappear from the screen (actually they become iconified) till next error. I believe, Org should provide similar hints ("show this small window below this buffer" for org-goto help, "hide this window on quit" for edit src) with priority in between of `display-buffer-base-action' and `display-buffer-alist'. Since `org-no-popups' is used in both cases and due to API related to `display-buffer', it is impossible to just fix `org-no-popups'. Some new macros or functions should be introduced. So (setq display-buffer-base-action '((display-buffer-reuse-window display-buffer-pop-up-frame) (reusable-frames . 0))) should not be considered as shooting a foot.