emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
@ 2010-08-26  8:28 Noorul Islam
  2010-08-26 12:14 ` Eric Schulte
  0 siblings, 1 reply; 8+ messages in thread
From: Noorul Islam @ 2010-08-26  8:28 UTC (permalink / raw)
  To: emacs-org list


[-- Attachment #1.1: Type: text/plain, Size: 244 bytes --]

Latest pull is throwing error while quitting emacs.

Here is the patch to fix this.

ob.el:  Fix minor bug

* lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
arguments to (delete-directory)

Thanks and Regards
Noorul

[-- Attachment #1.2: Type: text/html, Size: 353 bytes --]

[-- Attachment #2: ob.txt --]
[-- Type: text/plain, Size: 505 bytes --]

diff --git a/lisp/ob.el b/lisp/ob.el
index 33dbfef..32e2a54 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
 (defun org-babel-remove-temporary-directory ()
   "Remove `org-babel-temporary-directory' on Emacs shutdown."
   (when (boundp 'org-babel-temporary-directory)
-    (delete-directory org-babel-temporary-directory t)))
+    (delete-directory org-babel-temporary-directory)))
 
 (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
 

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply related	[flat|nested] 8+ messages in thread

• * Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
    2010-08-26  8:28 [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Noorul Islam
  @ 2010-08-26 12:14 ` Eric Schulte
    2010-08-26 12:29   ` Noorul Islam
    2010-08-26 13:31   ` Detlef Steuer
    0 siblings, 2 replies; 8+ messages in thread
  From: Eric Schulte @ 2010-08-26 12:14 UTC (permalink / raw)
    To: Noorul Islam; +Cc: emacs-org list
  
  Hi Noorul,
  
  Can I ask what error the directory deletion is causing for you?
  
  I have the following delete-directory in my Emacs (latest from Git)
  
  ,----[delete-directory]
  | delete-directory is an interactive compiled Lisp function in
  | `files.el'.
  | 
  | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
  | 
  | Delete the directory named DIRECTORY.  Does not follow symlinks.
  | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
  | TRASH non-nil means to trash the directory instead, provided
  | `delete-by-moving-to-trash' is non-nil.
  | 
  | When called interactively, TRASH is t if no prefix argument is
  | given.  With a prefix argument, TRASH is nil.
  | 
  | [back]
  `----
  
  The second argument to `delete-directory' ensures that subdirectories
  are recursively deleted.  Are you using a different version of Emacs
  (maybe XEmacs?) in which `delete-directory' accepts a different number
  of arguments?
  
  Thanks -- Eric
  
  Noorul Islam <noorul@noorul.com> writes:
  
  > Latest pull is throwing error while quitting emacs.
  >
  > Here is the patch to fix this.
  >
  > ob.el:  Fix minor bug
  >
  > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
  > arguments to (delete-directory)
  >
  > Thanks and Regards
  > Noorul
  >
  > diff --git a/lisp/ob.el b/lisp/ob.el
  > index 33dbfef..32e2a54 100644
  > --- a/lisp/ob.el
  > +++ b/lisp/ob.el
  > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
  >  (defun org-babel-remove-temporary-directory ()
  >    "Remove `org-babel-temporary-directory' on Emacs shutdown."
  >    (when (boundp 'org-babel-temporary-directory)
  > -    (delete-directory org-babel-temporary-directory t)))
  > +    (delete-directory org-babel-temporary-directory)))
  >  
  >  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
  >  
  > _______________________________________________
  > Emacs-orgmode mailing list
  > Please use `Reply All' to send replies to the list.
  > Emacs-orgmode@gnu.org
  > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
  
  ^ permalink raw reply	[flat|nested] 8+ messages in thread

• • * Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
      2010-08-26 12:14 ` Eric Schulte
    @ 2010-08-26 12:29   ` Noorul Islam
      2010-08-26 13:25     ` Eric Schulte
      2010-08-26 13:31   ` Detlef Steuer
      1 sibling, 1 reply; 8+ messages in thread
    From: Noorul Islam @ 2010-08-26 12:29 UTC (permalink / raw)
      To: Eric Schulte; +Cc: emacs-org list
    
    On Thu, Aug 26, 2010 at 5:44 PM, Eric Schulte <schulte.eric@gmail.com> wrote:
    >
    > Hi Noorul,
    >
    > Can I ask what error the directory deletion is causing for you?
    >
    > I have the following delete-directory in my Emacs (latest from Git)
    >
    > ,----[delete-directory]
    > | delete-directory is an interactive compiled Lisp function in
    > | `files.el'.
    > |
    > | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
    > |
    > | Delete the directory named DIRECTORY.  Does not follow symlinks.
    > | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
    > | TRASH non-nil means to trash the directory instead, provided
    > | `delete-by-moving-to-trash' is non-nil.
    > |
    > | When called interactively, TRASH is t if no prefix argument is
    > | given.  With a prefix argument, TRASH is nil.
    > |
    > | [back]
    > `----
    >
    > The second argument to `delete-directory' ensures that subdirectories
    > are recursively deleted.  Are you using a different version of Emacs
    > (maybe XEmacs?) in which `delete-directory' accepts a different number
    > of arguments?
    >
    
    
    "GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12)
     of 2010-01-30 on noorul"
    
    C-h f delete-directory gives me this
    
    -------------------------------------------------------------------------------------------------
    delete-directory is an interactive built-in function in `C source
    code'.
    
    (delete-directory DIRECTORY)
    
    Delete the directory named DIRECTORY.  Does not follow symlinks.
    --------------------------------------------------------------------------------------------------
    
    Thanks and Regards
    Noorul
    
    >
    > Thanks -- Eric
    >
    > Noorul Islam <noorul@noorul.com> writes:
    >
    > > Latest pull is throwing error while quitting emacs.
    > >
    > > Here is the patch to fix this.
    > >
    > > ob.el:  Fix minor bug
    > >
    > > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
    > > arguments to (delete-directory)
    > >
    > > Thanks and Regards
    > > Noorul
    > >
    > > diff --git a/lisp/ob.el b/lisp/ob.el
    > > index 33dbfef..32e2a54 100644
    > > --- a/lisp/ob.el
    > > +++ b/lisp/ob.el
    > > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
    > >  (defun org-babel-remove-temporary-directory ()
    > >    "Remove `org-babel-temporary-directory' on Emacs shutdown."
    > >    (when (boundp 'org-babel-temporary-directory)
    > > -    (delete-directory org-babel-temporary-directory t)))
    > > +    (delete-directory org-babel-temporary-directory)))
    > >
    > >  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
    > >
    > > _______________________________________________
    > > Emacs-orgmode mailing list
    > > Please use `Reply All' to send replies to the list.
    > > Emacs-orgmode@gnu.org
    > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
    
    ^ permalink raw reply	[flat|nested] 8+ messages in thread

  • • * Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
        2010-08-26 12:29   ` Noorul Islam
      @ 2010-08-26 13:25     ` Eric Schulte
        2010-08-26 22:37       ` Seweryn
        0 siblings, 1 reply; 8+ messages in thread
      From: Eric Schulte @ 2010-08-26 13:25 UTC (permalink / raw)
        To: Noorul Islam; +Cc: emacs-org list
      
      Noorul Islam <noorul@noorul.com> writes:
      
      > On Thu, Aug 26, 2010 at 5:44 PM, Eric Schulte <schulte.eric@gmail.com> wrote:
      >>
      >> Hi Noorul,
      >>
      >> Can I ask what error the directory deletion is causing for you?
      >>
      >> I have the following delete-directory in my Emacs (latest from Git)
      >>
      >> ,----[delete-directory]
      >> | delete-directory is an interactive compiled Lisp function in
      >> | `files.el'.
      >> |
      >> | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
      >> |
      >> | Delete the directory named DIRECTORY.  Does not follow symlinks.
      >> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
      >> | TRASH non-nil means to trash the directory instead, provided
      >> | `delete-by-moving-to-trash' is non-nil.
      >> |
      >> | When called interactively, TRASH is t if no prefix argument is
      >> | given.  With a prefix argument, TRASH is nil.
      >> |
      >> | [back]
      >> `----
      >>
      >> The second argument to `delete-directory' ensures that subdirectories
      >> are recursively deleted.  Are you using a different version of Emacs
      >> (maybe XEmacs?) in which `delete-directory' accepts a different number
      >> of arguments?
      >>
      >
      >
      > "GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12)
      >  of 2010-01-30 on noorul"
      >
      > C-h f delete-directory gives me this
      >
      > -------------------------------------------------------------------------------------------------
      > delete-directory is an interactive built-in function in `C source
      > code'.
      >
      > (delete-directory DIRECTORY)
      >
      > Delete the directory named DIRECTORY.  Does not follow symlinks.
      > --------------------------------------------------------------------------------------------------
      >
      > Thanks and Regards
      > Noorul
      >
      
      Hi Noorul,
      
      Thanks for pointing out the above, I guess files.el can't be assumed to
      be loaded.  I've pushed up a fix.
      
      Thanks -- Eric
      
      >
      >>
      >> Thanks -- Eric
      >>
      >> Noorul Islam <noorul@noorul.com> writes:
      >>
      >> > Latest pull is throwing error while quitting emacs.
      >> >
      >> > Here is the patch to fix this.
      >> >
      >> > ob.el:  Fix minor bug
      >> >
      >> > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
      >> > arguments to (delete-directory)
      >> >
      >> > Thanks and Regards
      >> > Noorul
      >> >
      >> > diff --git a/lisp/ob.el b/lisp/ob.el
      >> > index 33dbfef..32e2a54 100644
      >> > --- a/lisp/ob.el
      >> > +++ b/lisp/ob.el
      >> > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
      >> >  (defun org-babel-remove-temporary-directory ()
      >> >    "Remove `org-babel-temporary-directory' on Emacs shutdown."
      >> >    (when (boundp 'org-babel-temporary-directory)
      >> > -    (delete-directory org-babel-temporary-directory t)))
      >> > +    (delete-directory org-babel-temporary-directory)))
      >> >
      >> >  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
      >> >
      >> > _______________________________________________
      >> > Emacs-orgmode mailing list
      >> > Please use `Reply All' to send replies to the list.
      >> > Emacs-orgmode@gnu.org
      >> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
      
      ^ permalink raw reply	[flat|nested] 8+ messages in thread

    • • * Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
          2010-08-26 13:25     ` Eric Schulte
        @ 2010-08-26 22:37       ` Seweryn
          0 siblings, 0 replies; 8+ messages in thread
        From: Seweryn @ 2010-08-26 22:37 UTC (permalink / raw)
          To: emacs-orgmode
        
        
        > 
        > Hi Noorul,
        > 
        > Thanks for pointing out the above, I guess files.el can't be assumed to
        > be loaded.  I've pushed up a fix.
         
        I have also: 
        ---------------
        delete-directory is an interactive compiled Lisp function in
        `files.el'.
        
        (delete-directory DIRECTORY &optional RECURSIVE)
        
        Delete the directory named DIRECTORY.  Does not follow symlinks.
        If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
        ---------------------
        
        It should be related with these posts on emacs.devel:
        
        http://thread.gmane.org/gmane.emacs.tramp/6964/focus=115812
        http://article.gmane.org/gmane.emacs.devel/115812
        http://article.gmane.org/gmane.emacs.tramp/6974
        
        I don't have files.el loaded explicitely in my .emacs file, and I don't know 
        where it is loaded?
        
        ^ permalink raw reply	[flat|nested] 8+ messages in thread

  • * Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
      2010-08-26 12:14 ` Eric Schulte
      2010-08-26 12:29   ` Noorul Islam
    @ 2010-08-26 13:31   ` Detlef Steuer
      2010-08-27 15:30     ` Erik Iverson
      1 sibling, 1 reply; 8+ messages in thread
    From: Detlef Steuer @ 2010-08-26 13:31 UTC (permalink / raw)
      To: emacs-orgmode
    
    
    Hi Eric,
    
    I have to confirm that bug.
    Org-mode as of today, emacs 23.1.1.
    
    Here is, what my *MESSAGES* buffer tells:
    CONTENTS...done
    (No files need saving)
    org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2
    When done with a buffer, type C-x #
    Auto-saving...done
    
    
    Ciao
    Detlef
    
    On Thu, 26 Aug 2010 06:14:26 -0600
    "Eric Schulte" <schulte.eric@gmail.com> wrote:
    
    > Hi Noorul,
    > 
    > Can I ask what error the directory deletion is causing for you?
    > 
    > I have the following delete-directory in my Emacs (latest from Git)
    > 
    > ,----[delete-directory]
    > | delete-directory is an interactive compiled Lisp function in
    > | `files.el'.
    > | 
    > | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
    > | 
    > | Delete the directory named DIRECTORY.  Does not follow symlinks.
    > | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
    > | TRASH non-nil means to trash the directory instead, provided
    > | `delete-by-moving-to-trash' is non-nil.
    > | 
    > | When called interactively, TRASH is t if no prefix argument is
    > | given.  With a prefix argument, TRASH is nil.
    > | 
    > | [back]
    > `----
    > 
    > The second argument to `delete-directory' ensures that subdirectories
    > are recursively deleted.  Are you using a different version of Emacs
    > (maybe XEmacs?) in which `delete-directory' accepts a different number
    > of arguments?
    > 
    > Thanks -- Eric
    > 
    > Noorul Islam <noorul@noorul.com> writes:
    > 
    > > Latest pull is throwing error while quitting emacs.
    > >
    > > Here is the patch to fix this.
    > >
    > > ob.el:  Fix minor bug
    > >
    > > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
    > > arguments to (delete-directory)
    > >
    > > Thanks and Regards
    > > Noorul
    > >
    > > diff --git a/lisp/ob.el b/lisp/ob.el
    > > index 33dbfef..32e2a54 100644
    > > --- a/lisp/ob.el
    > > +++ b/lisp/ob.el
    > > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
    > >  (defun org-babel-remove-temporary-directory ()
    > >    "Remove `org-babel-temporary-directory' on Emacs shutdown."
    > >    (when (boundp 'org-babel-temporary-directory)
    > > -    (delete-directory org-babel-temporary-directory t)))
    > > +    (delete-directory org-babel-temporary-directory)))
    > >  
    > >  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
    > >  
    > > _______________________________________________
    > > Emacs-orgmode mailing list
    > > Please use `Reply All' to send replies to the list.
    > > Emacs-orgmode@gnu.org
    > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
    > 
    > _______________________________________________
    > Emacs-orgmode mailing list
    > Please use `Reply All' to send replies to the list.
    > Emacs-orgmode@gnu.org
    > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
    > 
    
    ^ permalink raw reply	[flat|nested] 8+ messages in thread

  • • * Re: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
        2010-08-26 13:31   ` Detlef Steuer
      @ 2010-08-27 15:30     ` Erik Iverson
        2010-08-27 15:45       ` Eric Schulte
        0 siblings, 1 reply; 8+ messages in thread
      From: Erik Iverson @ 2010-08-27 15:30 UTC (permalink / raw)
        To: Detlef Steuer; +Cc: emacs-orgmode
      
      Hello,
      
      It looks like the delete-directory bug was fixed, but
      on emacs 23.2 at least, (delete-file) only takes one
      argument, so org-babel-remove-temporary-directory is still
      throwing an error in my case, since we have:
      
      	      (delete-file file nil)
      
      --Erik
      
      
      
      Detlef Steuer wrote:
      > Hi Eric,
      > 
      > I have to confirm that bug.
      > Org-mode as of today, emacs 23.1.1.
      > 
      > Here is, what my *MESSAGES* buffer tells:
      > CONTENTS...done
      > (No files need saving)
      > org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2
      > When done with a buffer, type C-x #
      > Auto-saving...done
      > 
      > 
      > Ciao
      > Detlef
      > 
      > On Thu, 26 Aug 2010 06:14:26 -0600
      > "Eric Schulte" <schulte.eric@gmail.com> wrote:
      > 
      >> Hi Noorul,
      >>
      >> Can I ask what error the directory deletion is causing for you?
      >>
      >> I have the following delete-directory in my Emacs (latest from Git)
      >>
      >> ,----[delete-directory]
      >> | delete-directory is an interactive compiled Lisp function in
      >> | `files.el'.
      >> | 
      >> | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
      >> | 
      >> | Delete the directory named DIRECTORY.  Does not follow symlinks.
      >> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
      >> | TRASH non-nil means to trash the directory instead, provided
      >> | `delete-by-moving-to-trash' is non-nil.
      >> | 
      >> | When called interactively, TRASH is t if no prefix argument is
      >> | given.  With a prefix argument, TRASH is nil.
      >> | 
      >> | [back]
      >> `----
      >>
      >> The second argument to `delete-directory' ensures that subdirectories
      >> are recursively deleted.  Are you using a different version of Emacs
      >> (maybe XEmacs?) in which `delete-directory' accepts a different number
      >> of arguments?
      >>
      >> Thanks -- Eric
      >>
      >> Noorul Islam <noorul@noorul.com> writes:
      >>
      >>> Latest pull is throwing error while quitting emacs.
      >>>
      >>> Here is the patch to fix this.
      >>>
      >>> ob.el:  Fix minor bug
      >>>
      >>> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
      >>> arguments to (delete-directory)
      >>>
      >>> Thanks and Regards
      >>> Noorul
      >>>
      >>> diff --git a/lisp/ob.el b/lisp/ob.el
      >>> index 33dbfef..32e2a54 100644
      >>> --- a/lisp/ob.el
      >>> +++ b/lisp/ob.el
      >>> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
      >>>  (defun org-babel-remove-temporary-directory ()
      >>>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
      >>>    (when (boundp 'org-babel-temporary-directory)
      >>> -    (delete-directory org-babel-temporary-directory t)))
      >>> +    (delete-directory org-babel-temporary-directory)))
      >>>  
      >>>  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
      >>>  
      >>> _______________________________________________
      >>> Emacs-orgmode mailing list
      >>> Please use `Reply All' to send replies to the list.
      >>> Emacs-orgmode@gnu.org
      >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
      >> _______________________________________________
      >> Emacs-orgmode mailing list
      >> Please use `Reply All' to send replies to the list.
      >> Emacs-orgmode@gnu.org
      >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
      >>
      > 
      > 
      > 
      > _______________________________________________
      > Emacs-orgmode mailing list
      > Please use `Reply All' to send replies to the list.
      > Emacs-orgmode@gnu.org
      > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
      
      ^ permalink raw reply	[flat|nested] 8+ messages in thread

    • • * Re: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
          2010-08-27 15:30     ` Erik Iverson
        @ 2010-08-27 15:45       ` Eric Schulte
          0 siblings, 0 replies; 8+ messages in thread
        From: Eric Schulte @ 2010-08-27 15:45 UTC (permalink / raw)
          To: Erik Iverson; +Cc: Detlef Steuer, emacs-orgmode
        
        Fixed, Thanks -- Eric
        
        Erik Iverson <eriki@ccbr.umn.edu> writes:
        
        > Hello,
        >
        > It looks like the delete-directory bug was fixed, but
        > on emacs 23.2 at least, (delete-file) only takes one
        > argument, so org-babel-remove-temporary-directory is still
        > throwing an error in my case, since we have:
        >
        > 	      (delete-file file nil)
        >
        > --Erik
        >
        >
        >
        > Detlef Steuer wrote:
        >> Hi Eric,
        >>
        >> I have to confirm that bug.
        >> Org-mode as of today, emacs 23.1.1.
        >>
        >> Here is, what my *MESSAGES* buffer tells:
        >> CONTENTS...done
        >> (No files need saving)
        >> org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2
        >> When done with a buffer, type C-x #
        >> Auto-saving...done
        >>
        >>
        >> Ciao
        >> Detlef
        >>
        >> On Thu, 26 Aug 2010 06:14:26 -0600
        >> "Eric Schulte" <schulte.eric@gmail.com> wrote:
        >>
        >>> Hi Noorul,
        >>>
        >>> Can I ask what error the directory deletion is causing for you?
        >>>
        >>> I have the following delete-directory in my Emacs (latest from Git)
        >>>
        >>> ,----[delete-directory]
        >>> | delete-directory is an interactive compiled Lisp function in
        >>> | `files.el'.
        >>> | | (delete-directory DIRECTORY &optional RECURSIVE TRASH)
        >>> | | Delete the directory named DIRECTORY.  Does not follow
        >>> symlinks.
        >>> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
        >>> | TRASH non-nil means to trash the directory instead, provided
        >>> | `delete-by-moving-to-trash' is non-nil.
        >>> | | When called interactively, TRASH is t if no prefix argument is
        >>> | given.  With a prefix argument, TRASH is nil.
        >>> | | [back]
        >>> `----
        >>>
        >>> The second argument to `delete-directory' ensures that subdirectories
        >>> are recursively deleted.  Are you using a different version of Emacs
        >>> (maybe XEmacs?) in which `delete-directory' accepts a different number
        >>> of arguments?
        >>>
        >>> Thanks -- Eric
        >>>
        >>> Noorul Islam <noorul@noorul.com> writes:
        >>>
        >>>> Latest pull is throwing error while quitting emacs.
        >>>>
        >>>> Here is the patch to fix this.
        >>>>
        >>>> ob.el:  Fix minor bug
        >>>>
        >>>> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
        >>>> arguments to (delete-directory)
        >>>>
        >>>> Thanks and Regards
        >>>> Noorul
        >>>>
        >>>> diff --git a/lisp/ob.el b/lisp/ob.el
        >>>> index 33dbfef..32e2a54 100644
        >>>> --- a/lisp/ob.el
        >>>> +++ b/lisp/ob.el
        >>>> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
        >>>>  (defun org-babel-remove-temporary-directory ()
        >>>>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
        >>>>    (when (boundp 'org-babel-temporary-directory)
        >>>> -    (delete-directory org-babel-temporary-directory t)))
        >>>> +    (delete-directory org-babel-temporary-directory)))
        >>>>   (add-hook 'kill-emacs-hook
        >>>> org-babel-remove-temporary-directory)
        >>>>  _______________________________________________
        >>>> Emacs-orgmode mailing list
        >>>> Please use `Reply All' to send replies to the list.
        >>>> Emacs-orgmode@gnu.org
        >>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
        >>> _______________________________________________
        >>> Emacs-orgmode mailing list
        >>> Please use `Reply All' to send replies to the list.
        >>> Emacs-orgmode@gnu.org
        >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
        >>>
        >>
        >>
        >>
        >> _______________________________________________
        >> Emacs-orgmode mailing list
        >> Please use `Reply All' to send replies to the list.
        >> Emacs-orgmode@gnu.org
        >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
        >
        > _______________________________________________
        > Emacs-orgmode mailing list
        > Please use `Reply All' to send replies to the list.
        > Emacs-orgmode@gnu.org
        > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
        
        ^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2010-08-27 15:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-26  8:28 [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Noorul Islam
2010-08-26 12:14 ` Eric Schulte
2010-08-26 12:29   ` Noorul Islam
2010-08-26 13:25     ` Eric Schulte
2010-08-26 22:37       ` Seweryn
2010-08-26 13:31   ` Detlef Steuer
2010-08-27 15:30     ` Erik Iverson
2010-08-27 15:45       ` Eric Schulte

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).