From mboxrd@z Thu Jan 1 00:00:00 1970 From: Noorul Islam Subject: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Date: Thu, 26 Aug 2010 17:59:07 +0530 Message-ID: References: <87eidl1sgt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=47651 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OobZu-000839-6B for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:29:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OobZs-0001En-Ie for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:29:09 -0400 Received: from mail-gx0-f169.google.com ([209.85.161.169]:42470) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OobZs-0001EU-D8 for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:29:08 -0400 Received: by gxk9 with SMTP id 9so836378gxk.0 for ; Thu, 26 Aug 2010 05:29:07 -0700 (PDT) In-Reply-To: <87eidl1sgt.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: emacs-org list On Thu, Aug 26, 2010 at 5:44 PM, Eric Schulte wrot= e: > > Hi Noorul, > > Can I ask what error the directory deletion is causing for you? > > I have the following delete-directory in my Emacs (latest from Git) > > ,----[delete-directory] > | delete-directory is an interactive compiled Lisp function in > | `files.el'. > | > | (delete-directory DIRECTORY &optional RECURSIVE TRASH) > | > | Delete the directory named DIRECTORY. =A0Does not follow symlinks. > | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well. > | TRASH non-nil means to trash the directory instead, provided > | `delete-by-moving-to-trash' is non-nil. > | > | When called interactively, TRASH is t if no prefix argument is > | given. =A0With a prefix argument, TRASH is nil. > | > | [back] > `---- > > The second argument to `delete-directory' ensures that subdirectories > are recursively deleted. =A0Are you using a different version of Emacs > (maybe XEmacs?) in which `delete-directory' accepts a different number > of arguments? > "GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12) of 2010-01-30 on noorul" C-h f delete-directory gives me this ---------------------------------------------------------------------------= ---------------------- delete-directory is an interactive built-in function in `C source code'. (delete-directory DIRECTORY) Delete the directory named DIRECTORY. Does not follow symlinks. ---------------------------------------------------------------------------= ----------------------- Thanks and Regards Noorul > > Thanks -- Eric > > Noorul Islam writes: > > > Latest pull is throwing error while quitting emacs. > > > > Here is the patch to fix this. > > > > ob.el: =A0Fix minor bug > > > > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct numb= er of > > arguments to (delete-directory) > > > > Thanks and Regards > > Noorul > > > > diff --git a/lisp/ob.el b/lisp/ob.el > > index 33dbfef..32e2a54 100644 > > --- a/lisp/ob.el > > +++ b/lisp/ob.el > > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'." > > =A0(defun org-babel-remove-temporary-directory () > > =A0 =A0"Remove `org-babel-temporary-directory' on Emacs shutdown." > > =A0 =A0(when (boundp 'org-babel-temporary-directory) > > - =A0 =A0(delete-directory org-babel-temporary-directory t))) > > + =A0 =A0(delete-directory org-babel-temporary-directory))) > > > > =A0(add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory) > > > > _______________________________________________ > > Emacs-orgmode mailing list > > Please use `Reply All' to send replies to the list. > > Emacs-orgmode@gnu.org > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode