From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: [PATCH] Latest git pull has bug in
 (org-babel-remove-temporary-directory)
Date: Thu, 26 Aug 2010 06:14:26 -0600
Message-ID: <87eidl1sgt.fsf@gmail.com>
References: <AANLkTinubLMMwFa8K1sN=J8YGeoXAhZ-6zTXKxAvQzOO@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=51521 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OobLq-0001o4-8O
	for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:14:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <schulte.eric@gmail.com>) id 1OobLk-0007KG-Ft
	for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:14:34 -0400
Received: from mail-pv0-f169.google.com ([74.125.83.169]:55329)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <schulte.eric@gmail.com>) id 1OobLk-0007K9-Ba
	for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 08:14:32 -0400
Received: by pvc30 with SMTP id 30so1105103pvc.0
	for <emacs-orgmode@gnu.org>; Thu, 26 Aug 2010 05:14:31 -0700 (PDT)
In-Reply-To: <AANLkTinubLMMwFa8K1sN=J8YGeoXAhZ-6zTXKxAvQzOO@mail.gmail.com>
	(Noorul Islam's message of "Thu, 26 Aug 2010 13:58:54 +0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Noorul Islam <noorul@noorul.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>

Hi Noorul,

Can I ask what error the directory deletion is causing for you?

I have the following delete-directory in my Emacs (latest from Git)

,----[delete-directory]
| delete-directory is an interactive compiled Lisp function in
| `files.el'.
| 
| (delete-directory DIRECTORY &optional RECURSIVE TRASH)
| 
| Delete the directory named DIRECTORY.  Does not follow symlinks.
| If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
| TRASH non-nil means to trash the directory instead, provided
| `delete-by-moving-to-trash' is non-nil.
| 
| When called interactively, TRASH is t if no prefix argument is
| given.  With a prefix argument, TRASH is nil.
| 
| [back]
`----

The second argument to `delete-directory' ensures that subdirectories
are recursively deleted.  Are you using a different version of Emacs
(maybe XEmacs?) in which `delete-directory' accepts a different number
of arguments?

Thanks -- Eric

Noorul Islam <noorul@noorul.com> writes:

> Latest pull is throwing error while quitting emacs.
>
> Here is the patch to fix this.
>
> ob.el:  Fix minor bug
>
> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
> arguments to (delete-directory)
>
> Thanks and Regards
> Noorul
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 33dbfef..32e2a54 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
>  (defun org-babel-remove-temporary-directory ()
>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
>    (when (boundp 'org-babel-temporary-directory)
> -    (delete-directory org-babel-temporary-directory t)))
> +    (delete-directory org-babel-temporary-directory)))
>  
>  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
>  
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode