From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric Schulte" Subject: Re: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Date: Fri, 27 Aug 2010 09:45:47 -0600 Message-ID: <87lj7svz2s.fsf@gmail.com> References: <87eidl1sgt.fsf@gmail.com> <20100826153138.3c50a001@gaia.hsu-hh.de> <4C77DA27.4040902@ccbr.umn.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=47440 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Op1Ic-0002JH-WD for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 11:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Op17y-0007Pb-21 for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 11:48:23 -0400 Received: from mail-yw0-f41.google.com ([209.85.213.41]:53943) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Op17x-0007PS-Sl for emacs-orgmode@gnu.org; Fri, 27 Aug 2010 11:46:02 -0400 Received: by ywo7 with SMTP id 7so1637851ywo.0 for ; Fri, 27 Aug 2010 08:46:01 -0700 (PDT) In-Reply-To: <4C77DA27.4040902@ccbr.umn.edu> (Erik Iverson's message of "Fri, 27 Aug 2010 10:30:47 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Erik Iverson Cc: Detlef Steuer , emacs-orgmode@gnu.org Fixed, Thanks -- Eric Erik Iverson writes: > Hello, > > It looks like the delete-directory bug was fixed, but > on emacs 23.2 at least, (delete-file) only takes one > argument, so org-babel-remove-temporary-directory is still > throwing an error in my case, since we have: > > (delete-file file nil) > > --Erik > > > > Detlef Steuer wrote: >> Hi Eric, >> >> I have to confirm that bug. >> Org-mode as of today, emacs 23.1.1. >> >> Here is, what my *MESSAGES* buffer tells: >> CONTENTS...done >> (No files need saving) >> org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2 >> When done with a buffer, type C-x # >> Auto-saving...done >> >> >> Ciao >> Detlef >> >> On Thu, 26 Aug 2010 06:14:26 -0600 >> "Eric Schulte" wrote: >> >>> Hi Noorul, >>> >>> Can I ask what error the directory deletion is causing for you? >>> >>> I have the following delete-directory in my Emacs (latest from Git) >>> >>> ,----[delete-directory] >>> | delete-directory is an interactive compiled Lisp function in >>> | `files.el'. >>> | | (delete-directory DIRECTORY &optional RECURSIVE TRASH) >>> | | Delete the directory named DIRECTORY. Does not follow >>> symlinks. >>> | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well. >>> | TRASH non-nil means to trash the directory instead, provided >>> | `delete-by-moving-to-trash' is non-nil. >>> | | When called interactively, TRASH is t if no prefix argument is >>> | given. With a prefix argument, TRASH is nil. >>> | | [back] >>> `---- >>> >>> The second argument to `delete-directory' ensures that subdirectories >>> are recursively deleted. Are you using a different version of Emacs >>> (maybe XEmacs?) in which `delete-directory' accepts a different number >>> of arguments? >>> >>> Thanks -- Eric >>> >>> Noorul Islam writes: >>> >>>> Latest pull is throwing error while quitting emacs. >>>> >>>> Here is the patch to fix this. >>>> >>>> ob.el: Fix minor bug >>>> >>>> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of >>>> arguments to (delete-directory) >>>> >>>> Thanks and Regards >>>> Noorul >>>> >>>> diff --git a/lisp/ob.el b/lisp/ob.el >>>> index 33dbfef..32e2a54 100644 >>>> --- a/lisp/ob.el >>>> +++ b/lisp/ob.el >>>> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'." >>>> (defun org-babel-remove-temporary-directory () >>>> "Remove `org-babel-temporary-directory' on Emacs shutdown." >>>> (when (boundp 'org-babel-temporary-directory) >>>> - (delete-directory org-babel-temporary-directory t))) >>>> + (delete-directory org-babel-temporary-directory))) >>>> (add-hook 'kill-emacs-hook >>>> org-babel-remove-temporary-directory) >>>> _______________________________________________ >>>> Emacs-orgmode mailing list >>>> Please use `Reply All' to send replies to the list. >>>> Emacs-orgmode@gnu.org >>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Please use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >>> >> >> >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode