Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)

From: "Eric Schulte" <schulte.eric@gmail.com>
To: Noorul Islam <noorul@noorul.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory)
Date: Thu, 26 Aug 2010 06:14:26 -0600	[thread overview]
Message-ID: <87eidl1sgt.fsf@gmail.com> (raw)
In-Reply-To: <AANLkTinubLMMwFa8K1sN=J8YGeoXAhZ-6zTXKxAvQzOO@mail.gmail.com> (Noorul Islam's message of "Thu, 26 Aug 2010 13:58:54 +0530")

Hi Noorul,

Can I ask what error the directory deletion is causing for you?

I have the following delete-directory in my Emacs (latest from Git)

,----[delete-directory]
| delete-directory is an interactive compiled Lisp function in
| `files.el'.
| 
| (delete-directory DIRECTORY &optional RECURSIVE TRASH)
| 
| Delete the directory named DIRECTORY.  Does not follow symlinks.
| If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well.
| TRASH non-nil means to trash the directory instead, provided
| `delete-by-moving-to-trash' is non-nil.
| 
| When called interactively, TRASH is t if no prefix argument is
| given.  With a prefix argument, TRASH is nil.
| 
| [back]
`----

The second argument to `delete-directory' ensures that subdirectories
are recursively deleted.  Are you using a different version of Emacs
(maybe XEmacs?) in which `delete-directory' accepts a different number
of arguments?

Thanks -- Eric

Noorul Islam <noorul@noorul.com> writes:

> Latest pull is throwing error while quitting emacs.
>
> Here is the patch to fix this.
>
> ob.el:  Fix minor bug
>
> * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of
> arguments to (delete-directory)
>
> Thanks and Regards
> Noorul
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 33dbfef..32e2a54 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'."
>  (defun org-babel-remove-temporary-directory ()
>    "Remove `org-babel-temporary-directory' on Emacs shutdown."
>    (when (boundp 'org-babel-temporary-directory)
> -    (delete-directory org-babel-temporary-directory t)))
> +    (delete-directory org-babel-temporary-directory)))
>  
>  (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory)
>  
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode