From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlef Steuer Subject: Re: [PATCH] Latest git pull has bug in (org-babel-remove-temporary-directory) Date: Thu, 26 Aug 2010 15:31:38 +0200 Message-ID: <20100826153138.3c50a001@gaia.hsu-hh.de> References: <87eidl1sgt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=57840 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OocYd-0001ZK-9G for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 09:31:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OocYc-0004EH-2J for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 09:31:55 -0400 Received: from lo.gmane.org ([80.91.229.12]:49158) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OocYb-0004Dn-HK for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 09:31:54 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OocYW-0003YJ-Rx for emacs-orgmode@gnu.org; Thu, 26 Aug 2010 15:31:48 +0200 Received: from gaia.unibw-hamburg.de ([139.11.181.103]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Aug 2010 15:31:48 +0200 Received: from detlef.steuer by gaia.unibw-hamburg.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 26 Aug 2010 15:31:48 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Eric, I have to confirm that bug. Org-mode as of today, emacs 23.1.1. Here is, what my *MESSAGES* buffer tells: CONTENTS...done (No files need saving) org-babel-remove-temporary-directory: Wrong number of arguments: delete-directory, 2 When done with a buffer, type C-x # Auto-saving...done Ciao Detlef On Thu, 26 Aug 2010 06:14:26 -0600 "Eric Schulte" wrote: > Hi Noorul, > > Can I ask what error the directory deletion is causing for you? > > I have the following delete-directory in my Emacs (latest from Git) > > ,----[delete-directory] > | delete-directory is an interactive compiled Lisp function in > | `files.el'. > | > | (delete-directory DIRECTORY &optional RECURSIVE TRASH) > | > | Delete the directory named DIRECTORY. Does not follow symlinks. > | If RECURSIVE is non-nil, all files in DIRECTORY are deleted as well. > | TRASH non-nil means to trash the directory instead, provided > | `delete-by-moving-to-trash' is non-nil. > | > | When called interactively, TRASH is t if no prefix argument is > | given. With a prefix argument, TRASH is nil. > | > | [back] > `---- > > The second argument to `delete-directory' ensures that subdirectories > are recursively deleted. Are you using a different version of Emacs > (maybe XEmacs?) in which `delete-directory' accepts a different number > of arguments? > > Thanks -- Eric > > Noorul Islam writes: > > > Latest pull is throwing error while quitting emacs. > > > > Here is the patch to fix this. > > > > ob.el: Fix minor bug > > > > * lisp/ob.el (org-babel-remove-temporary-directory) : Pass correct number of > > arguments to (delete-directory) > > > > Thanks and Regards > > Noorul > > > > diff --git a/lisp/ob.el b/lisp/ob.el > > index 33dbfef..32e2a54 100644 > > --- a/lisp/ob.el > > +++ b/lisp/ob.el > > @@ -1679,7 +1679,7 @@ of `org-babel-temporary-directory'." > > (defun org-babel-remove-temporary-directory () > > "Remove `org-babel-temporary-directory' on Emacs shutdown." > > (when (boundp 'org-babel-temporary-directory) > > - (delete-directory org-babel-temporary-directory t))) > > + (delete-directory org-babel-temporary-directory))) > > > > (add-hook 'kill-emacs-hook 'org-babel-remove-temporary-directory) > > > > _______________________________________________ > > Emacs-orgmode mailing list > > Please use `Reply All' to send replies to the list. > > Emacs-orgmode@gnu.org > > http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode >