From: Michael Brand <michael.ch.brand@gmail.com>
To: Org Mode <emacs-orgmode@gnu.org>, Paul Sexton <psexton.2a@gmail.com>
Subject: Re: org-player and switch to lexical binding in org.el
Date: Wed, 3 Feb 2016 21:41:32 +0100 [thread overview]
Message-ID: <CALn3zojUSVGLkpUxLBQmCwv71r_+7jd+ui09zcdWEjFffZVpvQ@mail.gmail.com> (raw)
In-Reply-To: <87k2mlaebu.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
Hi Nicolas and Paul
On Wed, Feb 3, 2016 at 6:33 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> I replaced S-expressions with functions of two arguments. The Org world
> is a better place with one less `eval'.
Just to confirm: Updating org-player.el to 1.0.1 makes Org links to
media files play again. Thank you both for your changes.
I made some thoughts about the user experience of this incompatible
change:
Following such an Org link after updating Org without taking too much
care of `org-file-apps' or as a new Org user silently falls back to
open the file e. g. directly in an Emacs buffer just as with a default
`org-file-apps'. In this situation a user may well not be aware of
that `org-file-apps' has fallen short of an application registered
there. Or, even if I read the Org News I might not be aware of all the
additions to `org-file-apps' I got under the hood. Or the user does
not read the Org News or does not understand the consequences to its
very end.
For all this I suggest a simple migration hint like the error in my
attached patch. Did I miss its disadvantage?
Michael
[-- Attachment #2: 0001-org-file-apps-add-migration-hint.patch --]
[-- Type: application/octet-stream, Size: 859 bytes --]
From b3c3cd9f07e2009068bf5952963d98924b5e4d17 Mon Sep 17 00:00:00 2001
From: Michael Brand <michael.brand@alumni.ethz.ch>
Date: Wed, 3 Feb 2016 21:37:09 +0100
Subject: [PATCH] `org-file-apps' add migration hint
* lisp/org.el (org-file-apps): Add an error when still a sexp is in
use.
---
lisp/org.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/org.el b/lisp/org.el
index c93e4e1..c2f945f 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11326,6 +11326,8 @@ If the file does not exist, an error is thrown."
(save-match-data
(set-match-data link-match-data)
(funcall cmd file link)))
+ ((consp cmd)
+ (error "Please see Org News for Version 9.0 about `org-file-apps'"))
(t (funcall (cdr (assq 'file org-link-frame-setup)) file)))
(and (derived-mode-p 'org-mode)
(eq old-mode 'org-mode)
--
2.4.9 (Apple Git-60)
next prev parent reply other threads:[~2016-02-03 20:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 18:58 org-player and switch to lexical binding in org.el Michael Brand
2016-01-17 20:40 ` Nicolas Goaziou
2016-01-17 21:02 ` Michael Brand
2016-01-17 21:05 ` Michael Brand
[not found] ` <CAK5Vzd2aV7WGGVr=+VF-LCCDCOZXJzUYEnCgbuzgGea4i5BR7Q@mail.gmail.com>
2016-02-07 11:49 ` Michael Brand
2016-01-28 11:37 ` Michael Brand
2016-01-29 13:32 ` Nicolas Goaziou
2016-01-29 20:39 ` Michael Brand
2016-01-30 23:30 ` Nicolas Goaziou
2016-02-01 7:57 ` Michael Brand
2016-02-03 17:33 ` Nicolas Goaziou
2016-02-03 20:41 ` Michael Brand [this message]
2016-02-03 20:56 ` Nicolas Goaziou
2016-02-03 22:02 ` Michael Brand
2016-02-04 8:36 ` Nicolas Goaziou
2016-02-04 11:44 ` Michael Brand
2016-02-04 12:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zojUSVGLkpUxLBQmCwv71r_+7jd+ui09zcdWEjFffZVpvQ@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=psexton.2a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).