emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michael Brand <michael.ch.brand@gmail.com>
To: Paul Sexton <psexton.2a@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: org-player and switch to lexical binding in org.el
Date: Sun, 7 Feb 2016 12:49:11 +0100	[thread overview]
Message-ID: <CALn3zog3=EnsZvPDrYeASb+VwaxK298wuD+t8VjEVuKOQAHrDg@mail.gmail.com> (raw)
In-Reply-To: <CAK5Vzd2aV7WGGVr=+VF-LCCDCOZXJzUYEnCgbuzgGea4i5BR7Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi Paul

On Thu, Jan 28, 2016 at 4:00 AM, Paul Sexton <psexton.2a@gmail.com> wrote:

> Hi, I have just pushed the suggested change to the org-player repository on
> bitbucket. Please let me know if it has fixed the problem.

org-player.el 1.0.1 plays again for links with a position. For links
without position there is a change missing, see my attached patch as a
suggestion.

Michael

[-- Attachment #2: org-player.el.patch --]
[-- Type: text/x-patch, Size: 710 bytes --]

--- org-player.1.0.1.el	2016-01-29 21:32:18.000000000 +0100
+++ org-player.1.0.2.el	2016-02-06 09:27:14.000000000 +0100
@@ -2,7 +2,7 @@
 ;;; org-player.el - Play audio and video files in org-mode hyperlinks
 ;;;
 ;;; Author: Paul Sexton <eeeickythump@gmail.com>
-;;; Version: 1.0.1
+;;; Version: 1.0.2
 ;;; Repository at http://bitbucket.org/eeeickythump/org-player/
 ;;;
 ;;;
@@ -102,7 +102,7 @@
 
 (add-to-list 'org-file-apps
              (cons (concat org-player-file-extensions-regexp "$")
-                   '(org-player-play-file file)))
+                   (lambda (file link) (org-player-play-file file))))
 
 (add-to-list 'org-file-apps
              (cons (concat org-player-file-extensions-regexp

  parent reply	other threads:[~2016-02-07 11:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 18:58 org-player and switch to lexical binding in org.el Michael Brand
2016-01-17 20:40 ` Nicolas Goaziou
2016-01-17 21:02   ` Michael Brand
2016-01-17 21:05   ` Michael Brand
     [not found]     ` <CAK5Vzd2aV7WGGVr=+VF-LCCDCOZXJzUYEnCgbuzgGea4i5BR7Q@mail.gmail.com>
2016-02-07 11:49       ` Michael Brand [this message]
2016-01-28 11:37   ` Michael Brand
2016-01-29 13:32     ` Nicolas Goaziou
2016-01-29 20:39       ` Michael Brand
2016-01-30 23:30         ` Nicolas Goaziou
2016-02-01  7:57           ` Michael Brand
2016-02-03 17:33             ` Nicolas Goaziou
2016-02-03 20:41               ` Michael Brand
2016-02-03 20:56                 ` Nicolas Goaziou
2016-02-03 22:02                   ` Michael Brand
2016-02-04  8:36                     ` Nicolas Goaziou
2016-02-04 11:44                       ` Michael Brand
2016-02-04 12:46                         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALn3zog3=EnsZvPDrYeASb+VwaxK298wuD+t8VjEVuKOQAHrDg@mail.gmail.com' \
    --to=michael.ch.brand@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=psexton.2a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).