From: Michael Brand <michael.ch.brand@gmail.com>
To: Paul Sexton <psexton@xnet.co.nz>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: org-player and switch to lexical binding in org.el
Date: Sun, 17 Jan 2016 22:02:42 +0100 [thread overview]
Message-ID: <CALn3zoih3BabFs97ZaO-e5Z45gXOZb9mGJ1ebtmi2vSBgoYegQ@mail.gmail.com> (raw)
In-Reply-To: <877fj8j5wx.fsf@nicolasgoaziou.fr>
Hi Paul
It seems that this is beyond of my knowledge and I would like to ask
you as the author of org-player for help.
On Sun, Jan 17, 2016 at 9:40 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Michael Brand <michael.ch.brand@gmail.com> writes:
>
>> release_8.3.3-426-g1f49e9f introduces a regression. The link
>>
>> [[file:/dir/audio.mp3::0:12:34]]
>>
>> results in
>>
>> Debugger entered--Lisp error: (void-variable search)
>> (org-player-play-file file search)
>> [...]
>> org-open-file("/dir/audio.mp3" nil nil "0:12:34")
>> [...]
>
> `search' never was advertised as a dynamically scoped variable in
> `org-file-apps' docstring, so "org-player" is just playing with fire
> here.
>
> I don't like the current solution either (eval with a LEXICAL argument).
>
> I think it would be better to use un function with two arguments (file
> and link-string instead). This is not backward compatible, but the
> change is trivial: sexp -> (lambda (file link) sexp).
>
> In the current case, you need to use match string:
>
> (add-to-list 'org-file-apps
> (cons (concat org-player-file-extensions-regexp
> "::\\([0-9]+:[0-9]+\\(:[0-9]+\\)?\\)")
> (lambda (file link)
> (org-player-play-file file (match-string 1 link)))))
>
> WDYT?
>
>
> Regards,
>
> --
> Nicolas Goaziou
Michael
next prev parent reply other threads:[~2016-01-17 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 18:58 org-player and switch to lexical binding in org.el Michael Brand
2016-01-17 20:40 ` Nicolas Goaziou
2016-01-17 21:02 ` Michael Brand [this message]
2016-01-17 21:05 ` Michael Brand
[not found] ` <CAK5Vzd2aV7WGGVr=+VF-LCCDCOZXJzUYEnCgbuzgGea4i5BR7Q@mail.gmail.com>
2016-02-07 11:49 ` Michael Brand
2016-01-28 11:37 ` Michael Brand
2016-01-29 13:32 ` Nicolas Goaziou
2016-01-29 20:39 ` Michael Brand
2016-01-30 23:30 ` Nicolas Goaziou
2016-02-01 7:57 ` Michael Brand
2016-02-03 17:33 ` Nicolas Goaziou
2016-02-03 20:41 ` Michael Brand
2016-02-03 20:56 ` Nicolas Goaziou
2016-02-03 22:02 ` Michael Brand
2016-02-04 8:36 ` Nicolas Goaziou
2016-02-04 11:44 ` Michael Brand
2016-02-04 12:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn3zoih3BabFs97ZaO-e5Z45gXOZb9mGJ1ebtmi2vSBgoYegQ@mail.gmail.com \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=psexton@xnet.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).