From: Michael Brand <michael.ch.brand@gmail.com>
To: Org Mode <emacs-orgmode@gnu.org>
Cc: Paul Sexton <psexton.2a@gmail.com>
Subject: Re: org-player and switch to lexical binding in org.el
Date: Wed, 3 Feb 2016 23:02:55 +0100 [thread overview]
Message-ID: <CALn3zoj9KKUbdzK+ieXWPz0=gS-=cKmfeTBAn4COMdVwiCeWrw@mail.gmail.com> (raw)
In-Reply-To: <87d1sda4y5.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hi Nicolas
On Wed, Feb 3, 2016 at 9:56 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> I have no objection, but I suggest to add a big fat FIXME above so as to
> remove it once we release Org 9.1.
I would prefer to keep it much longer for those who do not regularly
update Org. The many cases when Org 9.0 is not part of the update
path. E. g. when a distro will include Emacs 25.1 with Org 8.3.3 (?)
in some time and a user will start with Org of this distro when it has
already some age and again some time later he will update to Org from
master and a compatible Emacs. I guess that more than a few distros
will skip Org 9.0 and more than a few distro users will also skip some
update steps of their distro.
> Also, it should be `user-error', not `error'.
Intermediate patch version attached.
Michael
[-- Attachment #2: 0001-org-file-apps-add-migration-hint.patch --]
[-- Type: application/octet-stream, Size: 1051 bytes --]
From 5242d8d0008468f6581b40ae7dda3d5e535c312c Mon Sep 17 00:00:00 2001
From: Michael Brand <michael.brand@alumni.ethz.ch>
Date: Wed, 3 Feb 2016 22:46:43 +0100
Subject: [PATCH] `org-file-apps' add migration hint
* lisp/org.el (org-file-apps): Add an error when still a sexp is in
use.
---
lisp/org.el | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lisp/org.el b/lisp/org.el
index c93e4e1..b629b2d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11326,6 +11326,12 @@ If the file does not exist, an error is thrown."
(save-match-data
(set-match-data link-match-data)
(funcall cmd file link)))
+ ((consp cmd)
+ ;; Heads-up instead of silently fall back to
+ ;; `org-link-frame-setup' for an old usage of `org-file-apps'
+ ;; with sexp instead of a function for `cmd'.
+ (user-error
+ "Please see Org News for Version 9.0 about `org-file-apps'"))
(t (funcall (cdr (assq 'file org-link-frame-setup)) file)))
(and (derived-mode-p 'org-mode)
(eq old-mode 'org-mode)
--
2.4.9 (Apple Git-60)
next prev parent reply other threads:[~2016-02-03 22:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 18:58 org-player and switch to lexical binding in org.el Michael Brand
2016-01-17 20:40 ` Nicolas Goaziou
2016-01-17 21:02 ` Michael Brand
2016-01-17 21:05 ` Michael Brand
[not found] ` <CAK5Vzd2aV7WGGVr=+VF-LCCDCOZXJzUYEnCgbuzgGea4i5BR7Q@mail.gmail.com>
2016-02-07 11:49 ` Michael Brand
2016-01-28 11:37 ` Michael Brand
2016-01-29 13:32 ` Nicolas Goaziou
2016-01-29 20:39 ` Michael Brand
2016-01-30 23:30 ` Nicolas Goaziou
2016-02-01 7:57 ` Michael Brand
2016-02-03 17:33 ` Nicolas Goaziou
2016-02-03 20:41 ` Michael Brand
2016-02-03 20:56 ` Nicolas Goaziou
2016-02-03 22:02 ` Michael Brand [this message]
2016-02-04 8:36 ` Nicolas Goaziou
2016-02-04 11:44 ` Michael Brand
2016-02-04 12:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALn3zoj9KKUbdzK+ieXWPz0=gS-=cKmfeTBAn4COMdVwiCeWrw@mail.gmail.com' \
--to=michael.ch.brand@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=psexton.2a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).