From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: org-player and switch to lexical binding in org.el Date: Wed, 3 Feb 2016 21:41:32 +0100 Message-ID: References: <877fj8j5wx.fsf@nicolasgoaziou.fr> <87oac4a4v2.fsf@nicolasgoaziou.fr> <877fiqhcgw.fsf@nicolasgoaziou.fr> <87k2mlaebu.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b5d649aad488d052ae3a4e0 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR4F4-00070l-Da for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 15:41:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aR4F3-0007dy-GP for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 15:41:34 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:37128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aR4F3-0007dW-8l for emacs-orgmode@gnu.org; Wed, 03 Feb 2016 15:41:33 -0500 Received: by mail-wm0-x22b.google.com with SMTP id l66so88511917wml.0 for ; Wed, 03 Feb 2016 12:41:32 -0800 (PST) In-Reply-To: <87k2mlaebu.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode , Paul Sexton --047d7b5d649aad488d052ae3a4e0 Content-Type: text/plain; charset=UTF-8 Hi Nicolas and Paul On Wed, Feb 3, 2016 at 6:33 PM, Nicolas Goaziou wrote: > I replaced S-expressions with functions of two arguments. The Org world > is a better place with one less `eval'. Just to confirm: Updating org-player.el to 1.0.1 makes Org links to media files play again. Thank you both for your changes. I made some thoughts about the user experience of this incompatible change: Following such an Org link after updating Org without taking too much care of `org-file-apps' or as a new Org user silently falls back to open the file e. g. directly in an Emacs buffer just as with a default `org-file-apps'. In this situation a user may well not be aware of that `org-file-apps' has fallen short of an application registered there. Or, even if I read the Org News I might not be aware of all the additions to `org-file-apps' I got under the hood. Or the user does not read the Org News or does not understand the consequences to its very end. For all this I suggest a simple migration hint like the error in my attached patch. Did I miss its disadvantage? Michael --047d7b5d649aad488d052ae3a4e0 Content-Type: application/octet-stream; name="0001-org-file-apps-add-migration-hint.patch" Content-Disposition: attachment; filename="0001-org-file-apps-add-migration-hint.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ik7aqpml0 RnJvbSBiM2MzY2Q5ZjA3ZTIwMDkwNjhiZjU5NTI5NjNkOTg5MjRiNWU0ZDE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJyYW5kIDxtaWNoYWVsLmJyYW5kQGFsdW1uaS5l dGh6LmNoPgpEYXRlOiBXZWQsIDMgRmViIDIwMTYgMjE6Mzc6MDkgKzAxMDAKU3ViamVjdDogW1BB VENIXSBgb3JnLWZpbGUtYXBwcycgYWRkIG1pZ3JhdGlvbiBoaW50CgoqIGxpc3Avb3JnLmVsIChv cmctZmlsZS1hcHBzKTogQWRkIGFuIGVycm9yIHdoZW4gc3RpbGwgYSBzZXhwIGlzIGluCnVzZS4K LS0tCiBsaXNwL29yZy5lbCB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9saXNwL29yZy5lbCBiL2xpc3Avb3JnLmVsCmluZGV4IGM5M2U0ZTEuLmMy Zjk0NWYgMTAwNjQ0Ci0tLSBhL2xpc3Avb3JnLmVsCisrKyBiL2xpc3Avb3JnLmVsCkBAIC0xMTMy Niw2ICsxMTMyNiw4IEBAIElmIHRoZSBmaWxlIGRvZXMgbm90IGV4aXN0LCBhbiBlcnJvciBpcyB0 aHJvd24uIgogICAgICAgKHNhdmUtbWF0Y2gtZGF0YQogCShzZXQtbWF0Y2gtZGF0YSBsaW5rLW1h dGNoLWRhdGEpCiAJKGZ1bmNhbGwgY21kIGZpbGUgbGluaykpKQorICAgICAoKGNvbnNwIGNtZCkK KyAgICAgIChlcnJvciAiUGxlYXNlIHNlZSBPcmcgTmV3cyBmb3IgVmVyc2lvbiA5LjAgYWJvdXQg YG9yZy1maWxlLWFwcHMnIikpCiAgICAgICh0IChmdW5jYWxsIChjZHIgKGFzc3EgJ2ZpbGUgb3Jn LWxpbmstZnJhbWUtc2V0dXApKSBmaWxlKSkpCiAgICAgKGFuZCAoZGVyaXZlZC1tb2RlLXAgJ29y Zy1tb2RlKQogCSAoZXEgb2xkLW1vZGUgJ29yZy1tb2RlKQotLSAKMi40LjkgKEFwcGxlIEdpdC02 MCkKCg== --047d7b5d649aad488d052ae3a4e0--