ATTENTION: Incompatible change

ATTENTION: Incompatible change

[Carsten Dominik]

Hi all,

I have now replaced both org-mac-message.el and org-mac-link-grabber.el with org-mac-link.el.  So after the next pull, you will have to change your setup to use this module instead of the others and use the new commands as well.  I would appreciate if you your try this soon, so that we can fix issue before the next release (very soon).

Thank you, and in particular thanks to Anthony Lander for doing the work.

- Carsten

P.S. Anthony, you promised to update the documentation.  It would be great if you could do that now.

Thank you!

Re: ATTENTION: Incompatible change

[Anthony Lander]

[-- Attachment #1.1: Type: text/plain, Size: 979 bytes --]

Hi Carsten,

Sorry for the delay. For org-mac-link, here is a small cleanup patch to org
that changes the customize group name from 'org-mac-link-grabber to
'org-mac-link, and another patch which updates the documentation in worg.
Can you please review, and if OK apply to the repositories?

Thanks,

  -Anthony



On Sat, Aug 31, 2013 at 9:37 AM, Carsten Dominik
<carsten.dominik@gmail.com>wrote:

> Hi all,
>
> I have now replaced both org-mac-message.el and org-mac-link-grabber.el
> with org-mac-link.el.  So after the next pull, you will have to change your
> setup to use this module instead of the others and use the new commands as
> well.  I would appreciate if you your try this soon, so that we can fix
> issue before the next release (very soon).
>
> Thank you, and in particular thanks to Anthony Lander for doing the work.
>
> - Carsten
>
> P.S. Anthony, you promised to update the documentation.  It would be great
> if you could do that now.
>
> Thank you!
>
>
>

[-- Attachment #1.2: Type: text/html, Size: 1480 bytes --]

[-- Attachment #2: org-mac-link-worg-patch.txt --]
[-- Type: text/plain, Size: 3208 bytes --]

diff --git a/org-contrib/org-mac-link.org b/org-contrib/org-mac-link.org
index 3f58616..1cc0f21 100644
--- a/org-contrib/org-mac-link.org
+++ b/org-contrib/org-mac-link.org
@@ -1,4 +1,4 @@
-#+TITLE:     org-mac-link-grabber.el -- Grab links from open Mac applications
+#+TITLE:     org-mac-link.el -- Grab links from open Mac applications
 #+OPTIONS:   ^:{} author:nil
 #+STARTUP: odd
 
@@ -17,7 +17,7 @@
 	- Mail.app
 	- Address Book.app
 	- Safari.app
-        - Skim.app [fn:: Supported in the latest version from Git]
+    - Skim.app [fn:: Supported in the latest version from Git]
 	- Firefox.app
 	- Firefox.app with the Vimperator plugin
 	- Google Chrome.app
@@ -26,26 +26,26 @@
 * Installation
   
   Customize the org group by typing =M-x customize-group RET org RET=, then
-  expand the /Modules/ section, and enable =mac-link-grabber=.
+  expand the /Modules/ section, and enable =mac-link=.
 
   You may also optionally bind a key to activate the link grabber menu, like
   this:
 
   : (add-hook 'org-mode-hook (lambda () 
-  :   (define-key org-mode-map (kbd "C-c g") 'omlg-grab-link)))
+  :   (define-key org-mode-map (kbd "C-c g") 'org-mac-grab-link)))
 
-* Usage 
+* Usage
 
-  Activate the grabber by typing =C-c g= (or whatever key you decided
-  to bind, as above), or type =M-x omlg-grab-link RET=. This will give
-  you a menu in the modeline allowing you to select an application.
-  The current selection in that application will be inserted at point
-  as a hyperlink in your org-mode document.
+  Activate the grabber by typing =C-c g= (or whatever key you decided to bind,
+  as above), or type =M-x org-mac-grab-link RET=. This will give you a menu in
+  the modeline allowing you to select an application. The current selection in
+  that application will be inserted at point as a hyperlink in your org-mode
+  document.
 
 * Customizing
 
-  You may customize which applications appear in the grab menu by
-  customizing the group /org-mac-link-grabber/. Changes take effect
-  immediately. If you are using the latest org-mode from Git, you can
-  also customize whether the =org-mac-link-grabber= should highlight
-  the selected text when grabbing the link from Skim.app.
+  You may customize which applications appear in the grab menu by customizing
+  the group /org-mac-link/. Changes take effect immediately. If you are using
+  the latest org-mode from Git, you can also customize whether the
+  =org-mac-link= should highlight the selected text when grabbing the link from
+  Skim.app.
diff --git a/org-mac.org b/org-mac.org
index 074a85e..2015e02 100644
--- a/org-mac.org
+++ b/org-mac.org
@@ -28,7 +28,7 @@ applications other than Emacs...
 ** [[file:org-contrib/org-mac-iCal.org][org-mac-iCal]] -- import OS X iCal.app events into Emacs diary
    Written by /Christopher Suckling/.
 
-** [[file:org-contrib/org-mac-link-grabber.org][org-mac-link-grabber]] -- Hyperlink to items in mac applications
+** [[file:org-contrib/org-mac-link.org][org-mac-link]] -- Hyperlink to items in mac applications
    grab the current link or selection from an open mac application and
    insert it as a hyperlink at point in an org-mode document. Written
    by /Anthony Lander/.

[-- Attachment #3: org-mac-link-patch.txt --]
[-- Type: text/plain, Size: 2956 bytes --]

diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index 8993919..0ab0354 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -81,58 +81,58 @@
 (require 'org)
 (require 'org-mac-message)
 
-(defgroup org-mac-link-grabber nil
+(defgroup org-mac-link nil
   "Options concerning grabbing links from external Mac
 applications and inserting them in org documents"
-  :tag "Org Mac link grabber"
+  :tag "Org Mac link"
   :group 'org-link)
 
 (defcustom org-mac-grab-Finder-app-p t
   "Enable menu option [F]inder to grab links from the Finder"
   :tag "Grab Finder.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Mail-app-p t
   "Enable menu option [m]ail to grab links from Mail.app"
   :tag "Grab Mail.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Addressbook-app-p t
   "Enable menu option [a]ddressbook to grab links from AddressBook.app"
   :tag "Grab AddressBook.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Safari-app-p t
   "Enable menu option [s]afari to grab links from Safari.app"
   :tag "Grab Safari.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Firefox-app-p t
   "Enable menu option [f]irefox to grab links from Firefox.app"
   :tag "Grab Firefox.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Firefox+Vimperator-p nil
   "Enable menu option [v]imperator to grab links from Firefox.app running the Vimperator plugin"
   :tag "Grab Vimperator/Firefox.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Chrome-app-p t
   "Enable menu option [f]irefox to grab links from Google Chrome.app"
   :tag "Grab Google Chrome.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Together-app-p nil
   "Enable menu option [t]ogether to grab links from Together.app"
   :tag "Grab Together.app links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-grab-Skim-app-p
@@ -140,13 +140,13 @@ applications and inserting them in org documents"
                 "mdfind kMDItemCFBundleIdentifier == 'net.sourceforge.skim-app.skim'")))
   "Enable menu option [S]kim to grab page links from Skim.app"
   :tag "Grab Skim.app page links"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defcustom org-mac-Skim-highlight-selection-p nil
   "Highlight (using notes) the selection (if present) when grabbing the a link from Skim.app"
   :tag "Highlight selection in Skim.app"
-  :group 'org-mac-link-grabber
+  :group 'org-mac-link
   :type 'boolean)
 
 (defgroup org-mac-flagged-mail nil

Re: ATTENTION: Incompatible change

[Mike McLean]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Thank you for this. The combination and simplification is finally prompting
me to add support for Microsoft Outlook for Mac email messages and for
DevonThink Pro.

I have a question, though. If the only require now is supposed to be
=(require 'org-mac-link)=, why is there still a =(require
'org-mac-message)= in =org-mac-link.el=?

Mike

On Thursday, September 5, 2013, Anthony Lander wrote:

> Hi Carsten,
>
> Sorry for the delay. For org-mac-link, here is a small cleanup patch to
> org that changes the customize group name from 'org-mac-link-grabber to
> 'org-mac-link, and another patch which updates the documentation in worg.
> Can you please review, and if OK apply to the repositories?
>
> Thanks,
>
>   -Anthony
>
>
>
> On Sat, Aug 31, 2013 at 9:37 AM, Carsten Dominik <
> carsten.dominik@gmail.com <javascript:_e({}, 'cvml',
> 'carsten.dominik@gmail.com');>> wrote:
>
>> Hi all,
>>
>> I have now replaced both org-mac-message.el and org-mac-link-grabber.el
>> with org-mac-link.el.  So after the next pull, you will have to change your
>> setup to use this module instead of the others and use the new commands as
>> well.  I would appreciate if you your try this soon, so that we can fix
>> issue before the next release (very soon).
>>
>> Thank you, and in particular thanks to Anthony Lander for doing the work.
>>
>> - Carsten
>>
>> P.S. Anthony, you promised to update the documentation.  It would be
>> great if you could do that now.
>>
>> Thank you!
>>
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 2107 bytes --]

Re: ATTENTION: Incompatible change

[Carsten Dominik]

[-- Attachment #1.1: Type: text/plain, Size: 1584 bytes --]


On 6.9.2013, at 17:00, Mike McLean <mike.mclean@pobox.com> wrote:

> Thank you for this. The combination and simplification is finally prompting me to add support for Microsoft Outlook for Mac email messages and for DevonThink Pro.
> 
> I have a question, though. If the only require now is supposed to be =(require 'org-mac-link)=, why is there still a =(require 'org-mac-message)= in =org-mac-link.el=?

Hi Mike,

Thanks for picking this up - I fixed that.

- Carsten

> 
> Mike
> 
> On Thursday, September 5, 2013, Anthony Lander wrote:
> Hi Carsten,
> 
> Sorry for the delay. For org-mac-link, here is a small cleanup patch to org that changes the customize group name from 'org-mac-link-grabber to 'org-mac-link, and another patch which updates the documentation in worg. Can you please review, and if OK apply to the repositories?
> 
> Thanks,
> 
>   -Anthony
> 
> 
> 
> On Sat, Aug 31, 2013 at 9:37 AM, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> Hi all,
> 
> I have now replaced both org-mac-message.el and org-mac-link-grabber.el with org-mac-link.el.  So after the next pull, you will have to change your setup to use this module instead of the others and use the new commands as well.  I would appreciate if you your try this soon, so that we can fix issue before the next release (very soon).
> 
> Thank you, and in particular thanks to Anthony Lander for doing the work.
> 
> - Carsten
> 
> P.S. Anthony, you promised to update the documentation.  It would be great if you could do that now.
> 
> Thank you!
> 
> 
> 


[-- Attachment #1.2: Type: text/html, Size: 2776 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

Re: ATTENTION: Incompatible change

[Mike McLean]

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

Thank you.

I just submitted my patch to add support for Microsoft Outlook for Mac and
I will add support for DevonThink Pro (at least) sometime next week.

Mike



On Fri, Sep 6, 2013 at 12:38 PM, Carsten Dominik
<carsten.dominik@gmail.com>wrote:

>
> On 6.9.2013, at 17:00, Mike McLean <mike.mclean@pobox.com> wrote:
>
> Thank you for this. The combination and simplification is finally
> prompting me to add support for Microsoft Outlook for Mac email messages
> and for DevonThink Pro.
>
> I have a question, though. If the only require now is supposed to be
> =(require 'org-mac-link)=, why is there still a =(require
> 'org-mac-message)= in =org-mac-link.el=?
>
>
> Hi Mike,
>
> Thanks for picking this up - I fixed that.
>
> - Carsten
>
>
> Mike
>
> On Thursday, September 5, 2013, Anthony Lander wrote:
>
>> Hi Carsten,
>>
>> Sorry for the delay. For org-mac-link, here is a small cleanup patch to
>> org that changes the customize group name from 'org-mac-link-grabber to
>> 'org-mac-link, and another patch which updates the documentation in worg.
>> Can you please review, and if OK apply to the repositories?
>>
>> Thanks,
>>
>>   -Anthony
>>
>>
>>
>> On Sat, Aug 31, 2013 at 9:37 AM, Carsten Dominik <
>> carsten.dominik@gmail.com> wrote:
>>
>>> Hi all,
>>>
>>> I have now replaced both org-mac-message.el and org-mac-link-grabber.el
>>> with org-mac-link.el.  So after the next pull, you will have to change your
>>> setup to use this module instead of the others and use the new commands as
>>> well.  I would appreciate if you your try this soon, so that we can fix
>>> issue before the next release (very soon).
>>>
>>> Thank you, and in particular thanks to Anthony Lander for doing the work.
>>>
>>> - Carsten
>>>
>>> P.S. Anthony, you promised to update the documentation.  It would be
>>> great if you could do that now.
>>>
>>> Thank you!
>>>
>>>
>>>
>>
>

[-- Attachment #2: Type: text/html, Size: 3244 bytes --]