emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: stardiviner <numbchild@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [Feature] add a new org-attach dispatcher command to offline save web page
Date: Wed, 03 Jun 2020 17:10:58 +0200	[thread overview]
Message-ID: <87lfl4yykd.fsf@gnu.org> (raw)
In-Reply-To: <87eeqxbkf5.fsf@gmail.com> (stardiviner's message of "Tue, 02 Jun 2020 22:40:30 +0800")

Hi,

stardiviner <numbchild@gmail.com> writes:

> Here is my patch, I try to annotate on my patch code to express my
> words:

Thanks - I see what is hardcoded and why.

Since the whole idea is to use something else than url-copy-file for
downloading URLs I would rather add an option to allow using a custom
function.

Something like `org-attach-url-copy-file-function' which would be
url-copy-file by default but could be set to another function with 
the same signature.

Don't rush on implementing this though, I'd like to reread the code
in org-attach.el again to decide if this is the right way - and this
won't be before 9.5.

Best,

-- 
 Bastien


  reply	other threads:[~2020-06-03 15:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27  9:55 [Feature] add a new org-attach dispatcher command to offline save web page stardiviner
2020-05-28  2:55 ` Matthew Lundin
2020-05-28  5:49   ` Ihor Radchenko
2020-05-28  6:39     ` stardiviner
2020-05-28 14:03       ` Ihor Radchenko
2020-05-28 16:00         ` stardiviner
2020-05-28 18:16           ` Ihor Radchenko
2020-05-28 16:19     ` Matthew Lundin
2020-05-28 17:11       ` Ihor Radchenko
2020-05-28 22:15         ` Matthew Lundin
2020-05-29  2:15           ` stardiviner
2020-05-29  2:06         ` stardiviner
2020-05-29  2:03       ` stardiviner
2020-05-29  2:17         ` Ihor Radchenko
2020-05-29  6:16           ` stardiviner
2020-05-29 15:33           ` Matthew Lundin
2020-05-29 16:32             ` stardiviner
2020-05-30  6:09             ` Ihor Radchenko
2020-05-28  6:37   ` stardiviner
2020-05-28  6:40   ` stardiviner
2020-05-28 22:24 ` Samuel Wales
2020-05-29  2:23 ` [PATCH updated] " stardiviner
2020-05-29  2:27 ` stardiviner
2020-06-02 12:20   ` Bastien
2020-06-02 14:06     ` stardiviner
2020-06-02 14:26       ` Bastien
2020-06-02 14:40         ` stardiviner
2020-06-03 15:10           ` Bastien [this message]
2020-06-03 23:34             ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfl4yykd.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).