emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [babel] BUG in :session
@ 2011-09-21 11:19 Rainer M Krug
  2011-09-21 12:57 ` Eric Schulte
  0 siblings, 1 reply; 21+ messages in thread
From: Rainer M Krug @ 2011-09-21 11:19 UTC (permalink / raw)
  To: emacs-orgmode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Org-mode version 7.7 (release_7.7.311.g0c099)

If execute (Ctrl-c) the code below

* load data
 #+begin_src R :tangle no :export results :session R
   paste("Yep!")
 #+end_src

I get an error:

##########
executing R code block...
org-babel-R-evaluate: Wrong number of arguments: #[(session body
result-type result-params column-names-p row-names-p) "\bÆ=ƒ}
##########
only much longer and lots of strange characters.



* load data
#+begin_src R :tangle no :export results
  paste("Yep!")
#+end_src

#+results:
: Yep!

works as expected

So I assume there is a problem in the :session header argument.

Cheers,

Rainer


- --

Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation
Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk55yCoACgkQoYgNqgF2egp5rgCgiIz9xbFIlosMM2xxxXrIHMqm
UaIAn0cnq6Kegan/HxoSLLIHUBF03/hd
=yJ4c
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 11:19 [babel] BUG in :session Rainer M Krug
@ 2011-09-21 12:57 ` Eric Schulte
  2011-09-21 16:56   ` Martyn Jago
  2011-09-21 17:09   ` Rainer M Krug
  0 siblings, 2 replies; 21+ messages in thread
From: Eric Schulte @ 2011-09-21 12:57 UTC (permalink / raw)
  To: Rainer M Krug; +Cc: emacs-orgmode

Hi Rainer,

Thanks for finding this bug, I introduced it in one of my recent
changes.  I've just pushed up a fix and a test case.

Best -- Eric

Rainer M Krug <r.m.krug@gmail.com> writes:

> Hi
>
> Org-mode version 7.7 (release_7.7.311.g0c099)
>
> If execute (Ctrl-c) the code below
>
> * load data
>  #+begin_src R :tangle no :export results :session R
>    paste("Yep!")
>  #+end_src
>
> I get an error:
>
> ##########
> executing R code block...
> org-babel-R-evaluate: Wrong number of arguments: #[(session body
> result-type result-params column-names-p row-names-p) "\bÆ=ƒ}
> ##########
> only much longer and lots of strange characters.
>
>
>
> * load data
> #+begin_src R :tangle no :export results
>   paste("Yep!")
> #+end_src
>
> #+results:
> : Yep!
>
> works as expected
>
> So I assume there is a problem in the :session header argument.
>
> Cheers,
>
> Rainer
>
>
> --
>
> Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation
> Biology, UCT), Dipl. Phys. (Germany)
>
> Centre of Excellence for Invasion Biology
> Stellenbosch University
> South Africa
>
> Tel :       +33 - (0)9 53 10 27 44
> Cell:       +33 - (0)6 85 62 59 98
> Fax :       +33 - (0)9 58 10 27 44
>
> Fax (D):    +49 - (0)3 21 21 25 22 44
>
> email:      Rainer@krugs.de
>
> Skype:      RMkrug

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 12:57 ` Eric Schulte
@ 2011-09-21 16:56   ` Martyn Jago
  2011-09-21 18:54     ` Sebastien Vauban
  2011-09-21 19:32     ` Eric Schulte
  2011-09-21 17:09   ` Rainer M Krug
  1 sibling, 2 replies; 21+ messages in thread
From: Martyn Jago @ 2011-09-21 16:56 UTC (permalink / raw)
  To: emacs-orgmode

Hi Eric

Eric Schulte <schulte.eric@gmail.com> writes:

> Hi Rainer,
>
> Thanks for finding this bug, I introduced it in one of my recent
> changes.  I've just pushed up a fix and a test case.
>
> Best -- Eric
>

Unfortunately this test introduces an external dependency for R (which I
haven't currently got on my system so fails here). Not sure if that is
avoidable - I have no problem installing it if not. 

I also noticed it is `providing 'test-ob-fortran' as opposed to
`test-ob-R'. The good news is it demonstrates my automated test server
is working which is how I am on it so quick!

Best, Martyn

> Rainer M Krug <r.m.krug@gmail.com> writes:
>
>> Hi
>>
>> Org-mode version 7.7 (release_7.7.311.g0c099)
>>
>> If execute (Ctrl-c) the code below
>>
>> * load data
>>  #+begin_src R :tangle no :export results :session R
>>    paste("Yep!")
>>  #+end_src
>>
>> I get an error:
>>
>> ##########
>> executing R code block...
>> org-babel-R-evaluate: Wrong number of arguments: #[(session body
>> result-type result-params column-names-p row-names-p) "\bÆ=ƒ}
>> ##########
>> only much longer and lots of strange characters.
>>
>>
>>
>> * load data
>> #+begin_src R :tangle no :export results
>>   paste("Yep!")
>> #+end_src
>>
>> #+results:
>> : Yep!
>>
>> works as expected
>>
>> So I assume there is a problem in the :session header argument.
>>
>> Cheers,
>>
>> Rainer
>>
>>
>> --
>>
>> Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation
>> Biology, UCT), Dipl. Phys. (Germany)
>>
>> Centre of Excellence for Invasion Biology
>> Stellenbosch University
>> South Africa
>>
>> Tel :       +33 - (0)9 53 10 27 44
>> Cell:       +33 - (0)6 85 62 59 98
>> Fax :       +33 - (0)9 58 10 27 44
>>
>> Fax (D):    +49 - (0)3 21 21 25 22 44
>>
>> email:      Rainer@krugs.de
>>
>> Skype:      RMkrug

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 12:57 ` Eric Schulte
  2011-09-21 16:56   ` Martyn Jago
@ 2011-09-21 17:09   ` Rainer M Krug
  1 sibling, 0 replies; 21+ messages in thread
From: Rainer M Krug @ 2011-09-21 17:09 UTC (permalink / raw)
  To: Eric Schulte; +Cc: emacs-orgmode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 21/09/11 14:57, Eric Schulte wrote:
> Hi Rainer,
> 
> Thanks for finding this bug, I introduced it in one of my recent 
> changes.  I've just pushed up a fix and a test case.

Thanks for your prompt response - that's what I like about the open
source community and particularly about the org crowd.

Thanks,
Rainer



> 
> Best -- Eric
> 
> Rainer M Krug <r.m.krug@gmail.com> writes:
> 
>> Hi
>> 
>> Org-mode version 7.7 (release_7.7.311.g0c099)
>> 
>> If execute (Ctrl-c) the code below
>> 
>> * load data #+begin_src R :tangle no :export results :session R 
>> paste("Yep!") #+end_src
>> 
>> I get an error:
>> 
>> ########## executing R code block... org-babel-R-evaluate: Wrong
>> number of arguments: #[(session body result-type result-params
>> column-names-p row-names-p) "\bÆ=ƒ} ########## only much longer
>> and lots of strange characters.
>> 
>> 
>> 
>> * load data #+begin_src R :tangle no :export results 
>> paste("Yep!") #+end_src
>> 
>> #+results: : Yep!
>> 
>> works as expected
>> 
>> So I assume there is a problem in the :session header argument.
>> 
>> Cheers,
>> 
>> Rainer
>> 
>> 
>> --
>> 
>> Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc
>> (Conservation Biology, UCT), Dipl. Phys. (Germany)
>> 
>> Centre of Excellence for Invasion Biology Stellenbosch
>> University South Africa
>> 
>> Tel :       +33 - (0)9 53 10 27 44 Cell:       +33 - (0)6 85 62
>> 59 98 Fax :       +33 - (0)9 58 10 27 44
>> 
>> Fax (D):    +49 - (0)3 21 21 25 22 44
>> 
>> email:      Rainer@krugs.de
>> 
>> Skype:      RMkrug
> 


- -- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation
Biology, UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      Rainer@krugs.de

Skype:      RMkrug
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk56GmEACgkQoYgNqgF2egosSwCaA9OhTQHrmd98UeHbe7kcN6Vn
uqoAnigyjfYhQ3uAMHS+H8eVvURmqujz
=zGjj
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 16:56   ` Martyn Jago
@ 2011-09-21 18:54     ` Sebastien Vauban
  2011-09-21 19:32       ` Eric Schulte
  2011-09-21 19:32     ` Eric Schulte
  1 sibling, 1 reply; 21+ messages in thread
From: Sebastien Vauban @ 2011-09-21 18:54 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Martyn,

Martyn Jago wrote:
> Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>> Thanks for finding this bug, I introduced it in one of my recent
>> changes.  I've just pushed up a fix and a test case.
>
> Unfortunately this test introduces an external dependency for R (which I
> haven't currently got on my system so fails here). Not sure if that is
> avoidable - I have no problem installing it if not. 
>
> I also noticed it is `providing 'test-ob-fortran' as opposed to
> `test-ob-R'.

and a (require 'ob-awk)?

> The good news is it demonstrates my automated test server
> is working which is how I am on it so quick!

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 16:56   ` Martyn Jago
  2011-09-21 18:54     ` Sebastien Vauban
@ 2011-09-21 19:32     ` Eric Schulte
  2011-09-21 20:09       ` Sebastien Vauban
  1 sibling, 1 reply; 21+ messages in thread
From: Eric Schulte @ 2011-09-21 19:32 UTC (permalink / raw)
  To: Martyn Jago; +Cc: emacs-orgmode

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi Eric
>
> Eric Schulte <schulte.eric@gmail.com> writes:
>
>> Hi Rainer,
>>
>> Thanks for finding this bug, I introduced it in one of my recent
>> changes.  I've just pushed up a fix and a test case.
>>
>> Best -- Eric
>>
>
> Unfortunately this test introduces an external dependency for R (which I
> haven't currently got on my system so fails here). Not sure if that is
> avoidable - I have no problem installing it if not. 
>

Yes, I think we're going to have to start putting some conditional
checks into org-test-run-all-tests so that only those code block tests
for which the required languages exist on the user's system are run.  I
don't know the best way to handle this.

>
> I also noticed it is `providing 'test-ob-fortran' as opposed to
> `test-ob-R'.

Thanks, was moving too quickly this morning.

> The good news is it demonstrates my automated test server is working
> which is how I am on it so quick!
>

Indeed, it is great to have this safety net.

Thanks -- Eric

>
> Best, Martyn
>
>> Rainer M Krug <r.m.krug@gmail.com> writes:
>>
>>> Hi
>>>
>>> Org-mode version 7.7 (release_7.7.311.g0c099)
>>>
>>> If execute (Ctrl-c) the code below
>>>
>>> * load data
>>>  #+begin_src R :tangle no :export results :session R
>>>    paste("Yep!")
>>>  #+end_src
>>>
>>> I get an error:
>>>
>>> ##########
>>> executing R code block...
>>> org-babel-R-evaluate: Wrong number of arguments: #[(session body
>>> result-type result-params column-names-p row-names-p) "\bÆ=ƒ}
>>> ##########
>>> only much longer and lots of strange characters.
>>>
>>>
>>>
>>> * load data
>>> #+begin_src R :tangle no :export results
>>>   paste("Yep!")
>>> #+end_src
>>>
>>> #+results:
>>> : Yep!
>>>
>>> works as expected
>>>
>>> So I assume there is a problem in the :session header argument.
>>>
>>> Cheers,
>>>
>>> Rainer
>>>
>>>
>>> --
>>>
>>> Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation
>>> Biology, UCT), Dipl. Phys. (Germany)
>>>
>>> Centre of Excellence for Invasion Biology
>>> Stellenbosch University
>>> South Africa
>>>
>>> Tel :       +33 - (0)9 53 10 27 44
>>> Cell:       +33 - (0)6 85 62 59 98
>>> Fax :       +33 - (0)9 58 10 27 44
>>>
>>> Fax (D):    +49 - (0)3 21 21 25 22 44
>>>
>>> email:      Rainer@krugs.de
>>>
>>> Skype:      RMkrug
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 18:54     ` Sebastien Vauban
@ 2011-09-21 19:32       ` Eric Schulte
  0 siblings, 0 replies; 21+ messages in thread
From: Eric Schulte @ 2011-09-21 19:32 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: emacs-orgmode

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Martyn,
>
> Martyn Jago wrote:
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>> Thanks for finding this bug, I introduced it in one of my recent
>>> changes.  I've just pushed up a fix and a test case.
>>
>> Unfortunately this test introduces an external dependency for R (which I
>> haven't currently got on my system so fails here). Not sure if that is
>> avoidable - I have no problem installing it if not. 
>>
>> I also noticed it is `providing 'test-ob-fortran' as opposed to
>> `test-ob-R'.
>
> and a (require 'ob-awk)?
>

Fixed, Thanks -- Eric

>
>> The good news is it demonstrates my automated test server
>> is working which is how I am on it so quick!
>
> Best regards,
>   Seb

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 19:32     ` Eric Schulte
@ 2011-09-21 20:09       ` Sebastien Vauban
  2011-09-21 21:20         ` Martyn Jago
  0 siblings, 1 reply; 21+ messages in thread
From: Sebastien Vauban @ 2011-09-21 20:09 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Eric and Martyn,

Eric Schulte wrote:
> Martyn Jago <martyn.jago-FhtRXb7CoQBt1OO0OYaSVA@public.gmane.org> writes:
>> Unfortunately this test introduces an external dependency for R (which I
>> haven't currently got on my system so fails here). Not sure if that is
>> avoidable - I have no problem installing it if not. 
>
> Yes, I think we're going to have to start putting some conditional
> checks into org-test-run-all-tests so that only those code block tests
> for which the required languages exist on the user's system are run.  I
> don't know the best way to handle this.

Testing both if:

- the language is activated (`org-babel-load-languages')
- the interpreter is found on the system (`exec-path')

?

Just an idea...

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 20:09       ` Sebastien Vauban
@ 2011-09-21 21:20         ` Martyn Jago
  2011-09-22  2:23           ` Eric Schulte
  0 siblings, 1 reply; 21+ messages in thread
From: Martyn Jago @ 2011-09-21 21:20 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Hi Sebastien and Eric

"Sebastien Vauban"
<wxhgmqzgwmuf@spammotel.com> writes:

> Hi Eric and Martyn,
>
> Eric Schulte wrote:
>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>> Unfortunately this test introduces an external dependency for R (which I
>>> haven't currently got on my system so fails here). Not sure if that is
>>> avoidable - I have no problem installing it if not. 
>>
>> Yes, I think we're going to have to start putting some conditional
>> checks into org-test-run-all-tests so that only those code block tests
>> for which the required languages exist on the user's system are run.  I
>> don't know the best way to handle this.
>
> Testing both if:
>
> - the language is activated (`org-babel-load-languages')
> - the interpreter is found on the system (`exec-path')
>
> ?
>
> Just an idea...
>

I was thinking along the same lines, as a stop-gap at least...
 - test for feature ESS
 - test for R
 - If either are missing, 'bypass' the test but add a note to the test
  backtrace to that effect.
 - If dependencies are satisfied, run the test proper.

My main problem is that my 'config-less' tests are now failing across
Emacs 22, 23 and 24 (obviously), and are thus no longer particularly
useful!

I have included a patch that fixes things for me, but are you still
confident Eric that in the short term your test will still catch the
intended failure mode. I have little doubt that ultimately there will be
a more satisfactory solution.

Best, Martyn


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Bypass-test-where-dependencies-missing --]
[-- Type: text/x-patch, Size: 1220 bytes --]

From de40e439d1a4d110a47d5a0701741493a285143c Mon Sep 17 00:00:00 2001
From: Martyn Jago <martyn.jago@btinternet.com>
Date: Wed, 21 Sep 2011 22:01:16 +0100
Subject: [PATCH] Bypass test where dependencies missing
 * testing/lisp/test-ob-R.el:
 If R or ESS are missing don't run test
 but add NOTE to this effect in test
 backtrace

---
 testing/lisp/test-ob-R.el |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/testing/lisp/test-ob-R.el b/testing/lisp/test-ob-R.el
index 1fe63a5..457bf9c 100644
--- a/testing/lisp/test-ob-R.el
+++ b/testing/lisp/test-ob-R.el
@@ -16,9 +16,13 @@
 (require 'ob-R)
 
 (ert-deftest test-ob-R/simple-session ()
-  (org-test-with-temp-text
-      "#+begin_src R :session R\n  paste(\"Yep!\")\n#+end_src\n"
-    (should (string= "Yep!" (org-babel-execute-src-block)))))
+  (if (and (featurep 'ess)
+	   (eql 0 (shell-command org-babel-R-command)))
+      (org-test-with-temp-text
+	  "#+begin_src R :session R\n  paste(\"Yep!\")\n#+end_src\n"
+	(should (string= "Yep!" (org-babel-execute-src-block))))
+    (message "NOTE: =test-ob-R/simple-session= NOT run!
+ R and ESS are required to run =test-ob-R/simple-session=")))
 
 (provide 'test-ob-R)
 
-- 
1.7.3.4


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]


---
Org-mode version 7.7 (release_7.7.315.g20e6)
GNU Emacs 24.0.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.35)
 of 2011-08-21 on virtualmac.porkrind.org

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-21 21:20         ` Martyn Jago
@ 2011-09-22  2:23           ` Eric Schulte
  2011-09-23 11:36             ` Martyn Jago
  0 siblings, 1 reply; 21+ messages in thread
From: Eric Schulte @ 2011-09-22  2:23 UTC (permalink / raw)
  To: Martyn Jago; +Cc: emacs-orgmode

Hi Martyn,

I've just pushed up what will hopefully be a more general solution.
Basically, language-specific test files can now signal errors if they
have unmet dependencies.  These are then intercepted by `org-test-load'
and the file is not added to the test suite.  Hopefully this will allow
language-specific tests to be written without breaking the config-less
test suite.

See the top of test-ob-R.el for an example usage.

Cheers -- Eric

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi Sebastien and Eric
>
> "Sebastien Vauban"
> <wxhgmqzgwmuf@spammotel.com> writes:
>
>> Hi Eric and Martyn,
>>
>> Eric Schulte wrote:
>>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>>> Unfortunately this test introduces an external dependency for R (which I
>>>> haven't currently got on my system so fails here). Not sure if that is
>>>> avoidable - I have no problem installing it if not. 
>>>
>>> Yes, I think we're going to have to start putting some conditional
>>> checks into org-test-run-all-tests so that only those code block tests
>>> for which the required languages exist on the user's system are run.  I
>>> don't know the best way to handle this.
>>
>> Testing both if:
>>
>> - the language is activated (`org-babel-load-languages')
>> - the interpreter is found on the system (`exec-path')
>>
>> ?
>>
>> Just an idea...
>>
>
> I was thinking along the same lines, as a stop-gap at least...
>  - test for feature ESS
>  - test for R
>  - If either are missing, 'bypass' the test but add a note to the test
>   backtrace to that effect.
>  - If dependencies are satisfied, run the test proper.
>
> My main problem is that my 'config-less' tests are now failing across
> Emacs 22, 23 and 24 (obviously), and are thus no longer particularly
> useful!
>
> I have included a patch that fixes things for me, but are you still
> confident Eric that in the short term your test will still catch the
> intended failure mode. I have little doubt that ultimately there will be
> a more satisfactory solution.
>
> Best, Martyn
>
> From de40e439d1a4d110a47d5a0701741493a285143c Mon Sep 17 00:00:00 2001
> From: Martyn Jago <martyn.jago@btinternet.com>
> Date: Wed, 21 Sep 2011 22:01:16 +0100
> Subject: [PATCH] Bypass test where dependencies missing
>  * testing/lisp/test-ob-R.el:
>  If R or ESS are missing don't run test
>  but add NOTE to this effect in test
>  backtrace
>
> ---
>  testing/lisp/test-ob-R.el |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/testing/lisp/test-ob-R.el b/testing/lisp/test-ob-R.el
> index 1fe63a5..457bf9c 100644
> --- a/testing/lisp/test-ob-R.el
> +++ b/testing/lisp/test-ob-R.el
> @@ -16,9 +16,13 @@
>  (require 'ob-R)
>  
>  (ert-deftest test-ob-R/simple-session ()
> -  (org-test-with-temp-text
> -      "#+begin_src R :session R\n  paste(\"Yep!\")\n#+end_src\n"
> -    (should (string= "Yep!" (org-babel-execute-src-block)))))
> +  (if (and (featurep 'ess)
> +	   (eql 0 (shell-command org-babel-R-command)))
> +      (org-test-with-temp-text
> +	  "#+begin_src R :session R\n  paste(\"Yep!\")\n#+end_src\n"
> +	(should (string= "Yep!" (org-babel-execute-src-block))))
> +    (message "NOTE: =test-ob-R/simple-session= NOT run!
> + R and ESS are required to run =test-ob-R/simple-session=")))
>  
>  (provide 'test-ob-R)

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-22  2:23           ` Eric Schulte
@ 2011-09-23 11:36             ` Martyn Jago
  2011-09-23 15:59               ` Eric Schulte
  0 siblings, 1 reply; 21+ messages in thread
From: Martyn Jago @ 2011-09-23 11:36 UTC (permalink / raw)
  To: emacs-orgmode

Hi Eric

Eric Schulte <schulte.eric@gmail.com> writes:

> Hi Martyn,
>
> I've just pushed up what will hopefully be a more general solution.
> Basically, language-specific test files can now signal errors if they
> have unmet dependencies.  These are then intercepted by `org-test-load'
> and the file is not added to the test suite.  Hopefully this will allow
> language-specific tests to be written without breaking the config-less
> test suite.
>
> See the top of test-ob-R.el for an example usage.
>
> Cheers -- Eric

Unfortunately this is still broken for me. Given the exe exists but the
feature doesn't (ie no personal config), the following line causes the
error `peculiar error' !

--8<---------------cut here---------------start------------->8---
   (signal 'org-test-lib-not-found "ess"))
--8<---------------cut here---------------end--------------->8---

I've published the output of my test server so you can see the
backtrace. It is at http://martynjago.com:3333 
 
Best, Martyn


[...]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 11:36             ` Martyn Jago
@ 2011-09-23 15:59               ` Eric Schulte
  2011-09-23 16:12                 ` Martyn Jago
  0 siblings, 1 reply; 21+ messages in thread
From: Eric Schulte @ 2011-09-23 15:59 UTC (permalink / raw)
  To: Martyn Jago; +Cc: emacs-orgmode

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi Eric
>
> Eric Schulte <schulte.eric@gmail.com> writes:
>
>> Hi Martyn,
>>
>> I've just pushed up what will hopefully be a more general solution.
>> Basically, language-specific test files can now signal errors if they
>> have unmet dependencies.  These are then intercepted by `org-test-load'
>> and the file is not added to the test suite.  Hopefully this will allow
>> language-specific tests to be written without breaking the config-less
>> test suite.
>>
>> See the top of test-ob-R.el for an example usage.
>>
>> Cheers -- Eric
>
> Unfortunately this is still broken for me. Given the exe exists but the
> feature doesn't (ie no personal config), the following line causes the
> error `peculiar error' !
>
>    (signal 'org-test-lib-not-found "ess"))
>

Oh,

I forgot to update the types of errors that I am catching after adding a
new error type for missing libraries (e.g., ess).  This should now be
fixed.

>
> I've published the output of my test server so you can see the
> backtrace. It is at http://martynjago.com:3333 
>  

Very cool,

Does this page refresh after every git commit?

Is there a way to see the output of the test run, all I can find is the
command which is executed.

Cheers -- Eric

> 
> Best, Martyn
>
>
> [...]
>
>
>

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 15:59               ` Eric Schulte
@ 2011-09-23 16:12                 ` Martyn Jago
  2011-09-23 22:16                   ` Sebastien Vauban
  2011-09-24 22:12                   ` Eric Schulte
  0 siblings, 2 replies; 21+ messages in thread
From: Martyn Jago @ 2011-09-23 16:12 UTC (permalink / raw)
  To: emacs-orgmode

Hi Eric

Eric Schulte <schulte.eric@gmail.com> writes:

> Martyn Jago <martyn.jago@btinternet.com> writes:
>
>> Hi Eric
>>
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>
>>> Hi Martyn,
>>>
>>> I've just pushed up what will hopefully be a more general solution.
>>> Basically, language-specific test files can now signal errors if they
>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>> and the file is not added to the test suite.  Hopefully this will allow
>>> language-specific tests to be written without breaking the config-less
>>> test suite.
>>>
>>> See the top of test-ob-R.el for an example usage.
>>>
>>> Cheers -- Eric
>>
>> Unfortunately this is still broken for me. Given the exe exists but the
>> feature doesn't (ie no personal config), the following line causes the
>> error `peculiar error' !
>>
>>    (signal 'org-test-lib-not-found "ess"))
>>
>
> Oh,
>
> I forgot to update the types of errors that I am catching after adding a
> new error type for missing libraries (e.g., ess).  This should now be
> fixed.
>

There still seems to be a problem with test-ob-R - same error "peculiar
error".

>>
>> I've published the output of my test server so you can see the
>> backtrace. It is at http://martynjago.com:3333 
>>  
>
> Very cool,
>
> Does this page refresh after every git commit?

Yes - the repository is polled once per minute and a git pull + make
clean / install etc + run tests is performed, so the test server now
reflects your latest commit.

>
> Is there a way to see the output of the test run, all I can find is the
> command which is executed.

Yes - just click on the org-mode_Emacs_24 (title) link and then on the
build log link. There isn't much of a log on the failing tests since
the entire test run is broken by the signal. 

You can checkout the build log for my-org-mode-dev to see what you
should get.

Best, Martyn

>
> Cheers -- Eric
>
>> 
>> Best, Martyn
>>
>>
>> [...]
>>
>>
>>

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 16:12                 ` Martyn Jago
@ 2011-09-23 22:16                   ` Sebastien Vauban
  2011-09-24 22:13                     ` Eric Schulte
  2011-09-25  8:37                     ` Martyn Jago
  2011-09-24 22:12                   ` Eric Schulte
  1 sibling, 2 replies; 21+ messages in thread
From: Sebastien Vauban @ 2011-09-23 22:16 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Martyn and Eric,

Martyn Jago wrote:
> Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>> Martyn Jago <martyn.jago-FhtRXb7CoQBt1OO0OYaSVA@public.gmane.org> writes:
>>> Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>>>> I've just pushed up what will hopefully be a more general solution.
>>>> Basically, language-specific test files can now signal errors if they
>>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>>> and the file is not added to the test suite.  Hopefully this will allow
>>>> language-specific tests to be written without breaking the config-less
>>>> test suite.
>>>>
>>>> See the top of test-ob-R.el for an example usage.
>>>>
>>>> Cheers -- Eric
>>>
>>> Unfortunately this is still broken for me. Given the exe exists but the
>>> feature doesn't (ie no personal config), the following line causes the
>>> error `peculiar error' !
>>>
>>>    (signal 'org-test-lib-not-found "ess"))

FYI, same for me, with the "batch tests", on a git update'd copy done 2 mins
ago.

#+begin_src sh
emacs -Q --batch -l "/cygdrive/c/Program Files/Emacs-24.0/lisp/emacs-lisp/ert.el" -l "/cygdrive/c/Program Files/Emacs-24.0/lisp/emacs-lisp/ert-x.el" -l ~/src/org-mode/testing/org-test.el --eval "(setq org-confirm-babel-evaluate nil)" -f org-test-run-batch-tests
#+end_src

#+results:
OVERVIEW
Loading vc-git...
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
OVERVIEW
Loading /cygdrive/c/home/sva/src/org-mode/testing/lisp/test-ob-R.el (source)...
peculiar error

This is on Windows XP SP3, with a Cygwin Emacs (when run from terminal;
otherwise, it is a Win32 binary from the FSF).

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 16:12                 ` Martyn Jago
  2011-09-23 22:16                   ` Sebastien Vauban
@ 2011-09-24 22:12                   ` Eric Schulte
  2011-09-25  8:31                     ` Martyn Jago
  1 sibling, 1 reply; 21+ messages in thread
From: Eric Schulte @ 2011-09-24 22:12 UTC (permalink / raw)
  To: Martyn Jago; +Cc: emacs-orgmode

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi Eric
>
> Eric Schulte <schulte.eric@gmail.com> writes:
>
>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>
>>> Hi Eric
>>>
>>> Eric Schulte <schulte.eric@gmail.com> writes:
>>>
>>>> Hi Martyn,
>>>>
>>>> I've just pushed up what will hopefully be a more general solution.
>>>> Basically, language-specific test files can now signal errors if they
>>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>>> and the file is not added to the test suite.  Hopefully this will allow
>>>> language-specific tests to be written without breaking the config-less
>>>> test suite.
>>>>
>>>> See the top of test-ob-R.el for an example usage.
>>>>
>>>> Cheers -- Eric
>>>
>>> Unfortunately this is still broken for me. Given the exe exists but the
>>> feature doesn't (ie no personal config), the following line causes the
>>> error `peculiar error' !
>>>
>>>    (signal 'org-test-lib-not-found "ess"))
>>>
>>
>> Oh,
>>
>> I forgot to update the types of errors that I am catching after adding a
>> new error type for missing libraries (e.g., ess).  This should now be
>> fixed.
>>
>
> There still seems to be a problem with test-ob-R - same error "peculiar
> error".
>

OK, I see this error as well.  I've switched from using errors to signal
a missing dependency to using catch/throw blocks.  This seems to
actually work, hopefully the test suite should now run w/o error.

>
>>
>> Is there a way to see the output of the test run, all I can find is the
>> command which is executed.
>
> Yes - just click on the org-mode_Emacs_24 (title) link and then on the
> build log link. There isn't much of a log on the failing tests since
> the entire test run is broken by the signal. 
>
> You can checkout the build log for my-org-mode-dev to see what you
> should get.
>

Great, doing this I can see that everything is now running successfully
http://martynjago.com:3333/builds/org-mode_Emacs_24/4446e50/build.log

Very nice system, I wonder if we could run something like this on the
Org-mode server.

Cheers -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 22:16                   ` Sebastien Vauban
@ 2011-09-24 22:13                     ` Eric Schulte
  2011-09-25  8:37                     ` Martyn Jago
  1 sibling, 0 replies; 21+ messages in thread
From: Eric Schulte @ 2011-09-24 22:13 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: emacs-orgmode

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Martyn and Eric,
>
> Martyn Jago wrote:
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>>> Eric Schulte <schulte.eric@gmail.com> writes:
>>>>> I've just pushed up what will hopefully be a more general solution.
>>>>> Basically, language-specific test files can now signal errors if they
>>>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>>>> and the file is not added to the test suite.  Hopefully this will allow
>>>>> language-specific tests to be written without breaking the config-less
>>>>> test suite.
>>>>>
>>>>> See the top of test-ob-R.el for an example usage.
>>>>>
>>>>> Cheers -- Eric
>>>>
>>>> Unfortunately this is still broken for me. Given the exe exists but the
>>>> feature doesn't (ie no personal config), the following line causes the
>>>> error `peculiar error' !
>>>>
>>>>    (signal 'org-test-lib-not-found "ess"))
>
> FYI, same for me, with the "batch tests", on a git update'd copy done 2 mins
> ago.
>

Thanks for the supporting info.  I've just pushed up a fix which should
resolve this issue.

Cheers -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-24 22:12                   ` Eric Schulte
@ 2011-09-25  8:31                     ` Martyn Jago
  0 siblings, 0 replies; 21+ messages in thread
From: Martyn Jago @ 2011-09-25  8:31 UTC (permalink / raw)
  To: emacs-orgmode

Hi Eric

Eric Schulte <schulte.eric@gmail.com> writes:

> Martyn Jago <martyn.jago@btinternet.com> writes:
>
>> Hi Eric
>>
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>
>>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>>
>>>> Hi Eric
>>>>
>>>> Eric Schulte <schulte.eric@gmail.com> writes:
>>>>
>>>>> Hi Martyn,
>>>>>
>>>>> I've just pushed up what will hopefully be a more general solution.
>>>>> Basically, language-specific test files can now signal errors if they
>>>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>>>> and the file is not added to the test suite.  Hopefully this will allow
>>>>> language-specific tests to be written without breaking the config-less
>>>>> test suite.
>>>>>
>>>>> See the top of test-ob-R.el for an example usage.
>>>>>
>>>>> Cheers -- Eric
>>>>
>>>> Unfortunately this is still broken for me. Given the exe exists but the
>>>> feature doesn't (ie no personal config), the following line causes the
>>>> error `peculiar error' !
>>>>
>>>>    (signal 'org-test-lib-not-found "ess"))
>>>>
>>>
>>> Oh,
>>>
>>> I forgot to update the types of errors that I am catching after adding a
>>> new error type for missing libraries (e.g., ess).  This should now be
>>> fixed.
>>>
>>
>> There still seems to be a problem with test-ob-R - same error "peculiar
>> error".
>>
>
> OK, I see this error as well.  I've switched from using errors to signal
> a missing dependency to using catch/throw blocks.  This seems to
> actually work, hopefully the test suite should now run w/o error.
>

This now works great for me. 

>>
>>>
>>> Is there a way to see the output of the test run, all I can find is the
>>> command which is executed.
>>
>> Yes - just click on the org-mode_Emacs_24 (title) link and then on the
>> build log link. There isn't much of a log on the failing tests since
>> the entire test run is broken by the signal. 
>>
>> You can checkout the build log for my-org-mode-dev to see what you
>> should get.
>>
>
> Great, doing this I can see that everything is now running successfully
> http://martynjago.com:3333/builds/org-mode_Emacs_24/4446e50/build.log
>
> Very nice system, I wonder if we could run something like this on the
> Org-mode server.

It should be fairly easy to set up a similar system on the Org-mode
server, and very useful I would have thought. I agree it is a very
useful system and have used it several times on other projects.

Best, Martyn

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-23 22:16                   ` Sebastien Vauban
  2011-09-24 22:13                     ` Eric Schulte
@ 2011-09-25  8:37                     ` Martyn Jago
  2011-09-26  7:54                       ` Sebastien Vauban
  1 sibling, 1 reply; 21+ messages in thread
From: Martyn Jago @ 2011-09-25  8:37 UTC (permalink / raw)
  To: emacs-orgmode

Hi Sebastien

"Sebastien Vauban"
<wxhgmqzgwmuf@spammotel.com> writes:

> Hi Martyn and Eric,
>
> Martyn Jago wrote:
>> Eric Schulte <schulte.eric@gmail.com> writes:
>>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>>> Eric Schulte <schulte.eric@gmail.com> writes:
>>>>> I've just pushed up what will hopefully be a more general solution.
>>>>> Basically, language-specific test files can now signal errors if they
>>>>> have unmet dependencies.  These are then intercepted by `org-test-load'
>>>>> and the file is not added to the test suite.  Hopefully this will allow
>>>>> language-specific tests to be written without breaking the config-less
>>>>> test suite.
>>>>>
>>>>> See the top of test-ob-R.el for an example usage.
>>>>>
>>>>> Cheers -- Eric
>>>>
>>>> Unfortunately this is still broken for me. Given the exe exists but the
>>>> feature doesn't (ie no personal config), the following line causes the
>>>> error `peculiar error' !
>>>>
>>>>    (signal 'org-test-lib-not-found "ess"))
>
> FYI, same for me, with the "batch tests", on a git update'd copy done 2 mins
> ago.
>
> #+begin_src sh
> emacs -Q --batch -l "/cygdrive/c/Program Files/Emacs-24.0/lisp/emacs-lisp/ert.el" -l "/cygdrive/c/Program Files/Emacs-24.0/lisp/emacs-lisp/ert-x.el" -l ~/src/org-mode/testing/org-test.el --eval "(setq org-confirm-babel-evaluate nil)" -f org-test-run-batch-tests
> #+end_src
>
> #+results:
> OVERVIEW
> Loading vc-git...
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> OVERVIEW
> Loading /cygdrive/c/home/sva/src/org-mode/testing/lisp/test-ob-R.el (source)...
> peculiar error
>
> This is on Windows XP SP3, with a Cygwin Emacs (when run from terminal;
> otherwise, it is a Win32 binary from the FSF).
>

Its really great to hear you are running the tests on Windows. At some
point I hope to test with the EmacsW32 port.

Best, Martyn

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-25  8:37                     ` Martyn Jago
@ 2011-09-26  7:54                       ` Sebastien Vauban
  2011-09-26 12:23                         ` Eric Schulte
  0 siblings, 1 reply; 21+ messages in thread
From: Sebastien Vauban @ 2011-09-26  7:54 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Martyn and Eric,

Martyn Jago wrote:
> "Sebastien Vauban"
> <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>> Martyn Jago wrote:
>>> Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>>>> Martyn Jago <martyn.jago-FhtRXb7CoQBt1OO0OYaSVA@public.gmane.org> writes:
>>>>> Unfortunately this is still broken for me. Given the exe exists but the
>>>>> feature doesn't (ie no personal config), the following line causes the
>>>>> error `peculiar error' !
>>>>>
>>>>>    (signal 'org-test-lib-not-found "ess"))
>>
>> FYI, same for me, with the "batch tests", on a git update'd copy done 2 mins
>> ago.
>>
>> #+begin_src sh
>> emacs -Q --batch -l "/cygdrive/c/Program
>> Files/Emacs-24.0/lisp/emacs-lisp/ert.el" -l "/cygdrive/c/Program
>> Files/Emacs-24.0/lisp/emacs-lisp/ert-x.el" -l
>> ~/src/org-mode/testing/org-test.el --eval "(setq org-confirm-babel-evaluate
>> nil)" -f org-test-run-batch-tests
>> #+end_src
>>
>> #+results:
>> OVERVIEW
>> Loading vc-git...
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> OVERVIEW
>> Loading /cygdrive/c/home/sva/src/org-mode/testing/lisp/test-ob-R.el (source)...
>> peculiar error

Just git pull'ed, and re-tested:

    ┏━━━━
    ┃ Ran 111 tests, 104 results as expected, 7 unexpected (2011-09-26 08:20:06+0200)
    ┃ 
    ┃ 7 unexpected results:
    ┃    FAILED  ob-fortran/command-arguments
    ┃    FAILED  ob-fortran/fortran-var-program
    ┃    FAILED  ob-fortran/input-var
    ┃    FAILED  ob-fortran/list-var
    ┃    FAILED  ob-fortran/list-var-from-table
    ┃    FAILED  ob-fortran/preprosessor-var
    ┃    FAILED  ob-fortran/simple-program
    ┗━━━━

"Normal", I don't have any fortran installed. Maybe, some sort of protection
should have to be applied to these too.

>> This is on Windows XP SP3, with a Cygwin Emacs (when run from terminal;
>> otherwise, it is a Win32 binary from the FSF).
>
> Its really great to hear you are running the tests on Windows. At some
> point I hope to test with the EmacsW32 port.

I can do it as well. I should automate this -- not difficult, though.

If there is some shared place to place such results, I can imagine running
them every couple of hours (cron'ed), or so, and publish the resulting HTML. I
could do this when being online, that is more or less half of the time.

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-26  7:54                       ` Sebastien Vauban
@ 2011-09-26 12:23                         ` Eric Schulte
  2011-09-26 13:59                           ` Sebastien Vauban
  0 siblings, 1 reply; 21+ messages in thread
From: Eric Schulte @ 2011-09-26 12:23 UTC (permalink / raw)
  To: Sebastien Vauban; +Cc: emacs-orgmode

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Martyn and Eric,
>
> Martyn Jago wrote:
>> "Sebastien Vauban"
>> <wxhgmqzgwmuf@spammotel.com> writes:
>>> Martyn Jago wrote:
>>>> Eric Schulte <schulte.eric@gmail.com> writes:
>>>>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>>>>> Unfortunately this is still broken for me. Given the exe exists but the
>>>>>> feature doesn't (ie no personal config), the following line causes the
>>>>>> error `peculiar error' !
>>>>>>
>>>>>>    (signal 'org-test-lib-not-found "ess"))
>>>
>>> FYI, same for me, with the "batch tests", on a git update'd copy done 2 mins
>>> ago.
>>>
>>> #+begin_src sh
>>> emacs -Q --batch -l "/cygdrive/c/Program
>>> Files/Emacs-24.0/lisp/emacs-lisp/ert.el" -l "/cygdrive/c/Program
>>> Files/Emacs-24.0/lisp/emacs-lisp/ert-x.el" -l
>>> ~/src/org-mode/testing/org-test.el --eval "(setq org-confirm-babel-evaluate
>>> nil)" -f org-test-run-batch-tests
>>> #+end_src
>>>
>>> #+results:
>>> OVERVIEW
>>> Loading vc-git...
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> OVERVIEW
>>> Loading /cygdrive/c/home/sva/src/org-mode/testing/lisp/test-ob-R.el (source)...
>>> peculiar error
>
> Just git pull'ed, and re-tested:
>
>     ┏━━━━
>     ┃ Ran 111 tests, 104 results as expected, 7 unexpected (2011-09-26 08:20:06+0200)
>     ┃ 
>     ┃ 7 unexpected results:
>     ┃    FAILED  ob-fortran/command-arguments
>     ┃    FAILED  ob-fortran/fortran-var-program
>     ┃    FAILED  ob-fortran/input-var
>     ┃    FAILED  ob-fortran/list-var
>     ┃    FAILED  ob-fortran/list-var-from-table
>     ┃    FAILED  ob-fortran/preprosessor-var
>     ┃    FAILED  ob-fortran/simple-program
>     ┗━━━━
>
> "Normal", I don't have any fortran installed. Maybe, some sort of protection
> should have to be applied to these too.
>

I've just improved the code which checks for executables as the previous
version was probably linux-specific.  The following should now throw an
error on your system which should inhibit loading of the fortran tests.

(org-test-for-executable "gfortran")

>
>>> This is on Windows XP SP3, with a Cygwin Emacs (when run from terminal;
>>> otherwise, it is a Win32 binary from the FSF).
>>
>> Its really great to hear you are running the tests on Windows. At some
>> point I hope to test with the EmacsW32 port.
>
> I can do it as well. I should automate this -- not difficult, though.
>
> If there is some shared place to place such results, I can imagine running
> them every couple of hours (cron'ed), or so, and publish the resulting HTML. I
> could do this when being online, that is more or less half of the time.
>

This sounds great.  I agree that a public place to post results would be
useful.  Also, while we don't have any HTML export right now, simply
redirecting the results of the test execution to a file should be
sufficient.

Cheers -- Eric

>
> Best regards,
>   Seb

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [babel] BUG in :session
  2011-09-26 12:23                         ` Eric Schulte
@ 2011-09-26 13:59                           ` Sebastien Vauban
  0 siblings, 0 replies; 21+ messages in thread
From: Sebastien Vauban @ 2011-09-26 13:59 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Eric,

Eric Schulte wrote:
> "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>> Martyn Jago wrote:
>>> "Sebastien Vauban"
>>> <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> writes:
>>>> Loading /cygdrive/c/home/sva/src/org-mode/testing/lisp/test-ob-R.el (source)...
>>>> peculiar error
>>
>> Just git pull'ed, and re-tested:
>>
>>     ┏━━━━
>>     ┃ Ran 111 tests, 104 results as expected, 7 unexpected (2011-09-26 08:20:06+0200)
>>     ┃ 
>>     ┃ 7 unexpected results:
>>     ┃    FAILED  ob-fortran/command-arguments
>>     ┃    FAILED  ob-fortran/fortran-var-program
>>     ┃    FAILED  ob-fortran/input-var
>>     ┃    FAILED  ob-fortran/list-var
>>     ┃    FAILED  ob-fortran/list-var-from-table
>>     ┃    FAILED  ob-fortran/preprosessor-var
>>     ┃    FAILED  ob-fortran/simple-program
>>     ┗━━━━
>>
>> "Normal", I don't have any fortran installed. Maybe, some sort of protection
>> should have to be applied to these too.
>
> I've just improved the code which checks for executables as the previous
> version was probably linux-specific.  The following should now throw an
> error on your system which should inhibit loading of the fortran tests.
>
> (org-test-for-executable "gfortran")

New status:

    ┏━━━━
    ┃ Ran 102 tests, 102 results as expected (2011-09-26 15:54:14+0200)
    ┗━━━━

Perfect...


>>>> This is on Windows XP SP3, with a Cygwin Emacs (when run from terminal;
>>>> otherwise, it is a Win32 binary from the FSF).
>>>
>>> Its really great to hear you are running the tests on Windows. At some
>>> point I hope to test with the EmacsW32 port.
>>
>> I can do it as well. I should automate this -- not difficult, though.
>>
>> If there is some shared place to place such results, I can imagine running
>> them every couple of hours (cron'ed), or so, and publish the resulting HTML. I
>> could do this when being online, that is more or less half of the time.
>
> This sounds great.  I agree that a public place to post results would be
> useful.  Also, while we don't have any HTML export right now, simply
> redirecting the results of the test execution to a file should be
> sufficient.

We can put such in place. For Windows tests, it could be someone else, if
someone promises to be 24/7 online -- what won't be my case. Otherwise, I'm
willing to do it, simply know that there will be holes in the update of the
results.

Best regards,
  Seb

-- 
Sebastien Vauban

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2011-09-26 13:59 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-21 11:19 [babel] BUG in :session Rainer M Krug
2011-09-21 12:57 ` Eric Schulte
2011-09-21 16:56   ` Martyn Jago
2011-09-21 18:54     ` Sebastien Vauban
2011-09-21 19:32       ` Eric Schulte
2011-09-21 19:32     ` Eric Schulte
2011-09-21 20:09       ` Sebastien Vauban
2011-09-21 21:20         ` Martyn Jago
2011-09-22  2:23           ` Eric Schulte
2011-09-23 11:36             ` Martyn Jago
2011-09-23 15:59               ` Eric Schulte
2011-09-23 16:12                 ` Martyn Jago
2011-09-23 22:16                   ` Sebastien Vauban
2011-09-24 22:13                     ` Eric Schulte
2011-09-25  8:37                     ` Martyn Jago
2011-09-26  7:54                       ` Sebastien Vauban
2011-09-26 12:23                         ` Eric Schulte
2011-09-26 13:59                           ` Sebastien Vauban
2011-09-24 22:12                   ` Eric Schulte
2011-09-25  8:31                     ` Martyn Jago
2011-09-21 17:09   ` Rainer M Krug

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).