* Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? [not found] <m2illt5rzj.fsf@numbchild> @ 2022-10-01 2:53 ` Christopher M. Miles [not found] ` <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com> 1 sibling, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-01 2:53 UTC (permalink / raw) To: Org Mode [-- Attachment #1: Type: text/plain, Size: 1195 bytes --] The original email (contains image) is in bellowing link in case this forwarded email does not contain images. https://lists.gnu.org/archive/html/help-gnu-emacs/2022-09/msg00179.html "Christopher M. Miles" <numbchild@gmail.com> writes: > [[PGP Signed Part:Undecided]] > > Question: As the email subject said. > > Here is the two screenshots: > > *NOTE*: The image itself does not have this horizontal line. > > The point is on image: > > > > > The point is not on image: > > > > > Here is the prototype code which displaying image with text-property: > > #+begin_src emacs-lisp > (put-text-property start end > 'display (create-image thumbnail nil nil :ascent 'center :max-height thumbnail-size)) > #+end_src > > - If this is some kind of internal mechanism of Emacs, can someone explain why? > > - If have some method to remove those horizontal lines. How to do it? -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com>]
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? [not found] ` <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com> @ 2022-10-01 5:37 ` Ihor Radchenko 2022-10-01 8:55 ` Christopher M. Miles ` (2 more replies) 0 siblings, 3 replies; 16+ messages in thread From: Ihor Radchenko @ 2022-10-01 5:37 UTC (permalink / raw) To: numbchild; +Cc: Org Mode "Christopher M. Miles" <numbchild@gmail.com> writes: >> Here is the prototype code which displaying image with text-property: >> >> #+begin_src emacs-lisp >> (put-text-property start end >> 'display (create-image thumbnail nil nil :ascent 'center :max-height thumbnail-size)) >> #+end_src >> >> - If this is some kind of internal mechanism of Emacs, can someone explain why? >> >> - If have some method to remove those horizontal lines. How to do it? Could you please detail the steps required to reproduce the problem, starting from emacs -Q? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? 2022-10-01 5:37 ` Ihor Radchenko @ 2022-10-01 8:55 ` Christopher M. Miles 2022-10-01 8:58 ` Christopher M. Miles [not found] ` <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com> 2 siblings, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-01 8:55 UTC (permalink / raw) To: Ihor Radchenko; +Cc: numbchild, Org Mode [-- Attachment #1: Type: text/plain, Size: 1815 bytes --] Ihor Radchenko <yantar92@gmail.com> writes: > "Christopher M. Miles" <numbchild@gmail.com> writes: > >>> Here is the prototype code which displaying image with text-property: >>> >>> #+begin_src emacs-lisp >>> (put-text-property start end >>> 'display (create-image thumbnail nil nil :ascent 'center :max-height thumbnail-size)) >>> #+end_src >>> >>> - If this is some kind of internal mechanism of Emacs, can someone explain why? >>> >>> - If have some method to remove those horizontal lines. How to do it? > > Could you please detail the steps required to reproduce the problem, > starting from emacs -Q? Here is the steps to reproduce with "emacs -Q" 1. =$ emacs -Q= 2. install package =[M-x package-install RET org-link-beautify RET]= 3. load the package =[M-x load-library org-link-beautify RET]=, the package source code URL here: https://repo.or.cz/org-link-beautify.git 4. open an Org file which has content which has a "file:" link to a video file (You can replace the video file link as yours) : #+begin_src org ,* headline 1 link [[file:~/Downloads/3veEPJrQrV1EtpH9.mp4]] #+end_src 5. enable minor mode =[M-x org-link-beautify-mode RET]=. This mode will auto thumbnail for video file and display it with /text-property/. 6. The displayed thumbnail on link has a center-line. 7. But open the generated thumbnail image file =file:.thumbnails/3veEPJrQrV1EtpH9.png= with external program, it does not have this center-line. -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? 2022-10-01 5:37 ` Ihor Radchenko 2022-10-01 8:55 ` Christopher M. Miles @ 2022-10-01 8:58 ` Christopher M. Miles [not found] ` <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com> 2 siblings, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-01 8:58 UTC (permalink / raw) To: Ihor Radchenko; +Cc: numbchild, Org Mode [-- Attachment #1: Type: text/plain, Size: 1188 bytes --] Ihor Radchenko <yantar92@gmail.com> writes: > "Christopher M. Miles" <numbchild@gmail.com> writes: > >>> Here is the prototype code which displaying image with text-property: >>> >>> #+begin_src emacs-lisp >>> (put-text-property start end >>> 'display (create-image thumbnail nil nil :ascent 'center :max-height thumbnail-size)) >>> #+end_src >>> >>> - If this is some kind of internal mechanism of Emacs, can someone explain why? >>> >>> - If have some method to remove those horizontal lines. How to do it? > > Could you please detail the steps required to reproduce the problem, > starting from emacs -Q? Additional info: The package "org-link-beautify" generating video thumbnails require external command-line tools, you maybe need to install it depend on your system platform. More details you can check the package source code: https://repo.or.cz/org-link-beautify.git -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com>]
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? [not found] ` <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com> @ 2022-10-01 10:33 ` Ihor Radchenko 2022-10-01 12:45 ` Christopher M. Miles [not found] ` <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com> 0 siblings, 2 replies; 16+ messages in thread From: Ihor Radchenko @ 2022-10-01 10:33 UTC (permalink / raw) To: Christopher M. Miles; +Cc: Org Mode "Christopher M. Miles" <numbchild@gmail.com> writes: > 2. install package =[M-x package-install RET org-link-beautify RET]= Hmm. Can you also reproduce without org-link-beautify? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? 2022-10-01 10:33 ` Ihor Radchenko @ 2022-10-01 12:45 ` Christopher M. Miles [not found] ` <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com> 1 sibling, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-01 12:45 UTC (permalink / raw) To: Ihor Radchenko; +Cc: Christopher M. Miles, Org Mode [-- Attachment #1: Type: text/plain, Size: 1941 bytes --] Ihor Radchenko <yantar92@gmail.com> writes: > "Christopher M. Miles" <numbchild@gmail.com> writes: > >> 2. install package =[M-x package-install RET org-link-beautify RET]= > > Hmm. Can you also reproduce without org-link-beautify? I replaced step 5 with step 6 by extracting the logic code of org-link-beautify, but I found it does not have center-line. That's really weird. 1. =$ emacs -Q= 2. install package =[M-x package-install RET org-link-beautify RET]= 3. load the package =[M-x load-library org-link-beautify RET]= 4. open an Org file which has content which has a "file:" link to a video file (You can replace the video file link as yours) : #+begin_src org ,* headline 1 link [[file:~/Downloads/3veEPJrQrV1EtpH9.mp4]] #+end_src 5. enable minor mode =[M-x org-link-beautify-mode RET]=. This mode will auto thumbnail for video file and display it with /text-property/. 6. reproduce without org-link-beautify #+begin_src emacs-lisp (let ((start (point)) (end (save-excursion (forward-word) (point)))) (org-link-beautify--add-overlay-marker start end) (put-text-property start end 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512)) (make-local-variable 'image-map) (define-key image-map (kbd "<mouse-1>") 'org-open-at-point)) #+end_src 7. The displayed thumbnail on link has a center-line. 8. But open the generated thumbnail image file =file:.thumbnails/3veEPJrQrV1EtpH9.png= with external program, it does not have this center-line. -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com>]
* Re: Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? [not found] ` <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com> @ 2022-10-02 4:17 ` Ihor Radchenko 2022-10-02 7:03 ` Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute Christopher M. Miles 0 siblings, 1 reply; 16+ messages in thread From: Ihor Radchenko @ 2022-10-02 4:17 UTC (permalink / raw) To: Christopher M. Miles; +Cc: Org Mode "Christopher M. Miles" <numbchild@gmail.com> writes: > I replaced step 5 with step 6 by extracting the logic code of > org-link-beautify, but I found it does not have center-line. That's > really weird. > ... > (put-text-property > start end > 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512)) > (make-local-variable 'image-map) > (define-key image-map (kbd "<mouse-1>") 'org-open-at-point)) > #+end_src On my side, the put-text-property does have center-line. But only when buffer is in Org mode. Yet, it is not Org's fault. The reason you are seeing the horizontal line is org-link face. org-link has underline. And the "center" line you are seeing is actually underline coming from the face. I'd say it is emacs bug. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92 ^ permalink raw reply [flat|nested] 16+ messages in thread
* Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 4:17 ` Ihor Radchenko @ 2022-10-02 7:03 ` Christopher M. Miles 2022-10-02 7:41 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Christopher M. Miles @ 2022-10-02 7:03 UTC (permalink / raw) To: Ihor Radchenko, Emacs Devel; +Cc: Christopher M. Miles, Org Mode [-- Attachment #1: Type: text/plain, Size: 1591 bytes --] Ihor Radchenko <yantar92@gmail.com> writes: > "Christopher M. Miles" <numbchild@gmail.com> writes: > >> I replaced step 5 with step 6 by extracting the logic code of >> org-link-beautify, but I found it does not have center-line. That's >> really weird. >> ... >> (put-text-property >> start end >> 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512)) >> (make-local-variable 'image-map) >> (define-key image-map (kbd "<mouse-1>") 'org-open-at-point)) >> #+end_src > > On my side, the put-text-property does have center-line. > But only when buffer is in Org mode. > Yet, it is not Org's fault. > > The reason you are seeing the horizontal line is org-link face. > org-link has underline. And the "center" line you are seeing is actually > underline coming from the face. I'd say it is emacs bug. Thanks very much for figuring out this issue, Ihor. I see, I originally post this issue on Emacs-help mailing list, Eli let me forward this thread to Org mode mailing list. Now I need to forward to Emacs-devel mailing list. In case the background info is missing, link original message here: https://list.orgmode.org/87mtae2718.fsf@localhost/T/#m35d40f37fdf80f413ddb8d40e3017a6f102651e9 -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 7:03 ` Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute Christopher M. Miles @ 2022-10-02 7:41 ` Eli Zaretskii 2022-10-02 10:45 ` [CLOSED] " Christopher M. Miles [not found] ` <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com> 0 siblings, 2 replies; 16+ messages in thread From: Eli Zaretskii @ 2022-10-02 7:41 UTC (permalink / raw) To: numbchild; +Cc: yantar92, emacs-devel, emacs-orgmode > From: "Christopher M. Miles" <numbchild@gmail.com> > Cc: "Christopher M. Miles" <numbchild@gmail.com>, Org Mode > <emacs-orgmode@gnu.org> > Date: Sun, 02 Oct 2022 15:03:26 +0800 > > Ihor Radchenko <yantar92@gmail.com> writes: > > > "Christopher M. Miles" <numbchild@gmail.com> writes: > > > >> I replaced step 5 with step 6 by extracting the logic code of > >> org-link-beautify, but I found it does not have center-line. That's > >> really weird. > >> ... > >> (put-text-property > >> start end > >> 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512)) > >> (make-local-variable 'image-map) > >> (define-key image-map (kbd "<mouse-1>") 'org-open-at-point)) > >> #+end_src > > > > On my side, the put-text-property does have center-line. > > But only when buffer is in Org mode. > > Yet, it is not Org's fault. > > > > The reason you are seeing the horizontal line is org-link face. > > org-link has underline. And the "center" line you are seeing is actually > > underline coming from the face. I'd say it is emacs bug. > > Thanks very much for figuring out this issue, Ihor. > > I see, I originally post this issue on Emacs-help mailing list, Eli let > me forward this thread to Org mode mailing list. Now I need to forward > to Emacs-devel mailing list. > > In case the background info is missing, link original message here: > > https://list.orgmode.org/87mtae2718.fsf@localhost/T/#m35d40f37fdf80f413ddb8d40e3017a6f102651e9 Please report this as a bug, with "M-x report-emacs-bug", and please include there all the details, including the recipe to reproduce the issue. Thanks. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 7:41 ` Eli Zaretskii @ 2022-10-02 10:45 ` Christopher M. Miles 2022-10-02 11:07 ` Eli Zaretskii [not found] ` <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com> 1 sibling, 1 reply; 16+ messages in thread From: Christopher M. Miles @ 2022-10-02 10:45 UTC (permalink / raw) To: Eli Zaretskii; +Cc: numbchild, yantar92, emacs-devel, emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 2516 bytes --] I hate to rewrite those steps more than 3 times. But I also know Emacs contributors should not be forced to fix bug for me. Also I can't fix this bug by myself. So I think it's not a bug, I can tolerate this center line. Maybe I mastered skill for modify code in Emacs, I might come back to fix this bug by myself. But now, let me close it. I'm not hating anybody, just hate this process. Thanks for checking out. Eli Zaretskii <eliz@gnu.org> writes: >> From: "Christopher M. Miles" <numbchild@gmail.com> >> Cc: "Christopher M. Miles" <numbchild@gmail.com>, Org Mode >> <emacs-orgmode@gnu.org> >> Date: Sun, 02 Oct 2022 15:03:26 +0800 >> >> Ihor Radchenko <yantar92@gmail.com> writes: >> >> > "Christopher M. Miles" <numbchild@gmail.com> writes: >> > >> >> I replaced step 5 with step 6 by extracting the logic code of >> >> org-link-beautify, but I found it does not have center-line. That's >> >> really weird. >> >> ... >> >> (put-text-property >> >> start end >> >> 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512)) >> >> (make-local-variable 'image-map) >> >> (define-key image-map (kbd "<mouse-1>") 'org-open-at-point)) >> >> #+end_src >> > >> > On my side, the put-text-property does have center-line. >> > But only when buffer is in Org mode. >> > Yet, it is not Org's fault. >> > >> > The reason you are seeing the horizontal line is org-link face. >> > org-link has underline. And the "center" line you are seeing is actually >> > underline coming from the face. I'd say it is emacs bug. >> >> Thanks very much for figuring out this issue, Ihor. >> >> I see, I originally post this issue on Emacs-help mailing list, Eli let >> me forward this thread to Org mode mailing list. Now I need to forward >> to Emacs-devel mailing list. >> >> In case the background info is missing, link original message here: >> >> https://list.orgmode.org/87mtae2718.fsf@localhost/T/#m35d40f37fdf80f413ddb8d40e3017a6f102651e9 > > Please report this as a bug, with "M-x report-emacs-bug", and please > include there all the details, including the recipe to reproduce the > issue. > > Thanks. -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 10:45 ` [CLOSED] " Christopher M. Miles @ 2022-10-02 11:07 ` Eli Zaretskii 2022-10-02 14:56 ` Christopher M. Miles 0 siblings, 1 reply; 16+ messages in thread From: Eli Zaretskii @ 2022-10-02 11:07 UTC (permalink / raw) To: numbchild; +Cc: yantar92, emacs-devel, emacs-orgmode > From: "Christopher M. Miles" <numbchild@gmail.com> > Cc: numbchild@gmail.com, yantar92@gmail.com, emacs-devel@gnu.org, > emacs-orgmode@gnu.org > Date: Sun, 02 Oct 2022 18:45:41 +0800 > > I hate to rewrite those steps more than 3 times. The problem is, I've read the correspondence on the Org list, and I still don't understand what are the steps needed, that don't require the extra Org package. That is why I( asked for the details: so that the bug tracker could have them clearly and unambiguously. I do want to look into the issue and see if there's anything that needs to be fixed in Emacs. > But I also know Emacs > contributors should not be forced to fix bug for me. Also I can't fix > this bug by myself. So I think it's not a bug, I can tolerate this > center line. Maybe I mastered skill for modify code in Emacs, I might > come back to fix this bug by myself. But now, let me close it. I'm not > hating anybody, just hate this process. Thanks for checking out. I'm sorry you feel like that. Perhaps Ihor or someone else could fill in the blanks and allow us to investigate. Thanks. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 11:07 ` Eli Zaretskii @ 2022-10-02 14:56 ` Christopher M. Miles 0 siblings, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-02 14:56 UTC (permalink / raw) To: Eli Zaretskii; +Cc: numbchild, yantar92, emacs-devel, emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 1668 bytes --] Eli Zaretskii <eliz@gnu.org> writes: >> From: "Christopher M. Miles" <numbchild@gmail.com> >> Cc: numbchild@gmail.com, yantar92@gmail.com, emacs-devel@gnu.org, >> emacs-orgmode@gnu.org >> Date: Sun, 02 Oct 2022 18:45:41 +0800 >> >> I hate to rewrite those steps more than 3 times. > > The problem is, I've read the correspondence on the Org list, and I > still don't understand what are the steps needed, that don't require > the extra Org package. That is why I( asked for the details: so that > the bug tracker could have them clearly and unambiguously. > > I do want to look into the issue and see if there's anything that > needs to be fixed in Emacs. > >> But I also know Emacs >> contributors should not be forced to fix bug for me. Also I can't fix >> this bug by myself. So I think it's not a bug, I can tolerate this >> center line. Maybe I mastered skill for modify code in Emacs, I might >> come back to fix this bug by myself. But now, let me close it. I'm not >> hating anybody, just hate this process. Thanks for checking out. > > I'm sorry you feel like that. Perhaps Ihor or someone else could fill > in the blanks and allow us to investigate. > > Thanks. No, it's my personal character and feeling caused this behavior. Not your fault. I really don't blame anybody. In bellowing Ihor's email wrote the reproduce steps. Thanks very much Ihor. -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
[parent not found: <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com>]
* Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute [not found] ` <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com> @ 2022-10-02 10:57 ` Ihor Radchenko 2022-10-02 11:16 ` Eli Zaretskii 0 siblings, 1 reply; 16+ messages in thread From: Ihor Radchenko @ 2022-10-02 10:57 UTC (permalink / raw) To: numbchild; +Cc: Eli Zaretskii, emacs-devel, emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 870 bytes --] On Sun, Oct 2, 2022 at 6:51 PM Christopher M. Miles <numbchild@gmail.com> wrote: > > I hate to rewrite those steps more than 3 times. But I also know Emacs > contributors should not be forced to fix bug for me. Also I can't fix > this bug by myself. So I think it's not a bug, I can tolerate this > center line. Maybe I mastered skill for modify code in Emacs, I might > come back to fix this bug by myself. But now, let me close it. I'm not > hating anybody, just hate this process. Thanks for checking out. > > Come on. 1. find an image file in your system 2. emacs -Q 3. M-: (erase-buffer) 4. Insert "askdjaklsdj lasasd" 5. M-: (require 'org) 6. M-x font-lock-mode 7. M-: (put-text-property (point-min) (point-max) 'face 'org-link) 8. M-: (put-text-property (point-min) (point-max) 'display (create-image "/path/to/image" nil nil :ascent 'center :max-height 512)) [-- Attachment #2: Type: text/html, Size: 1365 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 10:57 ` Ihor Radchenko @ 2022-10-02 11:16 ` Eli Zaretskii 2022-10-02 11:26 ` Ihor Radchenko 2022-10-19 7:33 ` [SOLVED] " Christopher M. Miles 0 siblings, 2 replies; 16+ messages in thread From: Eli Zaretskii @ 2022-10-02 11:16 UTC (permalink / raw) To: Ihor Radchenko; +Cc: numbchild, emacs-devel, emacs-orgmode > From: Ihor Radchenko <yantar92@gmail.com> > Date: Sun, 2 Oct 2022 18:57:56 +0800 > Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org, emacs-orgmode@gnu.org > > 1. find an image file in your system > 2. emacs -Q > 3. M-: (erase-buffer) > 4. Insert "askdjaklsdj lasasd" > 5. M-: (require 'org) > 6. M-x font-lock-mode > 7. M-: (put-text-property (point-min) (point-max) 'face 'org-link) > 8. M-: (put-text-property (point-min) (point-max) 'display (create-image > "/path/to/image" nil nil :ascent 'center :max-height 512)) Thanks. This is because of the ":ascent 'center" part, isn't it? What would you want Emacs to do instead in this case? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 11:16 ` Eli Zaretskii @ 2022-10-02 11:26 ` Ihor Radchenko 2022-10-19 7:33 ` [SOLVED] " Christopher M. Miles 1 sibling, 0 replies; 16+ messages in thread From: Ihor Radchenko @ 2022-10-02 11:26 UTC (permalink / raw) To: Eli Zaretskii; +Cc: numbchild, emacs-devel, emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 585 bytes --] > > This is because of the ":ascent 'center" part, isn't it? > I guess so. The image bottom is below the text baseline and thus the underline cuts through the image. > What would you want Emacs to do instead in this case? > I do understand how Emacs renders what we get here from the perspective of glyph composition. Putting underline over the glyph does make sense in many cases. However, it is clearly not expected in this specific scenario of a bitmap image. I think that it could be useful to allow images to be drawn "on top" of the underlines, cross-lines, etc. Best, Ihor [-- Attachment #2: Type: text/html, Size: 1038 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* [SOLVED] Re: [CLOSED] text-property displayed image has a center-line when the text face has underline attribute 2022-10-02 11:16 ` Eli Zaretskii 2022-10-02 11:26 ` Ihor Radchenko @ 2022-10-19 7:33 ` Christopher M. Miles 1 sibling, 0 replies; 16+ messages in thread From: Christopher M. Miles @ 2022-10-19 7:33 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Ihor Radchenko, numbchild, emacs-devel, emacs-orgmode [-- Attachment #1: Type: text/plain, Size: 1408 bytes --] Eli Zaretskii <eliz@gnu.org> writes: >> From: Ihor Radchenko <yantar92@gmail.com> >> Date: Sun, 2 Oct 2022 18:57:56 +0800 >> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org, emacs-orgmode@gnu.org >> >> 1. find an image file in your system >> 2. emacs -Q >> 3. M-: (erase-buffer) >> 4. Insert "askdjaklsdj lasasd" >> 5. M-: (require 'org) >> 6. M-x font-lock-mode >> 7. M-: (put-text-property (point-min) (point-max) 'face 'org-link) >> 8. M-: (put-text-property (point-min) (point-max) 'display (create-image >> "/path/to/image" nil nil :ascent 'center :max-height 512)) > > Thanks. > > This is because of the ":ascent 'center" part, isn't it? > > What would you want Emacs to do instead in this case? I checked out the docstring of `create-image' have not found related info about `:ascent'. Today (which is after some days) I review this problem and searched the `:ascent' in emacs info manual, found this property explanation. I set it to `:ascent 100` solved the problem. Now the baseline is at the bottom of image. Thanks a lot for pointing it out which fixed a big issue of my extension code. -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-10-19 7:39 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <m2illt5rzj.fsf@numbchild>
2022-10-01 2:53 ` Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? Christopher M. Miles
[not found] ` <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-01 5:37 ` Ihor Radchenko
2022-10-01 8:55 ` Christopher M. Miles
2022-10-01 8:58 ` Christopher M. Miles
[not found] ` <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-01 10:33 ` Ihor Radchenko
2022-10-01 12:45 ` Christopher M. Miles
[not found] ` <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-02 4:17 ` Ihor Radchenko
2022-10-02 7:03 ` Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute Christopher M. Miles
2022-10-02 7:41 ` Eli Zaretskii
2022-10-02 10:45 ` [CLOSED] " Christopher M. Miles
2022-10-02 11:07 ` Eli Zaretskii
2022-10-02 14:56 ` Christopher M. Miles
[not found] ` <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-02 10:57 ` Ihor Radchenko
2022-10-02 11:16 ` Eli Zaretskii
2022-10-02 11:26 ` Ihor Radchenko
2022-10-19 7:33 ` [SOLVED] " Christopher M. Miles
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).