From: Eli Zaretskii <eliz@gnu.org>
To: numbchild@gmail.com
Cc: yantar92@gmail.com, emacs-devel@gnu.org, emacs-orgmode@gnu.org
Subject: Re: Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute
Date: Sun, 02 Oct 2022 10:41:46 +0300 [thread overview]
Message-ID: <83a66eaczp.fsf@gnu.org> (raw)
In-Reply-To: <m2tu4mwvn0.fsf@numbchild@gmail.com>
> From: "Christopher M. Miles" <numbchild@gmail.com>
> Cc: "Christopher M. Miles" <numbchild@gmail.com>, Org Mode
> <emacs-orgmode@gnu.org>
> Date: Sun, 02 Oct 2022 15:03:26 +0800
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
> > "Christopher M. Miles" <numbchild@gmail.com> writes:
> >
> >> I replaced step 5 with step 6 by extracting the logic code of
> >> org-link-beautify, but I found it does not have center-line. That's
> >> really weird.
> >> ...
> >> (put-text-property
> >> start end
> >> 'display (create-image "~/Downloads/.thumbnails/3veEPJrQrV1EtpH9.png" nil nil :ascent 'center :max-height 512))
> >> (make-local-variable 'image-map)
> >> (define-key image-map (kbd "<mouse-1>") 'org-open-at-point))
> >> #+end_src
> >
> > On my side, the put-text-property does have center-line.
> > But only when buffer is in Org mode.
> > Yet, it is not Org's fault.
> >
> > The reason you are seeing the horizontal line is org-link face.
> > org-link has underline. And the "center" line you are seeing is actually
> > underline coming from the face. I'd say it is emacs bug.
>
> Thanks very much for figuring out this issue, Ihor.
>
> I see, I originally post this issue on Emacs-help mailing list, Eli let
> me forward this thread to Org mode mailing list. Now I need to forward
> to Emacs-devel mailing list.
>
> In case the background info is missing, link original message here:
>
> https://list.orgmode.org/87mtae2718.fsf@localhost/T/#m35d40f37fdf80f413ddb8d40e3017a6f102651e9
Please report this as a bug, with "M-x report-emacs-bug", and please
include there all the details, including the recipe to reproduce the
issue.
Thanks.
next prev parent reply other threads:[~2022-10-02 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2illt5rzj.fsf@numbchild>
2022-10-01 2:53 ` Fwd: [QUESTION] why there is a horizontal line in middle of text-property displayed image? Christopher M. Miles
[not found] ` <6337ac4e.050a0220.c05b9.7747SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-01 5:37 ` Ihor Radchenko
2022-10-01 8:55 ` Christopher M. Miles
2022-10-01 8:58 ` Christopher M. Miles
[not found] ` <63380111.050a0220.592f2.fab7SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-01 10:33 ` Ihor Radchenko
2022-10-01 12:45 ` Christopher M. Miles
[not found] ` <63383737.050a0220.63781.8825SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-02 4:17 ` Ihor Radchenko
2022-10-02 7:03 ` Fwd: [BUG] text-property displayed image has a center-line when the text face has underline attribute Christopher M. Miles
2022-10-02 7:41 ` Eli Zaretskii [this message]
2022-10-02 10:45 ` [CLOSED] " Christopher M. Miles
2022-10-02 11:07 ` Eli Zaretskii
2022-10-02 14:56 ` Christopher M. Miles
[not found] ` <63396d3d.050a0220.d98c9.1ea6SMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-02 10:57 ` Ihor Radchenko
2022-10-02 11:16 ` Eli Zaretskii
2022-10-02 11:26 ` Ihor Radchenko
2022-10-19 7:33 ` [SOLVED] " Christopher M. Miles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a66eaczp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).