* [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?
@ 2009-03-19 17:29 Peter Jones
2009-03-19 18:36 ` Carsten Dominik
2009-03-21 17:21 ` Carsten Dominik
0 siblings, 2 replies; 4+ messages in thread
From: Peter Jones @ 2009-03-19 17:29 UTC (permalink / raw)
To: emacs-orgmode
I'm looking at this code in org-scan-tags (org.el):
(concat
(if org-tags-match-list-sublevels
(make-string (1- level) ?.) "")
(org-get-heading))
Which causes items in my agenda buffer to be prefixed with a series of
periods. I've been looking around org.el, and org-agenda.el, and don't
see any code that relies on those periods being there.
If I remove that if expression, the agenda looks the way I'd expect,
with no noticeable consequences.
Is there any reason the patch below would break something in Org?
diff --git a/lisp/org.el b/lisp/org.el
index dabf306..b19e3d1 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included in the output."
((eq action 'agenda)
(setq txt (org-format-agenda-item
""
- (concat
- (if org-tags-match-list-sublevels
- (make-string (1- level) ?.) "")
- (org-get-heading))
+ (org-get-heading)
category
;(org-get-tags-at)
tags-list
--
Peter Jones, http://pmade.com
pmade inc. Louisville, CO US
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?
2009-03-19 17:29 [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Peter Jones
@ 2009-03-19 18:36 ` Carsten Dominik
2009-03-19 19:29 ` Peter Jones
2009-03-21 17:21 ` Carsten Dominik
1 sibling, 1 reply; 4+ messages in thread
From: Carsten Dominik @ 2009-03-19 18:36 UTC (permalink / raw)
To: Peter Jones; +Cc: emacs-orgmode
Hi Peter,
this is supposed to be a feature, showing that these lines are
sublevels of a line that already matched. I guess we can create a
variable to turn this off - you are right that it has no functionality
otherwise.
- Carsten
P.S. Do you have a copyright assignment, I forgot, but I have the
feeling that I would like to have one ... :-)
On Mar 19, 2009, at 6:29 PM, Peter Jones wrote:
> I'm looking at this code in org-scan-tags (org.el):
>
> (concat
> (if org-tags-match-list-sublevels
> (make-string (1- level) ?.) "")
> (org-get-heading))
>
> Which causes items in my agenda buffer to be prefixed with a series of
> periods. I've been looking around org.el, and org-agenda.el, and
> don't
> see any code that relies on those periods being there.
>
> If I remove that if expression, the agenda looks the way I'd expect,
> with no noticeable consequences.
>
> Is there any reason the patch below would break something in Org?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index dabf306..b19e3d1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included
> in the output."
> ((eq action 'agenda)
> (setq txt (org-format-agenda-item
> ""
> - (concat
> - (if org-tags-match-list-sublevels
> - (make-string (1- level) ?.) "")
> - (org-get-heading))
> + (org-get-heading)
> category
> ;(org-get-tags-at)
> tags-list
>
>
> --
> Peter Jones, http://pmade.com
> pmade inc. Louisville, CO US
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?
2009-03-19 17:29 [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Peter Jones
2009-03-19 18:36 ` Carsten Dominik
@ 2009-03-21 17:21 ` Carsten Dominik
1 sibling, 0 replies; 4+ messages in thread
From: Carsten Dominik @ 2009-03-21 17:21 UTC (permalink / raw)
To: Peter Jones; +Cc: emacs-orgmode
I just pushed the following fix:
commit 1f576643db83156256abda93556e4bc42b9d6b29
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date: Sat Mar 21 13:51:01 2009 +0100
Agenda: No longer indent matching sublevels by dots.
When a tags/property match does match an entry and its sublevels,
the
sublevels used to be indented by dots, to indicate that the matches
likely result from tag inheritance. This is now no longer the
default, but you can get it back with
(setq org-tags-match-list-sublevels 'indented)
On Mar 19, 2009, at 6:29 PM, Peter Jones wrote:
> I'm looking at this code in org-scan-tags (org.el):
>
> (concat
> (if org-tags-match-list-sublevels
> (make-string (1- level) ?.) "")
> (org-get-heading))
>
> Which causes items in my agenda buffer to be prefixed with a series of
> periods. I've been looking around org.el, and org-agenda.el, and
> don't
> see any code that relies on those periods being there.
>
> If I remove that if expression, the agenda looks the way I'd expect,
> with no noticeable consequences.
>
> Is there any reason the patch below would break something in Org?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index dabf306..b19e3d1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included
> in the output."
> ((eq action 'agenda)
> (setq txt (org-format-agenda-item
> ""
> - (concat
> - (if org-tags-match-list-sublevels
> - (make-string (1- level) ?.) "")
> - (org-get-heading))
> + (org-get-heading)
> category
> ;(org-get-tags-at)
> tags-list
>
>
> --
> Peter Jones, http://pmade.com
> pmade inc. Louisville, CO US
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-03-21 19:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19 17:29 [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Peter Jones
2009-03-19 18:36 ` Carsten Dominik
2009-03-19 19:29 ` Peter Jones
2009-03-21 17:21 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).