emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <dominik@science.uva.nl>
To: Peter Jones <mlists@pmade.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?
Date: Thu, 19 Mar 2009 19:36:12 +0100	[thread overview]
Message-ID: <9D4F1DE8-774E-4441-B358-57142DB939B8@uva.nl> (raw)
In-Reply-To: <m2ljr1l8v1.fsf@pmade.com>


Hi Peter,

this is supposed to be a feature, showing that these lines are  
sublevels of a line that already matched.  I guess we can create a  
variable to turn this off - you are right that it has no functionality  
otherwise.

- Carsten

P.S. Do you have a copyright assignment, I forgot, but I have the  
feeling that I would like to have one ... :-)

On Mar 19, 2009, at 6:29 PM, Peter Jones wrote:

> I'm looking at this code in org-scan-tags (org.el):
>
> (concat
> (if org-tags-match-list-sublevels
>     (make-string (1- level) ?.) "")
> (org-get-heading))
>
> Which causes items in my agenda buffer to be prefixed with a series of
> periods.  I've been looking around org.el, and org-agenda.el, and  
> don't
> see any code that relies on those periods being there.
>
> If I remove that if expression, the agenda looks the way I'd expect,
> with no noticeable consequences.
>
> Is there any reason the patch below would break something in Org?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index dabf306..b19e3d1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included  
> in the output."
> 	     ((eq action 'agenda)
> 	      (setq txt (org-format-agenda-item
> 			 ""
> -			 (concat
> -			  (if org-tags-match-list-sublevels
> -			      (make-string (1- level) ?.) "")
> -			  (org-get-heading))
> +                         (org-get-heading)
> 			 category
> 			 ;(org-get-tags-at)
> 			 tags-list
>
>
> -- 
> Peter Jones, http://pmade.com
> pmade inc.  Louisville, CO US
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2009-03-19 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 17:29 [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Peter Jones
2009-03-19 18:36 ` Carsten Dominik [this message]
2009-03-19 19:29   ` Peter Jones
2009-03-21 17:21 ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9D4F1DE8-774E-4441-B358-57142DB939B8@uva.nl \
    --to=dominik@science.uva.nl \
    --cc=emacs-orgmode@gnu.org \
    --cc=mlists@pmade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).