From: Carsten Dominik <dominik@science.uva.nl>
To: Peter Jones <mlists@pmade.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?
Date: Sat, 21 Mar 2009 18:21:31 +0100 [thread overview]
Message-ID: <A1D76B1B-C6E2-4A83-B07C-7F81F845C35D@uva.nl> (raw)
In-Reply-To: <m2ljr1l8v1.fsf@pmade.com>
I just pushed the following fix:
commit 1f576643db83156256abda93556e4bc42b9d6b29
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date: Sat Mar 21 13:51:01 2009 +0100
Agenda: No longer indent matching sublevels by dots.
When a tags/property match does match an entry and its sublevels,
the
sublevels used to be indented by dots, to indicate that the matches
likely result from tag inheritance. This is now no longer the
default, but you can get it back with
(setq org-tags-match-list-sublevels 'indented)
On Mar 19, 2009, at 6:29 PM, Peter Jones wrote:
> I'm looking at this code in org-scan-tags (org.el):
>
> (concat
> (if org-tags-match-list-sublevels
> (make-string (1- level) ?.) "")
> (org-get-heading))
>
> Which causes items in my agenda buffer to be prefixed with a series of
> periods. I've been looking around org.el, and org-agenda.el, and
> don't
> see any code that relies on those periods being there.
>
> If I remove that if expression, the agenda looks the way I'd expect,
> with no noticeable consequences.
>
> Is there any reason the patch below would break something in Org?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index dabf306..b19e3d1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included
> in the output."
> ((eq action 'agenda)
> (setq txt (org-format-agenda-item
> ""
> - (concat
> - (if org-tags-match-list-sublevels
> - (make-string (1- level) ?.) "")
> - (org-get-heading))
> + (org-get-heading)
> category
> ;(org-get-tags-at)
> tags-list
>
>
> --
> Peter Jones, http://pmade.com
> pmade inc. Louisville, CO US
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2009-03-21 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 17:29 [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Peter Jones
2009-03-19 18:36 ` Carsten Dominik
2009-03-19 19:29 ` Peter Jones
2009-03-21 17:21 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A1D76B1B-C6E2-4A83-B07C-7F81F845C35D@uva.nl \
--to=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=mlists@pmade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).