From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why? Date: Sat, 21 Mar 2009 18:21:31 +0100 Message-ID: References: Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ll7M2-0007gq-7z for emacs-orgmode@gnu.org; Sat, 21 Mar 2009 15:59:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ll7Lx-0007dM-2H for emacs-orgmode@gnu.org; Sat, 21 Mar 2009 15:59:36 -0400 Received: from [199.232.76.173] (port=41366 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ll7Lw-0007dA-GT for emacs-orgmode@gnu.org; Sat, 21 Mar 2009 15:59:32 -0400 Received: from ey-out-1920.google.com ([74.125.78.148]:6947) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ll7Lv-0000eQ-L5 for emacs-orgmode@gnu.org; Sat, 21 Mar 2009 15:59:32 -0400 Received: by ey-out-1920.google.com with SMTP id 13so217120eye.24 for ; Sat, 21 Mar 2009 12:59:30 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Peter Jones Cc: emacs-orgmode@gnu.org I just pushed the following fix: commit 1f576643db83156256abda93556e4bc42b9d6b29 Author: Carsten Dominik Date: Sat Mar 21 13:51:01 2009 +0100 Agenda: No longer indent matching sublevels by dots. When a tags/property match does match an entry and its sublevels, the sublevels used to be indented by dots, to indicate that the matches likely result from tag inheritance. This is now no longer the default, but you can get it back with (setq org-tags-match-list-sublevels 'indented) On Mar 19, 2009, at 6:29 PM, Peter Jones wrote: > I'm looking at this code in org-scan-tags (org.el): > > (concat > (if org-tags-match-list-sublevels > (make-string (1- level) ?.) "") > (org-get-heading)) > > Which causes items in my agenda buffer to be prefixed with a series of > periods. I've been looking around org.el, and org-agenda.el, and > don't > see any code that relies on those periods being there. > > If I remove that if expression, the agenda looks the way I'd expect, > with no noticeable consequences. > > Is there any reason the patch below would break something in Org? > > diff --git a/lisp/org.el b/lisp/org.el > index dabf306..b19e3d1 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included > in the output." > ((eq action 'agenda) > (setq txt (org-format-agenda-item > "" > - (concat > - (if org-tags-match-list-sublevels > - (make-string (1- level) ?.) "") > - (org-get-heading)) > + (org-get-heading) > category > ;(org-get-tags-at) > tags-list > > > -- > Peter Jones, http://pmade.com > pmade inc. Louisville, CO US > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode