emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [Babel] Patch for "Evaluation aborted"
@ 2010-11-24  9:41 Sébastien Vauban
  2010-11-25 17:30 ` Eric Schulte
  0 siblings, 1 reply; 2+ messages in thread
From: Sébastien Vauban @ 2010-11-24  9:41 UTC (permalink / raw)
  To: emacs-orgmode-mXXj517/zsQ

Hi Eric and Dan,

I was puzzled this morning by a message "evalution aborted" without any extra
info. "Aborted" made me think there was an error, so I toggle debug-on-error,
but it did not give me any more insight on the problem.

After searching for the message in the code base, I found it in =ob.el= and
understood it was when eval was disabled (set to =no= or =never=).

In this case, I would ask for a clearer message:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/ob.el b/lisp/ob.el
index 584d627..5bb0d5c 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -219,7 +219,7 @@ of potentially harmful code."
 		 (not (yes-or-no-p
 		       (format "Evaluate this%scode on your system? "
 			       (if info (format " %s " (nth 0 info)) " "))))))
-	(prog1 nil (message "evaluation aborted"))
+	(prog1 nil (message "Evaluation disabled by user (option)."))
--8<---------------cut here---------------end--------------->8---

Feel free to change it to something better, but, in any case, I'd prefer
"disabled" over "aborted". At least in my mind, "disabled" is not related to
"error", while "aborted" is (in my mind, or in my Frenglish).

Best regards,

Sébastien Vauban

Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-25 17:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-24  9:41 [Babel] Patch for "Evaluation aborted" Sébastien Vauban
2010-11-25 17:30 ` Eric Schulte

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).