From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: [Babel] Patch for "Evaluation aborted"
Date: Thu, 25 Nov 2010 10:30:09 -0700
Message-ID: <87aakx1fby.fsf@gmail.com>
References: <80lj4jkqio.fsf@missioncriticalit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=36958 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLfeD-00013k-W2
	for emacs-orgmode@gnu.org; Thu, 25 Nov 2010 12:30:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PLfeC-0004GV-Eo
	for emacs-orgmode@gnu.org; Thu, 25 Nov 2010 12:30:17 -0500
Received: from mail-pv0-f169.google.com ([74.125.83.169]:54085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PLfeC-0004GH-9v
	for emacs-orgmode@gnu.org; Thu, 25 Nov 2010 12:30:16 -0500
Received: by pvc30 with SMTP id 30so1329177pvc.0
	for <emacs-orgmode@gnu.org>; Thu, 25 Nov 2010 09:30:15 -0800 (PST)
In-Reply-To: <80lj4jkqio.fsf@missioncriticalit.com> (=?utf-8?Q?=22S=C3=A9b?=
	=?utf-8?Q?astien?= Vauban"'s
	message of "Wed, 24 Nov 2010 10:41:19 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?utf-8?Q?S=C3=A9bastien?= Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org

Hi Seb,

Nice idea, I've just pushed up a patch which improves this message.

Best -- Eric

S=C3=A9bastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

> Hi Eric and Dan,
>
> I was puzzled this morning by a message "evalution aborted" without any e=
xtra
> info. "Aborted" made me think there was an error, so I toggle debug-on-er=
ror,
> but it did not give me any more insight on the problem.
>
> After searching for the message in the code base, I found it in =3Dob.el=
=3D and
> understood it was when eval was disabled (set to =3Dno=3D or =3Dnever=3D).
>
> In this case, I would ask for a clearer message:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 584d627..5bb0d5c 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -219,7 +219,7 @@ of potentially harmful code."
>  		 (not (yes-or-no-p
>  		       (format "Evaluate this%scode on your system? "
>  			       (if info (format " %s " (nth 0 info)) " "))))))
> -	(prog1 nil (message "evaluation aborted"))
> +	(prog1 nil (message "Evaluation disabled by user (option)."))
>        t)))
>=20=20
>  ;;;###autoload
>
> Feel free to change it to something better, but, in any case, I'd prefer
> "disabled" over "aborted". At least in my mind, "disabled" is not related=
 to
> "error", while "aborted" is (in my mind, or in my Frenglish).
>
> Best regards,
>   Seb