From: "Eric Schulte" <schulte.eric@gmail.com>
To: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Babel] Patch for "Evaluation aborted"
Date: Thu, 25 Nov 2010 10:30:09 -0700 [thread overview]
Message-ID: <87aakx1fby.fsf@gmail.com> (raw)
In-Reply-To: <80lj4jkqio.fsf@missioncriticalit.com> ("Sébastien Vauban"'s message of "Wed, 24 Nov 2010 10:41:19 +0100")
Hi Seb,
Nice idea, I've just pushed up a patch which improves this message.
Best -- Eric
Sébastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:
> Hi Eric and Dan,
>
> I was puzzled this morning by a message "evalution aborted" without any extra
> info. "Aborted" made me think there was an error, so I toggle debug-on-error,
> but it did not give me any more insight on the problem.
>
> After searching for the message in the code base, I found it in =ob.el= and
> understood it was when eval was disabled (set to =no= or =never=).
>
> In this case, I would ask for a clearer message:
>
> diff --git a/lisp/ob.el b/lisp/ob.el
> index 584d627..5bb0d5c 100644
> --- a/lisp/ob.el
> +++ b/lisp/ob.el
> @@ -219,7 +219,7 @@ of potentially harmful code."
> (not (yes-or-no-p
> (format "Evaluate this%scode on your system? "
> (if info (format " %s " (nth 0 info)) " "))))))
> - (prog1 nil (message "evaluation aborted"))
> + (prog1 nil (message "Evaluation disabled by user (option)."))
> t)))
>
> ;;;###autoload
>
> Feel free to change it to something better, but, in any case, I'd prefer
> "disabled" over "aborted". At least in my mind, "disabled" is not related to
> "error", while "aborted" is (in my mind, or in my Frenglish).
>
> Best regards,
> Seb
prev parent reply other threads:[~2010-11-25 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 9:41 [Babel] Patch for "Evaluation aborted" Sébastien Vauban
2010-11-25 17:30 ` Eric Schulte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aakx1fby.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=wxhgmqzgwmuf@spammotel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).