emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sébastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: [Babel] Patch for "Evaluation aborted"
Date: Wed, 24 Nov 2010 10:41:19 +0100	[thread overview]
Message-ID: <80lj4jkqio.fsf@missioncriticalit.com> (raw)

Hi Eric and Dan,

I was puzzled this morning by a message "evalution aborted" without any extra
info. "Aborted" made me think there was an error, so I toggle debug-on-error,
but it did not give me any more insight on the problem.

After searching for the message in the code base, I found it in =ob.el= and
understood it was when eval was disabled (set to =no= or =never=).

In this case, I would ask for a clearer message:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/ob.el b/lisp/ob.el
index 584d627..5bb0d5c 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -219,7 +219,7 @@ of potentially harmful code."
 		 (not (yes-or-no-p
 		       (format "Evaluate this%scode on your system? "
 			       (if info (format " %s " (nth 0 info)) " "))))))
-	(prog1 nil (message "evaluation aborted"))
+	(prog1 nil (message "Evaluation disabled by user (option)."))
--8<---------------cut here---------------end--------------->8---

Feel free to change it to something better, but, in any case, I'd prefer
"disabled" over "aborted". At least in my mind, "disabled" is not related to
"error", while "aborted" is (in my mind, or in my Frenglish).

Best regards,

Sébastien Vauban

Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.

             reply	other threads:[~2010-11-24  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24  9:41 Sébastien Vauban [this message]
2010-11-25 17:30 ` [Babel] Patch for "Evaluation aborted" Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80lj4jkqio.fsf@missioncriticalit.com \
    --to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).