From: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
To: nicholas.dokos@hp.com
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags
Date: Fri, 16 Mar 2012 10:20:04 -0400 [thread overview]
Message-ID: <4F634C14.7080404@alum.mit.edu> (raw)
In-Reply-To: <4695.1331878200@alphaville>
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
On 3/16/2012 2:10 AM, Nick Dokos wrote:
> One more thing that you'll need to do is put your patches in attachments
> of a type that will allow patchwork to snag the patch:
And here is the org-clock.el patch again.
[-- Attachment #2: 0003-Clocking-work-time-faster-filtering-of-clock-entries.patch --]
[-- Type: text/plain, Size: 1108 bytes --]
From 4f7f91ae62d425f7a89738b28006b1743a6bea4d Mon Sep 17 00:00:00 2001
From: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
Date: Fri, 16 Mar 2012 00:25:18 -0400
Subject: [PATCH 3/3] Clocking work time: faster filtering of clock entries by
trusting org-scanner-tags
* lisp/org-clock.el (org-clock-get-table-data): Bind org-scanner-tags
to tags-list and org-trust-scanner-tags to t
while evaluating the matcher, since the matcher is always evaluated
at the current entry.
TINYCHANGE
---
lisp/org-clock.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 9206608..46d9af8 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2463,7 +2463,9 @@ TIME: The sum of all time spend in this tree, in minutes. This time
(org-clock-sum ts te
(unless (null matcher)
(lambda ()
- (let ((tags-list (org-get-tags-at)))
+ (let* ((tags-list (org-get-tags-at))
+ (org-scanner-tags tags-list)
+ (org-trust-scanner-tags t))
(eval matcher)))))
(goto-char (point-min))
(setq st t)
--
1.7.9.3
next prev parent reply other threads:[~2012-03-16 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter
2012-03-16 3:13 ` Nick Dokos
2012-03-16 4:31 ` Ilya Shlyakhter
2012-03-16 4:34 ` Ilya Shlyakhter
2012-03-16 10:35 ` Carsten Dominik
2012-03-16 14:25 ` Nick Dokos
2012-03-16 6:10 ` Nick Dokos
2012-03-16 14:13 ` Ilya Shlyakhter
2012-03-16 16:31 ` Carsten Dominik
2012-03-16 14:20 ` Ilya Shlyakhter [this message]
2012-03-16 16:35 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F634C14.7080404@alum.mit.edu \
--to=ilya_shl@alum.mit.edu \
--cc=emacs-orgmode@gnu.org \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).