emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
Cc: nicholas.dokos@hp.com, emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags
Date: Thu, 15 Mar 2012 23:13:03 -0400	[thread overview]
Message-ID: <3953.1331867583@alphaville> (raw)
In-Reply-To: Message from Ilya Shlyakhter <ilya_shl@alum.mit.edu> of "Thu, 15 Mar 2012 19:16:06 EDT." <CACfYvRY6HZYde9gmQTuVefOh8RObGzOZ_DY+HjSOPWTLX9oPyA@mail.gmail.com>

Ilya Shlyakhter <ilya_shl@alum.mit.edu> wrote:

> The attached patch speeds up tags matching ( 50s --> 5s for my most
> common search ), by turning on org-trust-scanner-tags within the
> matcher.
> 
> (When it's off, getting a non-inherited property's value causes a call
> to org-entry-properties to fetch all properties into a cache,
> including ALLTAGS; fetching ALLTAGS involves calling
> (org-get-tags-at), which is slow when org-trust-scanner-tags is off.)
> 
> Can this cause problems / was this off for a reason?
> 

I haven't looked at your patch carefully enough to know if it will or
will not cause problems, but check the doc for org-map-entries: it has
some guidelines about where the technique can be used and where it
cannot:

,----
| If your function needs to retrieve the tags including inherited tags
| at the *current* entry, you can use the value of the variable
| `org-scanner-tags' which will be much faster than getting the value
| with `org-get-tags-at'.  If your function gets properties with
| `org-entry-properties' at the *current* entry, bind `org-trust-scanner-tags'
| to t around the call to `org-entry-properties' to get the same speedup.
| Note that if your function moves around to retrieve tags and properties at
| a *different* entry, you cannot use these techniques.
`----


There are warnings that this variable is for internal dynamical scoping only,
so I suspect you should not mess with the default. If your search can make
the needed guarantees, then you can just wrap it in a let to get the speedup.
Otherwise, it probably should be left alone.

Nick

  reply	other threads:[~2012-03-16  3:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter
2012-03-16  3:13 ` Nick Dokos [this message]
2012-03-16  4:31   ` Ilya Shlyakhter
2012-03-16  4:34     ` Ilya Shlyakhter
2012-03-16 10:35       ` Carsten Dominik
2012-03-16 14:25         ` Nick Dokos
2012-03-16  6:10     ` Nick Dokos
2012-03-16 14:13       ` Ilya Shlyakhter
2012-03-16 16:31         ` Carsten Dominik
2012-03-16 14:20       ` Ilya Shlyakhter
2012-03-16 16:35         ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3953.1331867583@alphaville \
    --to=nicholas.dokos@hp.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ilya_shl@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).