From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Shlyakhter Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags Date: Fri, 16 Mar 2012 10:20:04 -0400 Message-ID: <4F634C14.7080404@alum.mit.edu> References: <3953.1331867583@alphaville> <4695.1331878200@alphaville> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040800080201040000000005" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Y0z-0003Ci-0S for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:20:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8Y0s-0000C0-OP for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:20:20 -0400 Received: from mail-gy0-f169.google.com ([209.85.160.169]:63848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Y0s-0000Bb-HL for emacs-orgmode@gnu.org; Fri, 16 Mar 2012 10:20:14 -0400 Received: by ghrr18 with SMTP id r18so5024487ghr.0 for ; Fri, 16 Mar 2012 07:20:12 -0700 (PDT) In-Reply-To: <4695.1331878200@alphaville> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode This is a multi-part message in MIME format. --------------040800080201040000000005 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 3/16/2012 2:10 AM, Nick Dokos wrote: > One more thing that you'll need to do is put your patches in attachments > of a type that will allow patchwork to snag the patch: And here is the org-clock.el patch again. --------------040800080201040000000005 Content-Type: text/plain; name="0003-Clocking-work-time-faster-filtering-of-clock-entries.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0003-Clocking-work-time-faster-filtering-of-clock-entries.pa"; filename*1="tch" >From 4f7f91ae62d425f7a89738b28006b1743a6bea4d Mon Sep 17 00:00:00 2001 From: Ilya Shlyakhter Date: Fri, 16 Mar 2012 00:25:18 -0400 Subject: [PATCH 3/3] Clocking work time: faster filtering of clock entries by trusting org-scanner-tags * lisp/org-clock.el (org-clock-get-table-data): Bind org-scanner-tags to tags-list and org-trust-scanner-tags to t while evaluating the matcher, since the matcher is always evaluated at the current entry. TINYCHANGE --- lisp/org-clock.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 9206608..46d9af8 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2463,7 +2463,9 @@ TIME: The sum of all time spend in this tree, in minutes. This time (org-clock-sum ts te (unless (null matcher) (lambda () - (let ((tags-list (org-get-tags-at))) + (let* ((tags-list (org-get-tags-at)) + (org-scanner-tags tags-list) + (org-trust-scanner-tags t)) (eval matcher))))) (goto-char (point-min)) (setq st t) -- 1.7.9.3 --------------040800080201040000000005--