From: Nick Dokos <nicholas.dokos@hp.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Ilya Shlyakhter <ilya_shl@alum.mit.edu>,
emacs-orgmode <emacs-orgmode@gnu.org>,
nicholas.dokos@hp.com
Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags
Date: Fri, 16 Mar 2012 10:25:36 -0400 [thread overview]
Message-ID: <6857.1331907936@alphaville> (raw)
In-Reply-To: Message from Carsten Dominik <carsten.dominik@gmail.com> of "Fri, 16 Mar 2012 11:35:47 BST." <20695543-EDFE-417B-9EF6-63C54EC086D7@gmail.com>
Carsten Dominik <carsten.dominik@gmail.com> wrote:
> Hi Ilya, hi Nick,
>
> thanks for looking into this. I am amazed by the deep
> understanding of Org's internals that shows in this
> thread.
>
On Ilya's part, certainly - for my part, I have only the vaguest clue
about what Ilya did - I just saw a possible red flag. I still have not
looked into his patches, but now, thanks to you, I don't have to :-)
I can just enjoy the speedup!
Nick
> Both patches seem to be OK as far as I can see and
> can be applied without adverse effects.
> The patch for org-clock.el will at most achieve a factor
> of two (because org-get-tags-at is called anyway), but
> indeed, the patch in org.el can potentially have even
> more significant effects, when properties are tested
> in the matcher.
>
> Cheers and thanks!
>
> - Carsten
next prev parent reply other threads:[~2012-03-16 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter
2012-03-16 3:13 ` Nick Dokos
2012-03-16 4:31 ` Ilya Shlyakhter
2012-03-16 4:34 ` Ilya Shlyakhter
2012-03-16 10:35 ` Carsten Dominik
2012-03-16 14:25 ` Nick Dokos [this message]
2012-03-16 6:10 ` Nick Dokos
2012-03-16 14:13 ` Ilya Shlyakhter
2012-03-16 16:31 ` Carsten Dominik
2012-03-16 14:20 ` Ilya Shlyakhter
2012-03-16 16:35 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6857.1331907936@alphaville \
--to=nicholas.dokos@hp.com \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=ilya_shl@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).