emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] tags search: faster tags matcher by trusting scanner tags
Date: Fri, 16 Mar 2012 10:13:08 -0400	[thread overview]
Message-ID: <4F634A74.6010806@alum.mit.edu> (raw)
In-Reply-To: <4695.1331878200@alphaville>

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

On 3/16/2012 2:10 AM, Nick Dokos wrote:
 > One more thing that you'll need to do is put your patches in attachments
 > of a type that will allow patchwork to snag the patch:

Thanks, I was wondering why they're not showing up.
Here is another try (attached) for the org.el patch.

ilya

[-- Attachment #2: 0002-Tags-properties-matcher-faster-matching-by-trusting-.patch --]
[-- Type: text/plain, Size: 1043 bytes --]

From 95c38b06803aec0787bc2eaab3d0062221390292 Mon Sep 17 00:00:00 2001
From: Ilya Shlyakhter <ilya_shl@alum.mit.edu>
Date: Fri, 16 Mar 2012 00:10:25 -0400
Subject: [PATCH 2/2] Tags/properties matcher: faster matching by trusting
 org-scanner-tags

* lisp/org.el (org-scan-tags): Bind org-trust-scanner-tags to t
while evaluating the matcher, since the matcher is always evaluated
at the current entry.

TINYCHANGE
---
 lisp/org.el |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index ad63213..951f692 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12906,7 +12906,8 @@ headlines matching this string."
 
 		 ;; eval matcher only when the todo condition is OK
 		 (and (or (not todo-only) (member todo org-not-done-keywords))
-		      (let ((case-fold-search t)) (eval matcher)))
+		      (let ((case-fold-search t) (org-trust-scanner-tags t))
+			   (eval matcher)))
 
 		 ;; Call the skipper, but return t if it does not skip,
 		 ;; so that the `and' form continues evaluating
-- 
1.7.9.3

next prev parent reply	other threads:[~2012-03-16 14:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 23:16 [PATCH] tags search: faster tags matcher by trusting scanner tags Ilya Shlyakhter
2012-03-16  3:13 ` Nick Dokos
2012-03-16  4:31   ` Ilya Shlyakhter
2012-03-16  4:34     ` Ilya Shlyakhter
2012-03-16 10:35       ` Carsten Dominik
2012-03-16 14:25         ` Nick Dokos
2012-03-16  6:10     ` Nick Dokos
2012-03-16 14:13       ` Ilya Shlyakhter [this message]
2012-03-16 16:31         ` Carsten Dominik
2012-03-16 14:20       ` Ilya Shlyakhter
2012-03-16 16:35         ` Carsten Dominik

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:ad63213 dfblob:951f692
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F634A74.6010806@alum.mit.edu \
    --to=ilya_shl@alum.mit.edu \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).