From: Jon Snader <jsnader@mac.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 20 Dec 2014 13:40:29 -0500 [thread overview]
Message-ID: <130E330E-9A74-40DB-AAF1-B5368996CD2B@mac.com> (raw)
In-Reply-To: <87vbl6zg7f.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 1104 bytes --]
> On Dec 20, 2014, at 6:57 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> + extractfun comparefun tempfun extract-string-p)
>
> EXTRACT-STRING-P, and possibly TEMPFUN, are bound too early. See below.
I moved EXTRACT-STRING-P to a lower let but TEMPFUN has to be available to the call to sort so I left it in the outer let.
> I suggest something like
>
> (let* ((tempfun (or getkey-func
> (intern ...)))
> (extract-string-p (stringp (funcall tempfun (caar table)))))
> (setq extractfun (if (and extract-string-p (not with-case))
> `(lambda (x) (downcase (funcall ',tempfun x)))
> tempfun))
> (setq comparefun
> (cond (compare-func)
> (extract-string-p (if (= sorting-type ?f) #'string< #'org-string>))
> ((= sorting-type ?f) #'<)
> (t #'>))))
I followed this suggestion modulo leaving TEMPFUN in the outer let.
Thanks for your suggestions.
The attached patch was against the latest master branch at the time I generated it.
[-- Attachment #1.2.1: Type: text/html, Size: 12374 bytes --]
[-- Attachment #1.2.2: 0001-org.el-Implement-user-defined-table-sorting.patch --]
[-- Type: application/octet-stream, Size: 6857 bytes --]
From 9d526679cd958b46605c60d092062cf6db441cb3 Mon Sep 17 00:00:00 2001
From: Jon Snader <jcs@manfredII.local>
Date: Sat, 20 Dec 2014 13:13:17 -0500
Subject: [PATCH] org.el: Implement user-defined table sorting
* lisp/org.el (org-do-sort): Implement the ?f and ?F sorting options
to allow user-defined table sorting. Update the DOC string.
* lisp/org-table (org-table-sort-lines): Add the GETKEY-FUNC and
COMPARE-FUNC optional parameters and pass them to the call to
`org-do-sort'. Update the DOC string.
* doc/org.texi (org-table-sort-lines): Update documentation to reflect
the addition of the ?f and ?F options.
This patch implements user-defined extraction and comparison functions
for table sorting. Thanks to Nicolas Goaziou for helpful suggestions.
This patch was discussed on the Org Mode mailing list:
http://article.gmane.org/gmane.emacs.orgmode/93334
---
doc/org.texi | 6 ++++--
lisp/org-table.el | 15 +++++++++++----
lisp/org.el | 35 +++++++++++++++++++++++++++++------
3 files changed, 44 insertions(+), 12 deletions(-)
diff --git a/doc/org.texi b/doc/org.texi
index 7c464ca..33a6a0d 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -2205,8 +2205,10 @@ point is before the first column, you will be prompted for the sorting
column. If there is an active region, the mark specifies the first line
and the sorting column, while point should be in the last line to be
included into the sorting. The command prompts for the sorting type
-(alphabetically, numerically, or by time). When called with a prefix
-argument, alphabetic sorting will be case-sensitive.
+(alphabetically, numerically, or by time). You can sort in normal or
+reverse order. You can also supply your own key extraction and comparison
+functions. When called with a prefix argument, alphabetic sorting will be
+case-sensitive.
@tsubheading{Regions}
@orgcmd{C-c C-x M-w,org-table-copy-region}
diff --git a/lisp/org-table.el b/lisp/org-table.el
index fa59113..9941160 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -1657,7 +1657,7 @@ In particular, this does handle wide and invisible characters."
dline -1 dline))))
;;;###autoload
-(defun org-table-sort-lines (with-case &optional sorting-type)
+(defun org-table-sort-lines (with-case &optional sorting-type getkey-func compare-func)
"Sort table lines according to the column at point.
The position of point indicates the column to be used for
@@ -1677,8 +1677,15 @@ With prefix argument WITH-CASE, alphabetic sorting will be case-sensitive.
If SORTING-TYPE is specified when this function is called from a Lisp
program, no prompting will take place. SORTING-TYPE must be a character,
-any of (?a ?A ?n ?N ?t ?T) where the capital letter indicate that sorting
-should be done in reverse order."
+any of (?a ?A ?n ?N ?t ?T ?f ?F) where the capital letters indicate that
+sorting should be done in reverse order.
+
+If the SORTING-TYPE is ?f or ?F, then GETKEY-FUNC specifies
+a function to be called to extract the key. It must return either
+a string or a number that should serve as the sorting key for that
+row. It will then use COMPARE-FUNC to compare entries. If GETKEY-FUNC
+is specified interactively, the comparison will be either a string or
+numeric compare based on the type of the first key in the table."
(interactive "P")
(let* ((thisline (org-current-line))
(thiscol (org-table-current-column))
@@ -1730,7 +1737,7 @@ should be done in reverse order."
(org-split-string x "[ \t]*|[ \t]*")))
x))
(org-split-string (buffer-substring beg end) "\n")))
- (setq lns (org-do-sort lns "Table" with-case sorting-type))
+ (setq lns (org-do-sort lns "Table" with-case sorting-type getkey-func compare-func))
(when org-table-overlay-coordinates
(org-table-toggle-coordinate-overlays))
(delete-region beg end)
diff --git a/lisp/org.el b/lisp/org.el
index 1383d76..29439d2 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9057,21 +9057,27 @@ When sorting is done, call `org-after-sorting-entries-or-items-hook'."
(move-marker org-clock-marker (point))))
(message "Sorting entries...done")))
-(defun org-do-sort (table what &optional with-case sorting-type)
+(defun org-do-sort (table what &optional with-case sorting-type getkey-func compare-func)
"Sort TABLE of WHAT according to SORTING-TYPE.
The user will be prompted for the SORTING-TYPE if the call to this
function does not specify it.
WHAT is only for the prompt, to indicate what is being sorted.
The sorting key will be extracted from the car of the elements of
-the table.
-If WITH-CASE is non-nil, the sorting will be case-sensitive."
+the table. If WITH-CASE is non-nil, the sorting will be case-sensitive.
+
+If the SORTING-TYPE is ?f or ?F, then GETKEY-FUNC specifies
+a function to be called to extract the key. It must return either
+a string or a number that should serve as the sorting key for that
+row. It will then use COMPARE-FUNC to compare entries. If GETKEY-FUNC
+is specified interactively, the comparison will be either a string or
+numeric compare based on the type of the first key in the table."
(unless sorting-type
(message
- "Sort %s: [a]lphabetic, [n]umeric, [t]ime. A/N/T means reversed:"
+ "Sort %s: [a]lphabetic, [n]umeric, [t]ime, [f]unc. A/N/T/F means reversed:"
what)
(setq sorting-type (read-char-exclusive)))
(let ((dcst (downcase sorting-type))
- extractfun comparefun)
+ extractfun comparefun tempfun)
;; Define the appropriate functions
(cond
((= dcst ?n)
@@ -9095,13 +9101,30 @@ If WITH-CASE is non-nil, the sorting will be case-sensitive."
(org-hh:mm-string-to-minutes x))
(t 0)))
comparefun (if (= dcst sorting-type) '< '>)))
+ ((= dcst ?f)
+ (setq tempfun (or getkey-func
+ (intern (org-icompleting-read
+ "Sort using function: "
+ obarray #'fboundp t nil nil))))
+ (let* ((extract-string-p (stringp (funcall tempfun (caar table)))))
+ (setq extractfun (if (and extract-string-p (not with-case))
+ (lambda (x) (downcase (funcall tempfun x)))
+ tempfun))
+ (setq comparefun (cond (compare-func)
+ (extract-string-p
+ (if (= sorting-type ?f)
+ #'string<
+ #'org-string>))
+ (t ;numeric
+ (if (= sorting-type ?f)
+ #'<
+ #'>))))))
(t (error "Invalid sorting type `%c'" sorting-type)))
(sort (mapcar (lambda (x) (cons (funcall extractfun (car x)) (cdr x)))
table)
(lambda (a b) (funcall comparefun (car a) (car b))))))
-
;;; The orgstruct minor mode
;; Define a minor mode which can be used in other modes in order to
--
1.9.3 (Apple Git-50)
[-- Attachment #1.2.3: Type: text/html, Size: 237 bytes --]
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 841 bytes --]
next prev parent reply other threads:[~2014-12-20 18:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19 ` Jon Snader
2014-12-13 14:29 ` Nicolas Goaziou
2014-12-13 15:19 ` Jon Snader
2014-12-13 16:01 ` Nicolas Goaziou
2014-12-13 18:47 ` Jon Snader
2014-12-13 22:07 ` Nicolas Goaziou
2014-12-13 22:37 ` Jon Snader
2014-12-14 11:25 ` Nicolas Goaziou
2014-12-14 15:19 ` Jon Snader
2014-12-14 17:18 ` Nicolas Goaziou
2014-12-17 17:31 ` Jon Snader
2014-12-20 11:57 ` Nicolas Goaziou
2014-12-20 18:40 ` Jon Snader [this message]
2014-12-20 20:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130E330E-9A74-40DB-AAF1-B5368996CD2B@mac.com \
--to=jsnader@mac.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).