emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jon Snader <jsnader@mac.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 13 Dec 2014 15:29:31 +0100	[thread overview]
Message-ID: <87tx0z8vxw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <E61B599E-BF19-4DD7-98CF-A8BE8897024B@mac.com> (Jon Snader's message of "Sat, 13 Dec 2014 09:19:05 -0500")

Jon Snader <jsnader@mac.com> writes:

> My idea for making it table driven is to add an alist whose elements look something like
>
> (prompt-char prompt extraction-function compare-function reverse-compare-function with-case-extraction-function)
>
> The alist would be initialized with the built-in options (including
> the IP address sort) but a user could call add-to-list to add a custom
> sort to his or her environment.

I think my proposal is simpler: add ?f and ?F to built-in options, in
which case user is prompted for a custom sorting function (in your case,
`org-ip-lessp'). It is also more consistent with `org-sort-list'.

Also, IMO, IP address sort should not be built-in, and needs not with
the proposal above.

Regards,

next prev parent reply	other threads:[~2014-12-13 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19   ` Jon Snader
2014-12-13 14:29     ` Nicolas Goaziou [this message]
2014-12-13 15:19       ` Jon Snader
2014-12-13 16:01         ` Nicolas Goaziou
2014-12-13 18:47           ` Jon Snader
2014-12-13 22:07             ` Nicolas Goaziou
2014-12-13 22:37               ` Jon Snader
2014-12-14 11:25                 ` Nicolas Goaziou
2014-12-14 15:19                   ` Jon Snader
2014-12-14 17:18                     ` Nicolas Goaziou
2014-12-17 17:31                       ` Jon Snader
2014-12-20 11:57                         ` Nicolas Goaziou
2014-12-20 18:40                           ` Jon Snader
2014-12-20 20:55                             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx0z8vxw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=jsnader@mac.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).