From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jon Snader <jsnader@mac.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 13 Dec 2014 17:01:50 +0100 [thread overview]
Message-ID: <87oar78ro1.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <42DDD6AD-8F6F-4F85-840B-4C3946AD3C55@mac.com> (Jon Snader's message of "Sat, 13 Dec 2014 10:19:41 -0500")
Jon Snader <jsnader@mac.com> writes:
> The problem with that solution is that the user has to answer the
> additional prompts every time he calls org-table-sort-lines with
> a custom sort. Imagine, for example, a networking researcher who often
> builds tables that he or she wants to sort by IP address (or any other
> special format). Why should the researcher have to answer additional
> prompts every time a table needs to be sorted?
He doesn't need to. He could write his own sorting function, and bind it
to a key.
> What if a user wants to call org-do-sort from Elisp? We’d have to add
> additional parameters for the custom sort functions.
`org-do-sort' is an internal function, which isn't meant to be used
publicly. It really should be named `org-table--do-sort' and be moved
within "org-table.el". OTOH, we can extend `org-table-sort-lines' to
allow custom sorting function as a parameter.
> The solution I’m suggesting will simplify org-do-sort, make it easily
> expandable, and allow programmatic calls to it.
I disagree. It makes `org-do-sort'/`org-table-sort-line' more powerful,
but certainly not simpler. I'm pretty sure that anyone able to provide
an alist like you suggest is able to write his own sorting function
anyway. IOW, no one really gains any power in the process.
> It doesn’t really make it easier for the user because the extraction
> and compare functions will still have to be written (at least in most
> cases I can think of).
Extraction function is standard, AFAICT. Your solution doesn't solve
second point either.
> As for org-sort-list, it too would benefit from being table driven for
> the same reason that org-do-sort would: it enables users to define
> custom sorts. If we agree on this approach, I’ll submit another patch
> for org-sort-list.
As pointed out earlier, my concern is about simplicity.
What about simplifying your proposal so that associations are
(prompt-char . compare-function)
Extraction function would be always the same: the contents of the cell,
as a string, and prompt would be hard-coded for default compare
functions?
Regards,
next prev parent reply other threads:[~2014-12-13 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19 ` Jon Snader
2014-12-13 14:29 ` Nicolas Goaziou
2014-12-13 15:19 ` Jon Snader
2014-12-13 16:01 ` Nicolas Goaziou [this message]
2014-12-13 18:47 ` Jon Snader
2014-12-13 22:07 ` Nicolas Goaziou
2014-12-13 22:37 ` Jon Snader
2014-12-14 11:25 ` Nicolas Goaziou
2014-12-14 15:19 ` Jon Snader
2014-12-14 17:18 ` Nicolas Goaziou
2014-12-17 17:31 ` Jon Snader
2014-12-20 11:57 ` Nicolas Goaziou
2014-12-20 18:40 ` Jon Snader
2014-12-20 20:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oar78ro1.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jsnader@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).