emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jon Snader <jsnader@mac.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 13 Dec 2014 09:19:05 -0500	[thread overview]
Message-ID: <E61B599E-BF19-4DD7-98CF-A8BE8897024B@mac.com> (raw)
In-Reply-To: <87r3w4a326.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]


> On Dec 12, 2014, at 5:58 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> However I think the feature implemented is too specific. Instead,
> `org-do-sort' could provide a way to pass an arbitrary predicate,
> like ?f and ?F in `org-sort-list'.
> 
> WDYT?

Actually, when I originally looked at org-do-sort, my first thought was that it should be table driven. But this is my first patch and I’m the new kid so I didn’t want to come in and start tearing down walls.

My idea for making it table driven is to add an alist whose elements look something like

(prompt-char prompt extraction-function compare-function reverse-compare-function with-case-extraction-function)

The alist would be initialized with the built-in options (including the IP address sort) but a user could call add-to-list to add a custom sort to his or her environment.

If the list agrees, I will resubmit the patch implementing what I’ve described. As a procedural matter, should I submit it to this thread or add a new one?


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

  reply	other threads:[~2014-12-13 14:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19   ` Jon Snader [this message]
2014-12-13 14:29     ` Nicolas Goaziou
2014-12-13 15:19       ` Jon Snader
2014-12-13 16:01         ` Nicolas Goaziou
2014-12-13 18:47           ` Jon Snader
2014-12-13 22:07             ` Nicolas Goaziou
2014-12-13 22:37               ` Jon Snader
2014-12-14 11:25                 ` Nicolas Goaziou
2014-12-14 15:19                   ` Jon Snader
2014-12-14 17:18                     ` Nicolas Goaziou
2014-12-17 17:31                       ` Jon Snader
2014-12-20 11:57                         ` Nicolas Goaziou
2014-12-20 18:40                           ` Jon Snader
2014-12-20 20:55                             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E61B599E-BF19-4DD7-98CF-A8BE8897024B@mac.com \
    --to=jsnader@mac.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).