From: Jon Snader <jsnader@mac.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 13 Dec 2014 17:37:13 -0500 [thread overview]
Message-ID: <2217AFF8-7135-4EAC-A189-8152FDDE52F9@mac.com> (raw)
In-Reply-To: <87bnn78apu.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]
> On Dec 13, 2014, at 5:07 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> I don't think it needs to vary. As I suggested already, we can use cells
> contents (in the appropriate column) as trimmed strings. So, it could be
> built-in.
>
> Do you see any downside to it?
Well, I’m just going by what happens now. In org-do-sort, each of the sort options sets a different extraction function. For example, if you want a numeric sort, the extraction function calls string-to-number, while if you want an alphabetic sort it calls org-sort-remove-invisible. Really, this doesn’t matter because I was merely commenting on why (prompt . comparison) isn’t enough. Of course, you could roll any special extraction functionality into the comparison but I don’t really like that.
Anyway, what I was suggesting in my last post was that we duplicate the functionality of org-sort-list. There, if you’re calling it programmatically you specify getkey-func and compare-func. If you call it interactively, it asks you for the extraction function (which must return a string or number) and it tests it to see which comparison function to use. I like this approach because it makes org-sort-list and org-table-sort-lines work the same way. What’s not to like?
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 841 bytes --]
next prev parent reply other threads:[~2014-12-13 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19 ` Jon Snader
2014-12-13 14:29 ` Nicolas Goaziou
2014-12-13 15:19 ` Jon Snader
2014-12-13 16:01 ` Nicolas Goaziou
2014-12-13 18:47 ` Jon Snader
2014-12-13 22:07 ` Nicolas Goaziou
2014-12-13 22:37 ` Jon Snader [this message]
2014-12-14 11:25 ` Nicolas Goaziou
2014-12-14 15:19 ` Jon Snader
2014-12-14 17:18 ` Nicolas Goaziou
2014-12-17 17:31 ` Jon Snader
2014-12-20 11:57 ` Nicolas Goaziou
2014-12-20 18:40 ` Jon Snader
2014-12-20 20:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2217AFF8-7135-4EAC-A189-8152FDDE52F9@mac.com \
--to=jsnader@mac.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).