Re: Patch for growl notifications without uncommenting hacks

From: Christopher Suckling <suckling.list@googlemail.com>
To: David Abrahams <dave@boostpro.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>,
	Christopher Suckling <suckling.list@googlemail.com>
Subject: Re: Patch for growl notifications without uncommenting hacks
Date: Tue, 7 Apr 2009 09:12:40 +0100	[thread overview]
Message-ID: <03A40B38-6EFF-4C3A-BEEE-879BA1E30F87@gmail.com> (raw)
In-Reply-To: <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com>

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

On 7 Apr 2009, at 01:16, David Abrahams wrote:

>
> On Apr 6, 2009, at 6:27 PM, Christopher Suckling wrote:
>
>>
>> On 6 Apr 2009, at 01:49, David Abrahams wrote:
>>
>>>
>>> This patch to org-mac-message.el should make it show growl  
>>> notifications
>>> when searching for flagged messages and growl is running, and work
>>> silently otherwise.
>>>
>>
>> Thanks, works nicely.
>>
>> Below patch adapts for general case, cleans up commentary and fixes  
>> one tiny formatting bug I noticed.
>>
>> Best,
>>
>> Christopher
>>
>> <org-mac-message.patch>
>
>
> Nice tweak to the code, but I'm not sure it was a good idea to strip  
> out lisp comments from around the AppleScript.  There are some  
> oddball idioms in there whose rationale will have to be guessed by  
> the next person who comes along and wants to improve things.  Also,  
> I think the indentation I applied to the applescript strings do a  
> great deal to enhance comprehensibility at little or no cost.

And done.

Carsten, ignore yesterday's patch.

BTW, is there a way of automatically doing the AppleScript indentation  
(I lost it all when I ran indent-region on the buffer and was too  
tired last night to put it back in...)?

Best,

Christopher


[-- Attachment #2: org-mac-message.patch --]
[-- Type: application/octet-stream, Size: 5604 bytes --]

diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el
index fb71ebd..0f5249f 100644
--- a/lisp/org-mac-message.el
+++ b/lisp/org-mac-message.el
@@ -40,10 +40,6 @@
 ;; message:// links within the first level of the heading are deleted
 ;; and replaced with links to flagged messages.
 
-;; If you have Growl installed and would like more visual feedback
-;; whilst AppleScript searches for messages, please uncomment lines
-;; 114 to 119.
-
 ;;; Code:
 
 (require 'org)
@@ -86,40 +82,64 @@ This will use the command `open' with the message URL."
   (do-applescript
    (concat
     "tell application \"Mail\"\n"
-    "set theLinkList to {}\n"
-    "set theSelection to selection\n"
-    "repeat with theMessage in theSelection\n"
-    "set theID to message id of theMessage\n"
-    "set theSubject to subject of theMessage\n"
-    "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n"
-    "copy theLink to end of theLinkList\n"
-    "end repeat\n"
-    "return theLinkList as string\n"
+          "set theLinkList to {}\n"
+          "set theSelection to selection\n"
+          "repeat with theMessage in theSelection\n"
+                  "set theID to message id of theMessage\n"
+                  "set theSubject to subject of theMessage\n"
+                  "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n"
+                  "copy theLink to end of theLinkList\n"
+          "end repeat\n"
+          "return theLinkList as string\n"
     "end tell")))
 
 (defun as-get-flagged-mail ()
   "AppleScript to create links to flagged messages in Mail.app"
   (do-applescript
 	   (concat
+	    ;; Is Growl installed?
+	    "tell application \"System Events\"\n"
+	          "set growlHelpers to the name of every process whose creator type contains \"GRRR\"\n"
+	          "if (count of growlHelpers) > 0 then\n"
+	              "set growlHelperApp to item 1 of growlHelpers\n"
+	              "else\n"
+	              "set growlHelperApp to \"\"\n"
+	          "end if\n"
+	    "end tell\n"
+
+	    ;; Get links
 	    "tell application \"Mail\"\n"
-	    "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n"
-	    "set theLinkList to {}\n"
-	    "repeat with aMailbox in theMailboxes\n"
-	    "set theSelection to (every message in aMailbox whose flagged status = true)\n"
-	    "repeat with theMessage in theSelection\n"
-	    "set theID to message id of theMessage\n"
-	    "set theSubject to subject of theMessage\n"
-	    "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n"
-	    "copy theLink to end of theLinkList\n"
-	    ;; "tell application \"GrowlHelperApp\"\n"
-	    ;; "set the allNotificationsList to {\"FlaggedMail\"}\n"
-	    ;; "set the enabledNotificationsList to allNotificationsList\n"
-	    ;; "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n"
-	    ;; "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n"
-	    ;; "end tell\n"
-	    "end repeat\n"
-	    "end repeat\n"
-	    "return theLinkList as string\n"
+	          "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n"
+	          "set theLinkList to {}\n"
+	          "repeat with aMailbox in theMailboxes\n"
+	                  "set theSelection to (every message in aMailbox whose flagged status = true)\n"
+	                  "repeat with theMessage in theSelection\n"
+	                          "set theID to message id of theMessage\n"
+	                          "set theSubject to subject of theMessage\n"
+	                          "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n"
+	                          "copy theLink to end of theLinkList\n"
+
+	                          ;; Report progress through Growl
+                                  ;; This "double tell" idiom is described in detail at
+                                  ;; http://macscripter.net/viewtopic.php?id=24570 The
+				  ;; script compiler needs static knowledge of the
+				  ;; growlHelperApp.  Hmm, since we're compiling
+				  ;; on-the-fly here, this is likely to be way less
+				  ;; portable than I'd hoped.  It'll work when the name
+				  ;; is still "GrowlaHelperApp", though.
+				  "if growlHelperApp is not \"\" then\n"
+				      "tell application \"GrowlHelperApp\"\n"
+				            "tell application growlHelperApp\n"
+					          "set the allNotificationsList to {\"FlaggedMail\"}\n"
+						  "set the enabledNotificationsList to allNotificationsList\n"
+						  "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n"
+						  "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n"
+					    "end tell\n"
+				       "end tell\n"
+				  "end if\n"
+	                  "end repeat\n"
+	          "end repeat\n"
+	          "return theLinkList as string\n"
 	    "end tell")))
 
 (defun org-mac-message-get-links (select-or-flag)
@@ -188,6 +208,7 @@ list of message:// links to flagged mail after heading."
 		  (while (re-search-forward message-re (save-excursion (outline-next-heading)) t)
 		    
 		    (delete-region (match-beginning 0) (match-end 0)))
+		  (insert "\n")
 		  (org-mac-message-get-links "f")
 		  (yank))
 		(flush-lines "^$" (point) (outline-next-heading)))

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
