emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christopher Suckling <suckling.list@googlemail.com>
To: David Abrahams <dave@boostpro.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Patch for growl notifications without uncommenting hacks
Date: Mon, 6 Apr 2009 23:27:09 +0100	[thread overview]
Message-ID: <8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com> (raw)
In-Reply-To: <m2prfqobcc.fsf@boostpro.com>

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]


On 6 Apr 2009, at 01:49, David Abrahams wrote:

>
> This patch to org-mac-message.el should make it show growl  
> notifications
> when searching for flagged messages and growl is running, and work
> silently otherwise.
>

Thanks, works nicely.

Below patch adapts for general case, cleans up commentary and fixes  
one tiny formatting bug I noticed.

Best,

Christopher


[-- Attachment #2: org-mac-message.patch --]
[-- Type: application/octet-stream, Size: 3051 bytes --]

diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el
index fb71ebd..cef8603 100644
--- a/lisp/org-mac-message.el
+++ b/lisp/org-mac-message.el
@@ -40,10 +40,6 @@
 ;; message:// links within the first level of the heading are deleted
 ;; and replaced with links to flagged messages.
 
-;; If you have Growl installed and would like more visual feedback
-;; whilst AppleScript searches for messages, please uncomment lines
-;; 114 to 119.
-
 ;;; Code:
 
 (require 'org)
@@ -101,6 +97,17 @@ This will use the command `open' with the message URL."
   "AppleScript to create links to flagged messages in Mail.app"
   (do-applescript
 	   (concat
+	    ;; Is Growl installed?
+	    "tell application \"System Events\"\n"
+	    "set growlHelpers to the name of every process whose creator type contains \"GRRR\"\n"
+	    "if (count of growlHelpers) > 0 then\n"
+	    "set growlHelperApp to item 1 of growlHelpers\n"
+	    "else\n"
+	    "set growlHelperApp to \"\"\n"
+	    "end if\n"
+	    "end tell\n"
+
+	    ;; Get links
 	    "tell application \"Mail\"\n"
 	    "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n"
 	    "set theLinkList to {}\n"
@@ -111,12 +118,18 @@ This will use the command `open' with the message URL."
 	    "set theSubject to subject of theMessage\n"
 	    "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n"
 	    "copy theLink to end of theLinkList\n"
-	    ;; "tell application \"GrowlHelperApp\"\n"
-	    ;; "set the allNotificationsList to {\"FlaggedMail\"}\n"
-	    ;; "set the enabledNotificationsList to allNotificationsList\n"
-	    ;; "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n"
-	    ;; "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n"
-	    ;; "end tell\n"
+
+	    ;; Report progress through Growl
+            "if growlHelperApp is not \"\" then\n"
+	    "tell application \"GrowlHelperApp\"\n"
+	    "tell application growlHelperApp\n"
+	    "set the allNotificationsList to {\"FlaggedMail\"}\n"
+	    "set the enabledNotificationsList to allNotificationsList\n"
+	    "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n"
+	    "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n"
+	    "end tell\n"
+	    "end tell\n"
+            "end if\n"
 	    "end repeat\n"
 	    "end repeat\n"
 	    "return theLinkList as string\n"
@@ -188,6 +201,7 @@ list of message:// links to flagged mail after heading."
 		  (while (re-search-forward message-re (save-excursion (outline-next-heading)) t)
 		    
 		    (delete-region (match-beginning 0) (match-end 0)))
+		  (insert "\n")
 		  (org-mac-message-get-links "f")
 		  (yank))
 		(flush-lines "^$" (point) (outline-next-heading)))

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2009-04-06 22:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06  0:49 David Abrahams
2009-04-06 22:27 ` Christopher Suckling [this message]
2009-04-07  0:16   ` David Abrahams
2009-04-07  8:12     ` Christopher Suckling
     [not found]       ` <4F5F2D2E-636B-43CC-A957-1B29CC84BD99@boostpro.com>
2009-04-07 21:50         ` Christopher Suckling
2009-04-08 13:06           ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com \
    --to=suckling.list@googlemail.com \
    --cc=dave@boostpro.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Patch for growl notifications without uncommenting hacks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).