emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: David Abrahams <dave@boostpro.com>
To: Christopher Suckling <suckling.list@googlemail.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Patch for growl notifications without uncommenting hacks
Date: Mon, 6 Apr 2009 20:16:59 -0400	[thread overview]
Message-ID: <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com> (raw)
In-Reply-To: <8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com>


On Apr 6, 2009, at 6:27 PM, Christopher Suckling wrote:

>
> On 6 Apr 2009, at 01:49, David Abrahams wrote:
>
>>
>> This patch to org-mac-message.el should make it show growl  
>> notifications
>> when searching for flagged messages and growl is running, and work
>> silently otherwise.
>>
>
> Thanks, works nicely.
>
> Below patch adapts for general case, cleans up commentary and fixes  
> one tiny formatting bug I noticed.
>
> Best,
>
> Christopher
>
> <org-mac-message.patch>


Nice tweak to the code, but I'm not sure it was a good idea to strip  
out lisp comments from around the AppleScript.  There are some oddball  
idioms in there whose rationale will have to be guessed by the next  
person who comes along and wants to improve things.  Also, I think the  
indentation I applied to the applescript strings do a great deal to  
enhance comprehensibility at little or no cost.

--
David Abrahams
BoostPro Computing
http://boostpro.com

  reply	other threads:[~2009-04-07  0:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06  0:49 David Abrahams
2009-04-06 22:27 ` Christopher Suckling
2009-04-07  0:16   ` David Abrahams [this message]
2009-04-07  8:12     ` Christopher Suckling
     [not found]       ` <4F5F2D2E-636B-43CC-A957-1B29CC84BD99@boostpro.com>
2009-04-07 21:50         ` Christopher Suckling
2009-04-08 13:06           ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com \
    --to=dave@boostpro.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=suckling.list@googlemail.com \
    --subject='Re: Patch for growl notifications without uncommenting hacks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).