From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Abrahams <dave@boostpro.com>
Subject: Re: Patch for growl notifications without uncommenting hacks
Date: Mon, 6 Apr 2009 20:16:59 -0400
Message-ID: <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com>
References: <m2prfqobcc.fsf@boostpro.com>
	<8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com>
Mime-Version: 1.0 (Apple Message framework v930.4)
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lqz01-0001fi-Uq
	for emacs-orgmode@gnu.org; Mon, 06 Apr 2009 20:17:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lqyzw-0001fA-FP
	for emacs-orgmode@gnu.org; Mon, 06 Apr 2009 20:17:08 -0400
Received: from [199.232.76.173] (port=58580 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lqyzw-0001f2-Bo
	for emacs-orgmode@gnu.org; Mon, 06 Apr 2009 20:17:04 -0400
Received: from boost-consulting.com ([206.71.190.141]:62280)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dave@boostpro.com>) id 1Lqyzw-0006u8-1Z
	for emacs-orgmode@gnu.org; Mon, 06 Apr 2009 20:17:04 -0400
In-Reply-To: <8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Christopher Suckling <suckling.list@googlemail.com>
Cc: emacs-orgmode emacs-orgmode <emacs-orgmode@gnu.org>


On Apr 6, 2009, at 6:27 PM, Christopher Suckling wrote:

>
> On 6 Apr 2009, at 01:49, David Abrahams wrote:
>
>>
>> This patch to org-mac-message.el should make it show growl  
>> notifications
>> when searching for flagged messages and growl is running, and work
>> silently otherwise.
>>
>
> Thanks, works nicely.
>
> Below patch adapts for general case, cleans up commentary and fixes  
> one tiny formatting bug I noticed.
>
> Best,
>
> Christopher
>
> <org-mac-message.patch>


Nice tweak to the code, but I'm not sure it was a good idea to strip  
out lisp comments from around the AppleScript.  There are some oddball  
idioms in there whose rationale will have to be guessed by the next  
person who comes along and wants to improve things.  Also, I think the  
indentation I applied to the applescript strings do a great deal to  
enhance comprehensibility at little or no cost.

--
David Abrahams
BoostPro Computing
http://boostpro.com