From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Suckling Subject: Re: Patch for growl notifications without uncommenting hacks Date: Tue, 7 Apr 2009 09:12:40 +0100 Message-ID: <03A40B38-6EFF-4C3A-BEEE-879BA1E30F87@gmail.com> References: <8C94B64F-1D1C-424E-BE08-8B36AE8CC5CC@gmail.com> <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com> Mime-Version: 1.0 (Apple Message framework v930.3) Content-Type: multipart/mixed; boundary=Apple-Mail-22-939238973 Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lr6QL-0006df-PU for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 04:12:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lr6QK-0006dA-TV for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 04:12:49 -0400 Received: from [199.232.76.173] (port=46381 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lr6QK-0006d4-PF for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 04:12:48 -0400 Received: from ey-out-1920.google.com ([74.125.78.149]:11011) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lr6QI-0001Gw-7N for emacs-orgmode@gnu.org; Tue, 07 Apr 2009 04:12:46 -0400 Received: by ey-out-1920.google.com with SMTP id 13so422837eye.24 for ; Tue, 07 Apr 2009 01:12:44 -0700 (PDT) In-Reply-To: <63F655A3-484F-4055-B396-C1151BBD131B@boostpro.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Abrahams Cc: emacs-orgmode emacs-orgmode , Christopher Suckling --Apple-Mail-22-939238973 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On 7 Apr 2009, at 01:16, David Abrahams wrote: > > On Apr 6, 2009, at 6:27 PM, Christopher Suckling wrote: > >> >> On 6 Apr 2009, at 01:49, David Abrahams wrote: >> >>> >>> This patch to org-mac-message.el should make it show growl >>> notifications >>> when searching for flagged messages and growl is running, and work >>> silently otherwise. >>> >> >> Thanks, works nicely. >> >> Below patch adapts for general case, cleans up commentary and fixes >> one tiny formatting bug I noticed. >> >> Best, >> >> Christopher >> >> > > > Nice tweak to the code, but I'm not sure it was a good idea to strip > out lisp comments from around the AppleScript. There are some > oddball idioms in there whose rationale will have to be guessed by > the next person who comes along and wants to improve things. Also, > I think the indentation I applied to the applescript strings do a > great deal to enhance comprehensibility at little or no cost. And done. Carsten, ignore yesterday's patch. BTW, is there a way of automatically doing the AppleScript indentation (I lost it all when I ran indent-region on the buffer and was too tired last night to put it back in...)? Best, Christopher --Apple-Mail-22-939238973 Content-Disposition: attachment; filename=org-mac-message.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="org-mac-message.patch" Content-Transfer-Encoding: 7bit diff --git a/lisp/org-mac-message.el b/lisp/org-mac-message.el index fb71ebd..0f5249f 100644 --- a/lisp/org-mac-message.el +++ b/lisp/org-mac-message.el @@ -40,10 +40,6 @@ ;; message:// links within the first level of the heading are deleted ;; and replaced with links to flagged messages. -;; If you have Growl installed and would like more visual feedback -;; whilst AppleScript searches for messages, please uncomment lines -;; 114 to 119. - ;;; Code: (require 'org) @@ -86,40 +82,64 @@ This will use the command `open' with the message URL." (do-applescript (concat "tell application \"Mail\"\n" - "set theLinkList to {}\n" - "set theSelection to selection\n" - "repeat with theMessage in theSelection\n" - "set theID to message id of theMessage\n" - "set theSubject to subject of theMessage\n" - "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" - "copy theLink to end of theLinkList\n" - "end repeat\n" - "return theLinkList as string\n" + "set theLinkList to {}\n" + "set theSelection to selection\n" + "repeat with theMessage in theSelection\n" + "set theID to message id of theMessage\n" + "set theSubject to subject of theMessage\n" + "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" + "copy theLink to end of theLinkList\n" + "end repeat\n" + "return theLinkList as string\n" "end tell"))) (defun as-get-flagged-mail () "AppleScript to create links to flagged messages in Mail.app" (do-applescript (concat + ;; Is Growl installed? + "tell application \"System Events\"\n" + "set growlHelpers to the name of every process whose creator type contains \"GRRR\"\n" + "if (count of growlHelpers) > 0 then\n" + "set growlHelperApp to item 1 of growlHelpers\n" + "else\n" + "set growlHelperApp to \"\"\n" + "end if\n" + "end tell\n" + + ;; Get links "tell application \"Mail\"\n" - "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n" - "set theLinkList to {}\n" - "repeat with aMailbox in theMailboxes\n" - "set theSelection to (every message in aMailbox whose flagged status = true)\n" - "repeat with theMessage in theSelection\n" - "set theID to message id of theMessage\n" - "set theSubject to subject of theMessage\n" - "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" - "copy theLink to end of theLinkList\n" - ;; "tell application \"GrowlHelperApp\"\n" - ;; "set the allNotificationsList to {\"FlaggedMail\"}\n" - ;; "set the enabledNotificationsList to allNotificationsList\n" - ;; "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n" - ;; "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n" - ;; "end tell\n" - "end repeat\n" - "end repeat\n" - "return theLinkList as string\n" + "set theMailboxes to every mailbox of account \"" org-mac-mail-account "\"\n" + "set theLinkList to {}\n" + "repeat with aMailbox in theMailboxes\n" + "set theSelection to (every message in aMailbox whose flagged status = true)\n" + "repeat with theMessage in theSelection\n" + "set theID to message id of theMessage\n" + "set theSubject to subject of theMessage\n" + "set theLink to \"message://\" & theID & \"::split::\" & theSubject & \"\n\"\n" + "copy theLink to end of theLinkList\n" + + ;; Report progress through Growl + ;; This "double tell" idiom is described in detail at + ;; http://macscripter.net/viewtopic.php?id=24570 The + ;; script compiler needs static knowledge of the + ;; growlHelperApp. Hmm, since we're compiling + ;; on-the-fly here, this is likely to be way less + ;; portable than I'd hoped. It'll work when the name + ;; is still "GrowlaHelperApp", though. + "if growlHelperApp is not \"\" then\n" + "tell application \"GrowlHelperApp\"\n" + "tell application growlHelperApp\n" + "set the allNotificationsList to {\"FlaggedMail\"}\n" + "set the enabledNotificationsList to allNotificationsList\n" + "register as application \"FlaggedMail\" all notifications allNotificationsList default notifications enabledNotificationsList icon of application \"Mail\"\n" + "notify with name \"FlaggedMail\" title \"Importing flagged message\" description theSubject application name \"FlaggedMail\"\n" + "end tell\n" + "end tell\n" + "end if\n" + "end repeat\n" + "end repeat\n" + "return theLinkList as string\n" "end tell"))) (defun org-mac-message-get-links (select-or-flag) @@ -188,6 +208,7 @@ list of message:// links to flagged mail after heading." (while (re-search-forward message-re (save-excursion (outline-next-heading)) t) (delete-region (match-beginning 0) (match-end 0))) + (insert "\n") (org-mac-message-get-links "f") (yank)) (flush-lines "^$" (point) (outline-next-heading))) --Apple-Mail-22-939238973 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-22-939238973 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Remember: use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --Apple-Mail-22-939238973--