From: Max Nikulin <manikulin@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] make test: Make failure results more verbose
Date: Sat, 15 Jan 2022 20:06:44 +0700 [thread overview]
Message-ID: <srugt5$h10$1@ciao.gmane.io> (raw)
In-Reply-To: <srug31$t9s$1@ciao.gmane.io>
A couple of additional remarks.
On 15/01/2022 19:52, Max Nikulin wrote:
> On 02/01/2022 20:12, Ihor Radchenko wrote:
>
>> Subject: [PATCH] make test: Make failure results more verbose
>
> At first it was not clear to me that only *summary* of test results is
> affected.
Should not the variable be named BTEST_ERT_VERBOSE_SUMMARY instead of
just BTEST_ERT_VERBOSE due to this reason?
>>>> I am unsure if this line or local.mk has priority. I am unsure the the
>>>> following is better as well.
>>>> BTEST_ERT_VERBOSE ?= yes
>>>
>>> I am not very familiar with Makefile conventions. Just followed the
>>> existing settings in the same file. All other BTEST_ERT_* settings just
>>> use "=".
I have found an example when "?=" is better. It is possible to export
BTEST_ERT_VERBOSE from shell (or set in in the environment of continuous
integration runner) and the value will not be overridden. Quick tests
shell equivalent:
BTEST_ERT_VERBOSE= make test
currently it have to be written only as
make test-dirty BTEST_ERT_VERBOSE=
next prev parent reply other threads:[~2022-01-15 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 13:12 Ihor Radchenko
2022-01-03 5:35 ` Max Nikulin
2022-01-07 15:04 ` Ihor Radchenko
2022-01-11 16:46 ` Max Nikulin
2022-01-15 12:52 ` Max Nikulin
2022-01-15 13:06 ` Max Nikulin [this message]
2022-01-15 15:58 ` Max Nikulin
2022-01-21 13:33 ` Ihor Radchenko
2022-01-21 15:01 ` Max Nikulin
2022-01-23 13:31 ` Ihor Radchenko
2022-01-21 13:31 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='srugt5$h10$1@ciao.gmane.io' \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--subject='Re: [PATCH] make test: Make failure results more verbose' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).