From: Max Nikulin <manikulin@gmail.com> To: emacs-orgmode@gnu.org Subject: Re: [PATCH] make test: Make failure results more verbose Date: Mon, 3 Jan 2022 12:35:16 +0700 [thread overview] Message-ID: <squ1um$nj1$1@ciao.gmane.io> (raw) In-Reply-To: <87ee5q5lic.fsf@localhost> On 02/01/2022 20:12, Ihor Radchenko wrote: > > In newer Emacs, ERT is capable of providing more info about FAILED > tests. Maybe we can enable this option by default in the Org test suite? I like you attempts to make tests better. Ihor, are there examples of new error reports in mail lists, blogs, etc? I am not motivated enough to try development version of emacs, but my impression that current error log looks like rectangles of garbage. In my opinion, code of test should be written having clear error reports in mind. > +BTEST_ERT_VERBOSE = yes I am unsure if this line or local.mk has priority. I am unsure the the following is better as well. BTEST_ERT_VERBOSE ?= yes Is there an easy way to limit number of failures before termination of tests in the case of verbose reporting? It should prevent test log from blowing too much. Usually there is no point in all details if all or even 1/4 of tests fails. > + TMPDIR=$(testdir) EMACS_TEST_VERBOSE=yes $(BTEST) A purist would say that it is not a directory, it is something like ...FLAGS or ...ARGS. I know, it was abused before your patch. Shouldn't it be mentioned in testing/README?
next prev parent reply other threads:[~2022-01-03 5:36 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-02 13:12 Ihor Radchenko 2022-01-03 5:35 ` Max Nikulin [this message] 2022-01-07 15:04 ` Ihor Radchenko 2022-01-11 16:46 ` Max Nikulin 2022-01-15 12:52 ` Max Nikulin 2022-01-15 13:06 ` Max Nikulin 2022-01-15 15:58 ` Max Nikulin 2022-01-21 13:33 ` Ihor Radchenko 2022-01-21 15:01 ` Max Nikulin 2022-01-23 13:31 ` Ihor Radchenko 2022-01-21 13:31 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='squ1um$nj1$1@ciao.gmane.io' \ --to=manikulin@gmail.com \ --cc=emacs-orgmode@gnu.org \ --subject='Re: [PATCH] make test: Make failure results more verbose' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).