From: Ihor Radchenko <firstname.lastname@example.org> To: Max Nikulin <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] make test: Make failure results more verbose Date: Sun, 23 Jan 2022 21:31:56 +0800 [thread overview] Message-ID: <87zgnm60j7.fsf@localhost> (raw) In-Reply-To: <email@example.com> Max Nikulin <firstname.lastname@example.org> writes: >> Thanks! Your patch looks cleaner. > > In the meanwhile Lars fixed ERT in Emacs-29, so empty string is > considered as false now, see https://debbugs.gnu.org/53313 > Values like "no" should not be considered as false by Org makefiles, so > I am attaching an updated version. Looks good. I applied your patch on main as 2da104643. >> In addition, I am attaching a tentative hack to make ERT pretty-print >> the failure reason as you wished. WDYT? > > Sorry, I was not clear enough. Summary should remain single-line. There > are pretty-printed failure reason in the main part of the log. I was > complained concerning the following brick Got it. Make sense. Best, Ihor
next prev parent reply other threads:[~2022-01-23 13:31 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-02 13:12 Ihor Radchenko 2022-01-03 5:35 ` Max Nikulin 2022-01-07 15:04 ` Ihor Radchenko 2022-01-11 16:46 ` Max Nikulin 2022-01-15 12:52 ` Max Nikulin 2022-01-15 13:06 ` Max Nikulin 2022-01-15 15:58 ` Max Nikulin 2022-01-21 13:33 ` Ihor Radchenko 2022-01-21 15:01 ` Max Nikulin 2022-01-23 13:31 ` Ihor Radchenko [this message] 2022-01-21 13:31 ` Ihor Radchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87zgnm60j7.fsf@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] make test: Make failure results more verbose' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).